fix: restore postpublish verifier typecheck#109812
Conversation
403c633 to
dadebb5
Compare
|
Codex review: needs real behavior proof before merge. Reviewed July 17, 2026, 4:32 AM ET / 08:32 UTC. Summary PR surface: Other +1. Total +1 across 1 file. Reproducibility: yes. from source and validation evidence: current main imports the isolated JavaScript helper without a declaration, while the changed scripts gate passes after adding the matching signature. Review metrics: none identified. Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Next step before merge
Security Review detailsBest possible solution: Keep the postpublish verifier isolated from production source and land the adjacent declaration after the remaining required checks finish. Do we have a high-confidence way to reproduce the issue? Yes from source and validation evidence: current main imports the isolated JavaScript helper without a declaration, while the changed scripts gate passes after adding the matching signature. Is this the best way to solve the issue? Yes. An adjacent declaration is the narrowest maintainable fix because it restores static typing without undoing the deliberate release-tooling isolation. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 92e5a10f1a95. Label changesLabel changes:
Label justifications:
Evidence reviewedPR surface: Other +1. Total +1 across 1 file. View PR surface stats
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
|
Superseded while this was in the merge gate: |
What Problem This Solves
Fixes an issue where the scripts typecheck fails after the npm postpublish verifier moved to the isolated
error-format.mjshelper. TypeScript cannot infer that JavaScript module's exported signature without its matching declaration.Why This Change Was Made
Adds the standard adjacent
.d.mtsdeclaration for the existing helper. This preserves the release-tooling isolation introduced by8858944a81c5without routing the verifier back through production source.User Impact
No product behavior changes. Maintainer CI and postpublish-verifier validation can pass the scripts typecheck again.
Evidence
node scripts/run-vitest.mjs test/openclaw-npm-postpublish-verify.test.ts— 40 passed.node scripts/check-changed.mjs -- scripts/lib/error-format.d.mts— passed all script/tooling gates on Testbox: https://github.com/openclaw/openclaw/actions/runs/29566204572git diff --check— passed.AI-assisted maintainer fix. I reviewed and understand the change.