fix(google-meet): report blank Twilio setup credentials as missing#109674
Merged
steipete merged 2 commits intoJul 17, 2026
Conversation
clawsweeper
Bot
added
proof: sufficient
Contributor
|
Codex review: needs maintainer review before merge. Reviewed July 17, 2026, 1:34 AM ET / 05:34 UTC. Summary PR surface: Source +2, Tests +41. Total +43 across 2 files. Reproducibility: yes. at source level: setting all three Twilio environment variables to whitespace makes current-main setup logic treat them as truthy even though the runtime has no usable credentials. The review did not independently execute the checkout. Review metrics: none identified. Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Land the normalization and regression test after required exact-head checks complete, keeping setup readiness aligned with the canonical voice-call credential resolution behavior. Do we have a high-confidence way to reproduce the issue? Yes at source level: setting all three Twilio environment variables to whitespace makes current-main setup logic treat them as truthy even though the runtime has no usable credentials. The review did not independently execute the checkout. Is this the best way to solve the issue? Yes. Normalizing the environment fallbacks at the existing setup-check boundary is the narrowest maintainable fix and preserves config precedence and public messages. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 7e34687015a1. Label changesLabel changes:
Label justifications:
Evidence reviewedPR surface: Source +2, Tests +41. Total +43 across 2 files. View PR surface stats
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
Co-authored-by: ZengWen-DT <[email protected]>
Contributor
|
Merged via squash.
|
github-actions Bot
pushed a commit
to Desicool/openclaw
that referenced
this pull request
Jul 18, 2026
…penclaw#109674) * fix(google-meet): reject blank Twilio setup credentials * fix: centralize Google Meet voice setup values Co-authored-by: ZengWen-DT <[email protected]> --------- Co-authored-by: Peter Steinberger <[email protected]>
github-actions Bot
pushed a commit
to Desicool/openclaw
that referenced
this pull request
Jul 18, 2026
6a88b02 (openclaw#109674) landed unformatted, failing check-lint repo-wide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
Fixes an issue where
google_meetsetup_statusreported Twilio voice-call credentials as configured when the corresponding environment variables contained only whitespace. A later delegated call still had no usable Twilio credentials.Why This Change Was Made
The setup check now applies the same optional-string normalization to Twilio environment fallbacks that it already applies to plugin config values. Config precedence and the existing readiness message remain unchanged.
User Impact
Google Meet setup now reports the missing Twilio credential blocker before users attempt a delegated dial, matching the voice-call runtime's credential resolution.
Evidence
44b79d44ae1: with all three Twilio environment variables set to whitespace,getGoogleMeetSetupStatusreturned{ id: "twilio-voice-call-credentials", ok: true }, whileresolveVoiceCallConfig({ provider: "twilio" })returned nofromNumberand an emptytwiliocredential object.google_meettool proof after on7e34687015a:setup_statusreports the same credential check asfalsefor whitespace-only environment values; valid values still report ready.expected true to be false.node scripts/run-vitest.mjs extensions/google-meet/index.test.ts -t 'Twilio delegation readiness|whitespace-only Twilio environment credentials'— 2 passed, 143 skipped.git diff --checkpassed.AI-assisted: built with Codex.