fix(docker): explain unsupported E2E resource limits#109587
Merged
Merged
Conversation
openclaw-barnacle
Bot
added
scripts
steipete
force-pushed
the
fix/docker-e2e-resource-diagnostics
branch
3 times, most recently
from
July 17, 2026 03:40
a5b2ef2 to
0391c0c
Compare
steipete
force-pushed
the
fix/docker-e2e-resource-diagnostics
branch
from
July 17, 2026 03:46
0391c0c to
419b94f
Compare
Contributor
Author
|
AI-assisted (approved by Peter) Land-ready. The fix keeps Docker resource limits fail-closed, runs Docker once, streams original stderr, retains only a private 64 KiB tail for diagnosis, preserves the exit status, and points recognized cgroup incompatibilities to the existing explicit Proof: 173 focused helper tests passed; the signal-interruption case passed 5/5 repeated runs; fresh branch autoreview is clean; exact-head CI is green: https://github.com/openclaw/openclaw/actions/runs/29553208145 |
Contributor
Author
|
Merged via squash.
|
This was referenced Jul 17, 2026
github-actions Bot
pushed a commit
to Desicool/openclaw
that referenced
this pull request
Jul 17, 2026
* fix(docker): diagnose unsupported E2E resource limits * test(docker): track diagnostic temp dirs * fix(docker): bound resource diagnostic capture * fix(docker): restrict diagnostic FIFO access
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #98601
AI-assisted maintainer change approved by Peter.
What Problem This Solves
Fixes an issue where operators running Docker E2E on a runtime without the required cgroup resource controllers would receive a low-level Docker failure without an actionable explanation.
Why This Change Was Made
Keep resource limits fail-closed and make recognized Docker runtime incompatibilities actionable. The original error and exit status remain intact, Docker runs only once, live stderr remains streamed, and only a 64 KiB tail is retained for classification. The diagnostic points to the existing explicit
OPENCLAW_DOCKER_E2E_DISABLE_RESOURCE_LIMITS=1opt-out instead of silently retrying with weaker constraints.User Impact
Operators can distinguish an incompatible Docker runtime from other Docker failures and deliberately choose whether to repair cgroup support or opt out of E2E resource limits.
Evidence
node scripts/run-vitest.mjs test/scripts/docker-build-helper.test.ts— 173 passed.bash -n scripts/lib/docker-e2e-resource-diagnostics.sh scripts/lib/docker-e2e-container.sh scripts/lib/docker-e2e-package.sh— passed.node scripts/check-docker-e2e-boundaries.mjs— passed.git diff --check— passed..agents/skills/autoreview/scripts/autoreview --mode uncommitted— clean after fixing all accepted findings, including best-effort capture setup, Bash 3.2 synchronization, package fallback coverage, bounded capture, basename sourcing, and redirected-stderr preservation.main. Exact-head PR CI is the landing gate.