refactor(message): keep read fallback policy at call site#108930
Merged
Conversation
Contributor
Author
|
Land-ready at
|
Contributor
Author
|
Merged via squash.
|
github-actions Bot
pushed a commit
to Desicool/openclaw
that referenced
this pull request
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #108637
AI-assisted: Codex implemented and reviewed this maintainer-requested follow-up.
What Problem This Solves
The explicit-read fallback rule introduced while fixing #108637 lived behind a read-specific boolean in the shared channel selector. That made a generic selection helper own message-action policy and required toggle-specific selector tests.
Why This Change Was Made
Keep the policy at the message-action call site: explicit reads omit the current-conversation fallback, while implicit reads and non-read actions continue to pass it. Remove the single-caller selector option and its duplicate tests. The focused behavior suite remains the boundary proof.
User Impact
No user-visible behavior change. Explicit malformed, unknown, and unavailable read targets still fail closed; implicit reads and non-read fallback behavior remain unchanged.
Evidence
pnpm test src/infra/outbound/channel-selection.test.ts src/infra/outbound/message-action-runner.context.test.ts— 2 files, 49 tests passed. RunCI=1 pnpm check:changed— passed all selected format, typecheck, lint, boundary, and repository policy lanes on leasetbx_01kxn98ca5rzyrhq2tarbs3td7.git diff --check— passed.