fix(ci): bound non-root NodeSource setup download#108911
Merged
Merged
Conversation
Contributor
|
Merged via squash.
|
This was referenced Jul 16, 2026
github-actions Bot
pushed a commit
to Desicool/openclaw
that referenced
this pull request
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional instructions
MUST: Keep Allow edits from maintainers enabled for this PR so maintainers
can help update the branch when needed.
What Problem This Solves
Fixes an issue where CI and contributors building the non-root installer smoke image could wait indefinitely when the NodeSource setup script endpoint stalled. The existing pipeline could also execute a partial response before the download completed.
Why This Change Was Made
Download the NodeSource setup script to a unique temporary file with a 10-second connection timeout and a 120-second transfer limit, then execute it only after curl succeeds. This bounds only the setup-script fetch; the subsequent NodeSource setup and apt operations are unchanged.
User Impact
Non-root installer smoke image builds now fail within a bounded time when the NodeSource script download stalls, and they no longer execute a partially downloaded setup script.
Evidence
node scripts/run-vitest.mjs test/scripts/test-install-sh-docker.test.tson Node 24.15.0: 73 tests passed.oxfmt --check test/scripts/test-install-sh-docker.test.ts: passed.git diff --check: passed.