Skip to content

chore: speed up slow test coverage#108563

Merged
steipete merged 1 commit into
mainfrom
codex/test-performance-more-3
Jul 16, 2026
Merged

chore: speed up slow test coverage#108563
steipete merged 1 commit into
mainfrom
codex/test-performance-more-3

Conversation

@steipete

Copy link
Copy Markdown
Contributor

What Problem This Solves

Maintainer-requested test performance work. Several unit and Control UI tests spent seconds loading unrelated runtime graphs, advancing every intermediate fake-clock timer, or sleeping for fixed delays even though the behavior had a precise completion signal.

Why This Change Was Made

The tests now isolate the dependency actually under test, keep the real process-level rejection-containment proof while removing its redundant negative child process, shorten a real timer schedule without weakening its reset requirement, fast-forward long fake-clock gaps, and replace fixed browser sleeps with causal request, state, bridge, mutation, or rendering barriers. CI configuration and production behavior are unchanged.

User Impact

No user-visible behavior change. Developers and CI get faster test feedback with the same behavioral and security coverage.

Evidence

  • Fresh exact-head Blacksmith Testbox: 45 focused tests passed across unit-fast, infra, agents, and UI E2E shards in 1m29s.
  • Before/after examples from the measured slow-test pass: auth-profiles.doctor.test.ts 54,344ms -> 163ms; exec.no-output-timer.test.ts 2,261ms -> 1,027ms; callback fatal proof file 4,579ms -> 3,945ms on the fresh box (1,126ms warm).
  • Final targeted gates: oxfmt clean on all 10 files, core test types clean, oxlint 0 warnings/errors.
  • Repo-native check:changed completed successfully before the final synchronization refinements; every final refinement then received focused remote proof and the final targeted gates above.
  • Fresh branch-mode autoreview against origin/main: clean, no actionable findings.
  • AI-assisted: yes. I understand and reviewed the resulting test behavior.

@steipete
steipete requested a review from a team as a code owner July 16, 2026 02:23
@openclaw-barnacle openclaw-barnacle Bot added app: web-ui App: web-ui agents Agent runtime and tooling size: M maintainer Maintainer-authored PR labels Jul 16, 2026
@steipete
steipete force-pushed the codex/test-performance-more-3 branch from 367b21f to 87cd184 Compare July 16, 2026 02:52
@steipete

Copy link
Copy Markdown
Contributor Author

Land-ready on exact head 87cd1846e76e6a786c9fc692c0e7d1713295274e.

Proof:

  • Blacksmith Testbox tbx_01kxmddyxbw4sgy5qs9hn27zyr: 32 focused tests passed; delegated command 52.1s, exit 0.
  • pnpm test src/agents/auth-profiles.doctor.test.ts src/agents/embedded-agent-subscribe.callback-fatal.test.ts src/process/exec.no-output-timer.test.ts
  • pnpm test:ui:e2e ui/src/e2e/chat-composer-redesign.e2e.test.ts ui/src/e2e/chat-quota-pill-93041.e2e.test.ts ui/src/e2e/lobster-pet.e2e.test.ts ui/src/e2e/mantis-chat-proof.e2e.test.ts ui/src/e2e/session-transcript-search.e2e.test.ts ui/src/e2e/workspace-custom-widget.e2e.test.ts ui/src/pages/plugins/plugins.e2e.test.ts
  • Exact-head CI run 29467634742: success.
  • Repo-native prepare gate: passed. Review artifacts: READY, zero findings.
  • Fresh branch autoreview: clean; final rebase preserved identical stable patch-id.

Known proof gaps: none for this test-only patch. CI configuration and production code remain unchanged.

@steipete
steipete merged commit 957cc81 into main Jul 16, 2026
94 checks passed
@steipete
steipete deleted the codex/test-performance-more-3 branch July 16, 2026 02:59
@steipete

Copy link
Copy Markdown
Contributor Author

Merged via squash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agents Agent runtime and tooling app: web-ui App: web-ui maintainer Maintainer-authored PR size: M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant