Skip to content

refactor(deadcode): tighten more provider extension roots#108515

Merged
steipete merged 1 commit into
mainfrom
codex/harden-extension-root-deadcode-2
Jul 16, 2026
Merged

refactor(deadcode): tighten more provider extension roots#108515
steipete merged 1 commit into
mainfrom
codex/harden-extension-root-deadcode-2

Conversation

@steipete

Copy link
Copy Markdown
Contributor

What Problem This Solves

Production Knip treated every root TypeScript file in bundled provider plugins as an entry point. That hid internal unused exports even while the enforced dead-export baseline was empty.

Why This Change Was Made

Twelve additional provider workspaces now use exact runtime entry conventions instead of the broad root-file wildcard. The newly visible internal exports were privatized or deleted, and direct helper tests were migrated to retained provider, auth, catalog, synthesis, and realtime-session boundaries.

The patch removes 23 hidden export surfaces with no baseline additions. Production non-test code, including configuration, is +28/-48 lines (net -20).

User Impact

No user-visible behavior or provider contract changes. Future unused exports in these workspaces now fail the hard-zero production dead-code gate.

Evidence

  • Production Knip: hard zero (Knip unused-export check passed with 0 entries).
  • Fresh-base focused proof: 129 tests passed across the dead-code configuration and affected providers.
  • Full repository format check passed.
  • Pre-rebase full extension typed lint passed on 7,073 files; extension, core, and full test types passed. The fresh-base rerun was capped during the same broad typed-lint pass after exact Knip, format, and focused tests were green; source patch was unchanged by the disjoint rebase.
  • Autoreview: source/config clean at 0.96. Corrected test slice had no accepted finding; one claim that the MiniMax Date.now spy leaked was rejected because the file-level afterEach calls vi.restoreAllMocks().
  • Credential-shaped fixture files were manually whole-diff reviewed because the review bundle scanner rejected them.


async function createRealtimeServer(onRequest: (url: URL) => void) {
const server = createServer();
const wss = new WebSocketServer({ noServer: true });

async function createRealtimeServer(onRequest: (url: URL) => void) {
const server = createServer();
const wss = new WebSocketServer({ noServer: true });
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants