refactor(ui): isolate sidebar session presentation#108492
Merged
Merged
Conversation
openclaw-barnacle
Bot
added
app: web-ui
Contributor
Author
|
Merged via squash.
|
github-actions Bot
pushed a commit
to Desicool/openclaw
that referenced
this pull request
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
The Control UI sidebar presentation still kept the shell, brand, footer, session rows, groups, pagination, and catalog wiring in one file. After the recent behavior-layer split,
app-sidebar.tsremained just below the 700-line budget, leaving little headroom and making presentation-only changes span unrelated sidebar surfaces.Why This Change Was Made
Move the session-list and catalog presentation unchanged into one focused abstract layer in the existing sidebar class chain. The concrete custom element now owns only the brand, shell, footer, and custom-element registration; there is no new DOM boundary, compatibility path, or duplicate renderer.
User Impact
No user-visible or visual change. Maintainers get smaller presentation ownership surfaces and durable max-lines headroom.
Evidence
tbx_01kxm032jwv0wwwa5nf7wpj5nd: targeted format check passed.pnpm test ui/src/components/app-sidebar.test.ts: 78 passed.pnpm test ui/src/e2e/sidebar-customization.e2e.test.ts: 8 passed in Chromium.pnpm check:changed: passed forcoreTests, ui, including UI/core test types, lint, formatting, i18n verification, and max-lines ratchet.Remote proof run
AI-assisted: yes.