improve: speed CLI capture tests#107993
Merged
Merged
Conversation
openclaw-barnacle
Bot
added
agents
Contributor
Author
|
Land-ready at exact head Proof:
Production behavior is unchanged. The late-admission grace contract remains directly covered by |
github-actions Bot
pushed a commit
to Desicool/openclaw
that referenced
this pull request
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
Two CLI runner test suites spent most of their test-body time waiting for the MCP loopback late-admission grace period, despite testing CLI capture behavior rather than the grace period itself.
Why This Change Was Made
The suites now partially mock the MCP loopback runtime and force only the test-local admission grace to zero. Production behavior stays unchanged, and the real late-admission timing contract remains covered in
src/gateway/mcp-http.test.ts.User Impact
No user-visible behavior change. Developers and CI get faster focused CLI runner feedback.
Evidence
src/agents/cli-runner.reliability.test.ts: 2.984s -> 0.818s test-body time (72.6% faster), 79/79 passing.src/agents/cli-runner.spawn.test.ts: 2.355s -> 1.295s test-body time (45.0% faster), 89/89 passing.check:changedreached an inherited staleextensions/qa-matrix/src/substrate/client.tsmax-lines baseline entry already present onorigin/main; no failure involved either changed test file.