Skip to content

refactor(plugins): split plugin installation flows#107960

Merged
steipete merged 2 commits into
mainfrom
codex/refactor-plugin-install
Jul 15, 2026
Merged

refactor(plugins): split plugin installation flows#107960
steipete merged 2 commits into
mainfrom
codex/refactor-plugin-install

Conversation

@steipete

Copy link
Copy Markdown
Contributor

What Problem This Solves

The plugin installer had grown into a 3,267-line module spanning local packages, npm metadata, managed npm state, rollback, quarantine, and archive flows. That made ownership boundaries difficult to review and forced the file onto the max-lines suppression list.

Why This Change Was Made

Split installation into source- and lifecycle-focused modules while retaining src/plugins/install.ts as the stable public facade. Runtime behavior, exported APIs, security scanning, audit events, rollback, and managed npm generation semantics remain unchanged.

User Impact

No user-visible behavior change. Maintainers get smaller installation modules, clearer dependency direction, and removal of the max-lines suppression.

Evidence

  • node scripts/run-vitest.mjs src/plugins/install.path.test.ts: 4 passed
  • node scripts/run-vitest.mjs src/plugins/install.test.ts src/plugins/install.npm-spec.test.ts: 165 passed
  • Blacksmith Testbox npm registry E2E: 12 passed
  • Blacksmith Testbox full build: passed
  • Changed core and core-test typechecks: passed
  • Targeted oxlint for all split installer modules: passed
  • Full core lint reached unrelated existing failures in src/agents/embedded-agent-runner/**; no installer lint failures
  • Fresh autoreview before commit and after rebase: no accepted/actionable findings

AI-assisted. Maintainer-requested refactor; implementation and proof reviewed before submission.

@openclaw-barnacle openclaw-barnacle Bot added size: XL maintainer Maintainer-authored PR labels Jul 15, 2026
@steipete steipete self-assigned this Jul 15, 2026
@steipete
steipete merged commit 3eb8b3a into main Jul 15, 2026
160 of 163 checks passed
@steipete
steipete deleted the codex/refactor-plugin-install branch July 15, 2026 03:51
@steipete

Copy link
Copy Markdown
Contributor Author

Merged via squash.

github-actions Bot pushed a commit to Desicool/openclaw that referenced this pull request Jul 15, 2026
* refactor(plugins): split plugin installation flows

* fix(plugins): keep compatibility helper private
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintainer Maintainer-authored PR size: XL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant