fix(nextcloud-talk): restore replay test typecheck#107808
Merged
Merged
Conversation
openclaw-barnacle
Bot
added
channel: nextcloud-talk
Contributor
Author
|
Land-ready.
|
Contributor
Author
|
Merged via squash.
|
This was referenced Jul 14, 2026
github-actions Bot
pushed a commit
to Desicool/openclaw
that referenced
this pull request
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
Resolves a problem where the full test-types CI shard fails on current
mainwhile type-checking the Nextcloud Talk replay response mock.Why This Change Was Made
The response mock was asserted as a complete
ServerResponseat its declaration, which erased the object literal's contextualthistype. The assertion now sits only at the listener boundary, preserving the partial mock's inferred method receiver while keeping the production listener contract unchanged.User Impact
No user-visible behavior change. CI can type-check the test suite again.
Evidence
check-test-types:Property 'headersSent' does not exist on type '{}'.tbx_01kxhb58jezv7et2ttkc0w9yga:pnpm test extensions/nextcloud-talk/src/monitor.replay.test.ts— 10/10 passed.pnpm check:test-types— passed.