Skip to content

refactor(discord): trim internal exports#107714

Merged
steipete merged 3 commits into
mainfrom
codex/burn-dead-exports-discord
Jul 14, 2026
Merged

refactor(discord): trim internal exports#107714
steipete merged 3 commits into
mainfrom
codex/burn-dead-exports-discord

Conversation

@steipete

Copy link
Copy Markdown
Contributor

What Problem This Solves

The shrink-only dead-export baseline still carried 54 Discord entries, including internal types, constants, helper functions, and facade reexports that production code does not consume.

Why This Change Was Made

Privatizes or removes 42 verified dead Discord exports and migrates direct tests through retained production boundaries or canonical SDK owners. Twelve mutable runtime, component-registry, cache-reset, and testing seams remain unchanged because they still represent stateful test or lifecycle boundaries.

The production-mode Knip cascade exposed one additional test-only facade reexport, splitChannelApprovalCapability. Its test now imports the canonical plugin SDK owner and the Discord facade reexport is removed without adding a baseline row.

Baseline delta: +0/-42 entries, 544 to 502 total; Discord 54 to 12. Production source excluding the baseline: +39/-79 lines, net -40.

User Impact

No user-visible Discord or CLI behavior changes. The internal module surface and enforced dead-export ratchet are smaller.

Evidence

  • Production Knip regeneration: byte-identical 502-entry baseline; exact deadcode check matched 502.
  • Discord suite plus focused repaired reruns: 175 files and 2,119 passing assertions across the final behavior paths.
  • Focused approval-native rerun: 14/14.
  • Format, type-aware Discord lint, extension types, core types, and test types: green.
  • Fresh autoreview: clean at 0.94; cascade follow-up review clean at 0.87.
  • Final rebase crossed only disjoint Bonjour, QA Lab, proxy, CLI-test, docs, and generated SDK-hash changes. Fresh Testbox allocation remained queued and was stopped under the requested direct-land override; source patch and baseline count were unchanged.

@openclaw-barnacle openclaw-barnacle Bot added channel: discord Channel integration: discord scripts Repository scripts labels Jul 14, 2026
@steipete
steipete merged commit af3d796 into main Jul 14, 2026
40 of 42 checks passed
@steipete
steipete deleted the codex/burn-dead-exports-discord branch July 14, 2026 18:34
@openclaw-barnacle openclaw-barnacle Bot added the maintainer Maintainer-authored PR label Jul 14, 2026
github-actions Bot pushed a commit to Desicool/openclaw that referenced this pull request Jul 15, 2026
* refactor(discord): trim internal exports

* refactor(discord): use canonical approval helper

* chore(deadcode): refresh export baseline
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

channel: discord Channel integration: discord maintainer Maintainer-authored PR scripts Repository scripts size: L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant