Skip to content

fix(ui): restore lint for context test imports#107618

Merged
steipete merged 1 commit into
mainfrom
fix/ui-test-type-import-lint
Jul 14, 2026
Merged

fix(ui): restore lint for context test imports#107618
steipete merged 1 commit into
mainfrom
fix/ui-test-type-import-lint

Conversation

@steipete

Copy link
Copy Markdown
Contributor

What Problem This Solves

Fixes an issue where the main CI lint shard fails on two Control UI tests after their context imports were rewritten with inline type specifiers.

Why This Change Was Made

Uses declaration-level type-only imports so TypeScript erases the full import instead of leaving a runtime side-effect import. No runtime or test behavior changes.

User Impact

No user-visible behavior change. Main and dependent PR CI can pass the lint shard again.

Evidence

  • Reproduced in CI run 29344330108, job 87124263692: typescript(no-import-type-side-effects) on both touched files.
  • node scripts/run-oxlint.mjs ui/src/pages/memory-import/memory-import-page.test.ts ui/src/pages/profile/profile-page.test.ts
  • git diff --check
  • Autoreview: clean, zero accepted/actionable findings.

AI-assisted. I reviewed and understand the change.

@openclaw-barnacle openclaw-barnacle Bot added app: web-ui App: web-ui size: XS maintainer Maintainer-authored PR labels Jul 14, 2026
@steipete

Copy link
Copy Markdown
Contributor Author

Land-ready proof:

  • CI run 29345336053: success, including check-lint, checks-ui, test types, build artifacts, and changed Node tests.
  • Targeted local proof: node scripts/run-oxlint.mjs ui/src/pages/memory-import/memory-import-page.test.ts ui/src/pages/profile/profile-page.test.ts.
  • git diff --check: pass.
  • Autoreview: clean; zero accepted/actionable findings.
  • scripts/pr prepare-run 107618: pass; exact PR head 98d6ccb38cc6ac2c761365c4706be42b1ae9b53c.

Known proof gaps: none for this test-only import-shape repair.

@steipete
steipete merged commit 5087804 into main Jul 14, 2026
87 of 91 checks passed
@steipete
steipete deleted the fix/ui-test-type-import-lint branch July 14, 2026 15:34
@steipete

Copy link
Copy Markdown
Contributor Author

Merged via squash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app: web-ui App: web-ui maintainer Maintainer-authored PR size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant