Skip to content

refactor(agents): remove dead internal test seams#106956

Merged
steipete merged 2 commits into
mainfrom
codex/burn-dead-exports-agents-test-seams-20
Jul 14, 2026
Merged

refactor(agents): remove dead internal test seams#106956
steipete merged 2 commits into
mainfrom
codex/burn-dead-exports-agents-test-seams-20

Conversation

@steipete

Copy link
Copy Markdown
Contributor

What Problem This Solves

Production-mode Knip still grandfathered 20 internal agent exports used only by tests. Those exports kept test-only state, dependency-injection hooks, schemas, constants, and pure helpers on production module surfaces.

Why This Change Was Made

The agent tests now exercise retained production entry points or canonical owner modules instead of exported test seams. The matching baseline rows are deleted. Newly exposed façade exports are removed without adding baseline entries. The cross-subsystem message-action reset cascade stays isolated in its own conventional commit.

User Impact

No documented CLI, plugin SDK, configuration, or runtime behavior changes. Internal module surfaces shrink; meaningful policy, parsing, media, timeout, schema, and cleanup coverage remains.

Evidence

  • Exact production Knip regeneration is byte-stable at 1,169 entries, down from 1,189; src/agents/** is 239, down from 259.
  • Testbox tbx_01kxf2trfd999gw1gp6pqtzft4, Actions run 29297908599: exact regeneration, deadcode:exports, and 20 focused files passed (523 tests; 4 Windows-only skips).
  • Patch-identical pre-rebase proof: targeted formatting, type-aware lint, tsgo:core, and check:test-types passed.
  • Fresh whole-diff autoreview: clean, confidence 0.95, after fixing its browser-policy coverage finding.
  • Diff: baseline +0/-20; production source +22/-113; tests +553/-456; total +575/-589 across 43 files.

@openclaw-barnacle openclaw-barnacle Bot added scripts Repository scripts agents Agent runtime and tooling size: XL maintainer Maintainer-authored PR labels Jul 14, 2026
@steipete

Copy link
Copy Markdown
Contributor Author

Land-ready proof for exact head 0416983f0c00550308b0c895a8378679f92e5147 on base 18a452055fd84afbce745094ec6dc0b43a32ed8c:

  • Testbox tbx_01kxf2trfd999gw1gp6pqtzft4 / Actions 29297908599: regeneration byte-stable at 1,169, deadcode:exports exact, 523 focused tests passed, 4 Windows-only skips.
  • Patch-identical pre-rebase proof: targeted formatting, type-aware lint, tsgo:core, and check:test-types green.
  • Whole-diff autoreview clean at 0.95 after its browser-policy coverage finding was fixed and re-proved.
  • Signed two-commit stack; channels cascade isolated from the agents/baseline commit.
  • Hosted CI intentionally not awaited under the requested focused direct-land override. No known proof gaps on the changed surfaces.

@steipete
steipete merged commit dc61172 into main Jul 14, 2026
78 of 81 checks passed
@steipete
steipete deleted the codex/burn-dead-exports-agents-test-seams-20 branch July 14, 2026 01:14
github-actions Bot pushed a commit to Desicool/openclaw that referenced this pull request Jul 14, 2026
* refactor(channels): remove dead action discovery reset

* refactor(agents): remove dead internal test seams
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agents Agent runtime and tooling maintainer Maintainer-authored PR scripts Repository scripts size: XL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant