Skip to content

refactor(shared): privatize internal helpers#106868

Merged
steipete merged 1 commit into
mainfrom
codex/burn-dead-exports-shared
Jul 13, 2026
Merged

refactor(shared): privatize internal helpers#106868
steipete merged 1 commit into
mainfrom
codex/burn-dead-exports-shared

Conversation

@steipete

Copy link
Copy Markdown
Contributor

What Problem This Solves

Ten helpers, constants, and one storage adapter type across src/shared were exported only for tests, leaving private implementation details in the production dead-export baseline.

Why This Change Was Made

Makes those symbols module-private. Tests retain Unicode node matching, Windows runtime-import normalization, runtime requirement evaluation, device-auth storage, silent-reply defaults, and token formatting coverage through the surviving production entry points.

Baseline delta: 1,265 → 1,255 (+0/-10). No Plugin SDK or documented package surface changes.

User Impact

No user-visible behavior change. Runtime eligibility, device authentication, node selection, lazy imports, silent replies, and subagent usage formatting keep their existing behavior.

Evidence

  • Blacksmith Testbox tbx_01kxess9vbahndk349w0rsag8e, run 29290229006: exact regeneration byte-stable at 1,255; dead-export checker and formatting green
  • Same Testbox: touched-path typed lint green; focused shared tests 56/56; core types green
  • Follow-up on the same lease: tuple-inference repair proved with node-match 13/13 and core test types green
  • Exact external-name search found no remaining test import of the privatized symbols
  • Fresh autoreview: no accepted/actionable findings, patch correct at 0.96
  • Latest main movement has no src/shared or baseline overlap

@openclaw-barnacle openclaw-barnacle Bot added scripts Repository scripts size: M maintainer Maintainer-authored PR labels Jul 13, 2026
@steipete

Copy link
Copy Markdown
Contributor Author

Land-ready proof for signed head e368321ce9d23bcd6d9c2b676db8583d0fb73e40.

  • Exact dead-export regeneration/checker: Testbox tbx_01kxess9vbahndk349w0rsag8e, run 29290229006, baseline 1,265 → 1,255 (+0/-10)
  • Formatting and touched-path typed lint green
  • Six focused shared suites: 56/56; core types green
  • Tuple-inference follow-up: node-match 13/13 and core test types green
  • Tests preserve Unicode, Windows path, token-rollover, and default-policy coverage through retained production seams
  • Fresh autoreview: no accepted/actionable findings, patch correct at 0.96

No hosted-CI wait per maintainer instruction.

@steipete
steipete merged commit 0b96300 into main Jul 13, 2026
54 of 61 checks passed
@steipete
steipete deleted the codex/burn-dead-exports-shared branch July 13, 2026 22:40
wm0018 pushed a commit to wm0018/openclaw that referenced this pull request Jul 14, 2026
github-actions Bot pushed a commit to Desicool/openclaw that referenced this pull request Jul 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintainer Maintainer-authored PR scripts Repository scripts size: M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant