refactor(onboard): remove obsolete node manager options#106593
Merged
Conversation
openclaw-barnacle
Bot
added
commands
vincentkoc
marked this pull request as ready for review
July 13, 2026 16:49
Member
Author
|
Land-ready proof:
Known proof gaps: none for the touched onboarding surface. |
Member
Author
|
Merged via squash.
|
wm0018
pushed a commit
to wm0018/openclaw
that referenced
this pull request
Jul 14, 2026
github-actions Bot
pushed a commit
to Desicool/openclaw
that referenced
this pull request
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
The onboarding module still exported a node-manager option builder after the interactive selector that consumed it was removed. That left a false internal API surface and matching test scaffolding with no runtime behavior behind either one.
Why This Change Was Made
Remove the obsolete helper, its now-unused type import, and the stale mock entry. Node-manager selection remains owned by the existing
resolveDefaultNodeManagerpath in skill onboarding; this change does not alter selection, validation, persistence, or installer behavior.User Impact
No user-visible behavior changes. The onboarding surface is smaller and no longer advertises an unused package-manager choice API.
Evidence
resolveNodeManagerOptionshad zero incomingCALLSorUSAGEedges.Streamline OpenClaw onboarding(Streamline OpenClaw onboarding #98218) removed the helper's only caller when it replaced the interactive selector withresolveDefaultNodeManager.resolveNodeManagerOptionsreturns zero results.tbx_01kxe5k8ry8ntqjeqqtybzecv6, run https://github.com/openclaw/openclaw/actions/runs/29267341934:pnpm test:serial src/commands/onboard-skills.test.ts src/commands/onboard-helpers.test.ts- 59/59 tests passed.pnpm check:changed -- src/commands/onboard-helpers.ts src/commands/onboard-skills.test.ts- passed.gpt-5.6-solmedium review: no findings, confidence 0.98.