fix(msteams): remove unused attachment helper#106461
Conversation
|
Codex review: needs real behavior proof before merge. Reviewed July 13, 2026, 11:53 AM ET / 15:53 UTC. Summary PR surface: Source -7. Total -7 across 1 file. Reproducibility: yes. at source and hosted-gate level: an unused private function deterministically triggers the reported TS6133 check, although the failure was not rerun here against the newer current-main SHA. Review metrics: none identified. Root-cause cluster Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Rebase or refresh onto current main, verify the helper remains unused, and land the deletion once the production TypeScript gate confirms the current merge result is clean. Do we have a high-confidence way to reproduce the issue? Yes at source and hosted-gate level: an unused private function deterministically triggers the reported TS6133 check, although the failure was not rerun here against the newer current-main SHA. Is this the best way to solve the issue? Yes. Deleting an unreachable delegating wrapper while retaining the canonical resolver is the narrowest maintainable fix and avoids adding suppression or compatibility code. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 260a5c6e2b1f. Label changesLabel changes:
Label justifications:
Evidence reviewedPR surface: Source -7. Total -7 across 1 file. View PR surface stats
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
What Problem This Solves
Current
mainfails the production TypeScript gate after #106279 madebuildMSTeamsAttachmentPlaceholderprivate without removing it. TypeScript reports TS6133 because the helper has no callers.Why This Change Was Made
Delete the unused wrapper. Its only behavior delegates directly to
resolveMSTeamsInboundAttachmentPresentation, which remains the canonical production API.User Impact
No runtime behavior change. This restores the production typecheck on current
main.Evidence
extensions/msteams/src/attachments/html.ts(109,10): error TS6133.