Skip to content

refactor(agents): trim exec approval exports#106401

Merged
steipete merged 1 commit into
mainfrom
codex/dead-exports-agents-exec-approval
Jul 13, 2026
Merged

refactor(agents): trim exec approval exports#106401
steipete merged 1 commit into
mainfrom
codex/dead-exports-agents-exec-approval

Conversation

@steipete

Copy link
Copy Markdown
Contributor

Related: #105595

What Problem This Solves

The shrink-only dead-export ratchet still carried four src/agents exec-approval entries, preserving internal and test-only API surface that production does not use.

Why This Change Was Made

This privatizes the two registration helpers and the follow-up prompt builder, removes the test-only runtime-handoff reset export, and moves affected tests through production-used public entry points. The dead-export baseline drops only those four entries.

User Impact

No user-visible behavior change. The agents package exposes four fewer unused symbols, reducing internal API surface and future maintenance debt.

Evidence

  • Blacksmith Testbox lease tbx_01kxdrfjv5ad3n15dqw2b8g29v (Actions run)
  • Targeted oxfmt and oxlint: pass
  • Focused tests: 335 passed across the approval follow-up, approval request, shared exec-host, bash-tools, and gateway-agent suites
  • pnpm deadcode:exports:update: byte-stable at 2,642 entries
  • pnpm deadcode:exports: pass
  • pnpm check:test-types and pnpm tsgo:core: pass
  • Fresh autoreview: no findings, 0.96 confidence

AI-assisted with Codex; implementation and proof reviewed before submission.

@openclaw-barnacle openclaw-barnacle Bot added gateway Gateway runtime scripts Repository scripts agents Agent runtime and tooling size: S maintainer Maintainer-authored PR labels Jul 13, 2026
@steipete

Copy link
Copy Markdown
Contributor Author

Land-ready proof at exact head 9a99b6a984169a175efb5e05ed012119cb834f58.

Blacksmith Testbox lease: tbx_01kxdrfjv5ad3n15dqw2b8g29v

  • pnpm exec oxfmt --check <8 touched TS files>: pass
  • node scripts/run-oxlint.mjs <8 touched TS files>: pass
  • pnpm test src/agents/bash-tools.exec-approval-followup.test.ts src/agents/bash-tools.exec-approval-request.test.ts src/agents/bash-tools.exec-host-shared.test.ts src/agents/bash-tools.test.ts src/gateway/server-methods/agent.test.ts: 335 passed
  • pnpm deadcode:exports:update: byte-stable at 2,642 entries
  • pnpm deadcode:exports: pass
  • pnpm check:test-types: pass
  • pnpm tsgo:core: pass
  • Fresh autoreview: no findings, confidence 0.96
  • Repo-native review artifacts: validated, zero findings

Known proof gaps: none for this internal-only export shrink; there is no user-visible runtime behavior to live-test.

@steipete
steipete merged commit 2a7132a into main Jul 13, 2026
140 of 146 checks passed
@steipete
steipete deleted the codex/dead-exports-agents-exec-approval branch July 13, 2026 13:03
@steipete

Copy link
Copy Markdown
Contributor Author

Merged via squash.

wm0018 pushed a commit to wm0018/openclaw that referenced this pull request Jul 14, 2026
github-actions Bot pushed a commit to Desicool/openclaw that referenced this pull request Jul 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agents Agent runtime and tooling gateway Gateway runtime maintainer Maintainer-authored PR scripts Repository scripts size: S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant