fix(mac): allow five-minute node worker cold starts#106380
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2b0378c9b4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| ### Fixes | ||
|
|
||
| - **macOS node startup:** allow up to five minutes for cold node-host plugin discovery before timing out, preventing slow Codex-supervision startup from leaving the Mac disconnected. |
There was a problem hiding this comment.
For a normal fix/direct-main change, this added CHANGELOG.md entry makes the change fail the repo's normal PR/prepare path: scripts/pr-lib/gates.sh rejects any root changelog diff unless OPENCLAW_ALLOW_ROOT_CHANGELOG_PR is set for explicit release automation, and AGENTS.md:279 says release generation owns this file. Keep the release-note context in the commit/PR text so release generation can derive the final changelog without blocking or duplicating notes.
Useful? React with 👍 / 👎.
|
Merged via squash.
|
* fix(mac): extend node worker startup timeout * chore: keep release notes in PR
* fix(mac): extend node worker startup timeout * chore: keep release notes in PR
1 participant
What Problem This Solves
Cold macOS node-host startup can spend more than two minutes loading configured plugins and Codex supervision. The existing hard deadline can therefore leave an otherwise healthy Mac node disconnected.
Why This Change Was Made
Raise the existing bounded startup deadline from two minutes to five minutes. This keeps a hard failure bound while giving cold plugin discovery practical headroom.
User Impact
Mac nodes remain able to connect during slow cold starts instead of timing out while the worker is still healthy.
Evidence
swift test --package-path apps/macos --filter MacNodeHostWorkerTests— 8 tests passedFollow-up to #106281.