refactor(deadcode): trim msteams private exports#106279
Conversation
openclaw-barnacle
Bot
added
channel: msteams
|
Land-ready proof:
Broad CI intentionally not awaited for this internal surface-cleanup batch. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: afceda8a90
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } | ||
|
|
||
| export function buildMSTeamsAttachmentPlaceholder( | ||
| function buildMSTeamsAttachmentPlaceholder( |
There was a problem hiding this comment.
This helper became an unexported local after all imports/callers were moved to resolveMSTeamsInboundAttachmentPresentation; repo-wide search now finds only this declaration, and tsconfig.extensions.json enables noUnusedLocals for production extension files. Any changed/typecheck lane that includes the Teams extension will fail on this unused declaration, so delete the wrapper instead of only dropping the export.
Useful? React with 👍 / 👎.
Companion to 4bb4ffc: check-lint (no-unused-vars) still fails on attachments.helpers.test.ts after openclaw#106279 trimmed their usages.
* refactor(deadcode): trim msteams private exports * chore(deadcode): refresh unused export baseline
Companion to 4bb4ffc: check-lint (no-unused-vars) still fails on attachments.helpers.test.ts after openclaw#106279 trimmed their usages.
* refactor(deadcode): trim msteams private exports * chore(deadcode): refresh unused export baseline
Companion to 9082d8b: check-lint (no-unused-vars) still fails on attachments.helpers.test.ts after openclaw#106279 trimmed their usages.
1 participant
What Problem This Solves
Microsoft Teams retained 13 internal exports for private helpers, facade aliases, and a test-only type path. Two feedback-reflection helpers were only reachable from tests and had no production caller.
Related: #105595
Why This Change Was Made
Keep the shipped plugin entrypoint unchanged. Remove private re-export seams, keep helper implementations module-local, delete the unused learning reader and cooldown reset, and move tests to defining modules or public behavior surfaces.
User Impact
No runtime behavior change. This batch removes 13 unused-export findings. After rebasing onto current main, the shrink-only baseline contains 3,307 entries.
Evidence
node scripts/check-deadcode-exports.mjs --updatenode scripts/check-deadcode-exports.mjspnpm deadcode:dependenciespnpm format:checkgit diff --check