fix: resolve #10616 #10614 #10613 #10610 #10607 (WhatsApp sendTo, run…#10620
Closed
d1maash wants to merge 1 commit intoopenclaw:mainfrom
Closed
fix: resolve #10616 #10614 #10613 #10610 #10607 (WhatsApp sendTo, run…#10620d1maash wants to merge 1 commit intoopenclaw:mainfrom
d1maash wants to merge 1 commit intoopenclaw:mainfrom
Conversation
openclaw#10607 (WhatsApp sendTo, runtime guardrails, compaction retry, cron restart scheduling, Feishu WS appType)
openclaw-barnacle
bot
added
channel: whatsapp-web
Author
SummaryThis PR addresses the 5 latest open issues in
Testing
Linked issues
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Comment on lines
+69
to
+71
| if (hasSendToRestriction && !sendTo.entries.includes(normalizedTo)) { | ||
| return { ok: false, error: notAllowedSendToError() }; | ||
| } |
Contributor
There was a problem hiding this comment.
Empty sendTo bypass
If channels.whatsapp.sendTo (or per-account sendTo) is configured but normalizes down to an empty list (e.g., only invalid numbers, whitespace, or only group JIDs), hasSendToRestriction becomes false and outbound DMs fall back to allowFrom/to behavior. That effectively disables the intended outbound restriction without an explicit opt-out. This is reachable whenever the config contains any non-empty-but-invalid entries.
Consider treating a configured-but-empty-after-normalization sendTo as "block all DMs" (or surface a config error) so operators don’t get a silent bypass.
Prompt To Fix With AI
This is a comment left during a code review.
Path: src/channels/plugins/outbound/whatsapp.ts
Line: 69:71
Comment:
**Empty `sendTo` bypass**
If `channels.whatsapp.sendTo` (or per-account `sendTo`) is configured but normalizes down to an empty list (e.g., only invalid numbers, whitespace, or only group JIDs), `hasSendToRestriction` becomes false and outbound DMs fall back to `allowFrom`/`to` behavior. That effectively disables the intended outbound restriction without an explicit opt-out. This is reachable whenever the config contains any non-empty-but-invalid entries.
Consider treating a *configured-but-empty-after-normalization* `sendTo` as "block all DMs" (or surface a config error) so operators don’t get a silent bypass.
How can I resolve this? If you propose a fix, please make it concise.
Contributor
|
Fixed in #12988. This will go out in the next OpenClaw release. If you still see this after updating to the first release that includes #12988, please open a new issue with:
Link back here for context. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…time guardrails, compaction retry, cron restart scheduling, Feishu WS appType)
Greptile Overview
Greptile Summary
before_tool_callhook wrapper.nextRunAtMsacross service restarts so missed runs remain due.sendToallowlist (global + per-account) enforced for DM sends, and sets Feishu WS clientappTypeexplicitly.sendTosettings, with tests covering the guardrails/hook integration.Confidence Score: 3/5
sendTorestriction logic can be bypassed whensendTois configured but normalizes to an empty allowlist, which is a realistic misconfiguration and undermines the feature’s security intent.(2/5) Greptile learns from your feedback when you react with thumbs up/down!