fix(delivery): prevent duplicate generated-media handoffs#105717
Conversation
4fc9ad6 to
eca7bf1
Compare
|
Codex review: stale review; fresh review needed. Summary Next step |
af71fcc to
3476e57
Compare
|
Land-ready proof for exact head 714a81b: Testbox tbx_01kxc3z4kwtx37jb1xjtd7gp1y passed 691 focused tests plus an 83/83 final regression rerun; fresh full-branch gpt-5.6-sol/high autoreview reported no actionable findings at 0.88 confidence; all 72 exact-head GitHub checks passed; native OPENCLAW_TESTBOX=1 scripts/pr prepare-run 105717 passed. Live Discord reproduction remains follow-up proof before closing issue #88307. Landing to main with rebase/no squash. |
|
Merged via rebase.
|
What Problem This Solves
Generated media can be delivered twice when a model both sends it through the message tool and returns the same media in its completion payload. Legacy global delivery telemetry also cannot safely identify which route carried a payload when a run targets multiple routes.
Fixes #88307.
Why This Change Was Made
Delivery deduplication now compares completion payloads against route-scoped message-tool evidence. Account fallback is resolved only when routing did not already select an account and the channel plugin exposes account enumeration. Ambiguous global-only evidence is deliberately ignored for multi-route runs so valid payloads are not dropped.
User Impact
Users no longer receive duplicate generated-media handoffs on a single route. Multi-route deliveries retain payloads unless evidence proves the same payload was already sent on that route.
Evidence
tbx_01kxc3z4kwtx37jb1xjtd7gp1y.gpt-5.6-solhigh autoreview reported no accepted or actionable findings after the regression fixes.git diff --checkpasses.@smithy/node-http-handlershrinkwrap override mismatch. The exact focused touched-surface proof above is green; exact-head GitHub CI remains required before merge.