Skip to content

fix(ci): keep unused exports advisory#105704

Merged
vincentkoc merged 2 commits into
mainfrom
fix/ci-frozen-deadcode-probes
Jul 12, 2026
Merged

fix(ci): keep unused exports advisory#105704
vincentkoc merged 2 commits into
mainfrom
fix/ci-frozen-deadcode-probes

Conversation

@vincentkoc

@vincentkoc vincentkoc commented Jul 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

What Problem This Solves

Current CI release tooling could not validate the frozen release/2026.7.1
candidate because a new unused-export ratchet was treated as a required target
contract even though that release predates it.

Why This Change Was Made

Keep the established dependency and unused-file checks as the required CI
contract for current and frozen targets. The unused-export baseline remains
available through pnpm deadcode:exports as an advisory maintenance scan, and
older frozen targets retain their aggregate deadcode:ci fallback.

User Impact

No runtime impact. Maintainers can validate frozen release candidates without
backporting newly introduced CI tooling, while dependency and unused-file
regressions remain blocked.

Evidence

  • Blacksmith Testbox tbx_01kxc491nn56aj109j70afrs5t, run
    29210013950: 53 workflow guard tests passed.
  • actionlint .github/workflows/ci.yml
  • oxfmt --check on all changed files
  • git diff --check
  • Autoreview clean, correctness 0.93

@vincentkoc vincentkoc self-assigned this Jul 12, 2026
@vincentkoc
vincentkoc marked this pull request as ready for review July 12, 2026 21:03
@openclaw-barnacle openclaw-barnacle Bot added size: S maintainer Maintainer-authored PR labels Jul 12, 2026
@clawsweeper clawsweeper Bot added rating: 🦞 diamond lobster Very strong PR readiness with only minor maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. P2 Normal backlog priority with limited blast radius. labels Jul 12, 2026
@clawsweeper

clawsweeper Bot commented Jul 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Codex review: needs changes before merge. Reviewed July 12, 2026, 5:45 PM ET / 21:45 UTC.

Summary
The PR makes unused-export scanning advisory, retains required dependency and unused-file checks, adds a legacy aggregate fallback for frozen targets, and updates workflow fixtures and CI documentation.

PR surface: Tests +94, Docs 0, Config +9. Total +103 across 3 files.

Reproducibility: yes. The v2026.6.11 package lacks deadcode:exports, while current main invokes that newer command after checking only for deadcode:dependencies; the first PR commit demonstrates the failing contract and a narrow compatibility repair.

Review metrics: 1 noteworthy metric.

  • Required CI policy: 1 enforced ratchet removed. The latest head changes current-target merge protection in addition to repairing frozen-target compatibility.

Stored data model
Persistent data-model change detected: serialized state: test/scripts/ci-workflow-guards.test.ts. Confirm migration or upgrade compatibility proof before merge.

Merge readiness
Overall: 🦐 gold shrimp
Proof: 🌊 off-meta tidepool
Patch quality: 🦐 gold shrimp
Result: ready for maintainer review.

Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch.

Rank-up moves:

  • Restore current-target unused-export enforcement while retaining historical capability fallback.

Risk before merge

  • [P1] Merging this head would let new unused exports and stale required baseline entries pass the required dependency shard, reversing a current-main automation guard rather than only adapting frozen release validation.

Maintainer options:

  1. Restore split enforcement (recommended)
    Keep unused-export enforcement for current targets while using available historical scripts and the legacy aggregate fallback for frozen targets.
  2. Accept the enforcement rollback
    Merge as written only if maintainers explicitly intend unused-export baseline drift to stop blocking current-target CI.
Copy recommended automerge instruction 
@clawsweeper automerge

Special instructions:
Restore required `pnpm deadcode:exports` execution for non-historical/current targets, retain capability-based historical checks plus the legacy `deadcode:ci` fallback, and align workflow fixtures and docs with that split contract.

Next step before merge

  • The blocker is narrow and mechanical: restore the split current-versus-historical contract already present in the first PR commit, while retaining the later legacy fallback.

Security
Cleared: The patch changes checked-out package-script dispatch without adding permissions, secret access, dependency sources, action references, downloads, or broader third-party execution.

Review findings

  • [P1] Restore the current-target unused-export ratchet — .github/workflows/ci.yml:1606-1609
Review details

Best possible solution:

Preserve deadcode:exports as required for current targets, capability-select target-owned checks for frozen targets, retain the legacy deadcode:ci fallback, and align the fixtures and docs with that split contract.

Do we have a high-confidence way to reproduce the issue?

Yes. The v2026.6.11 package lacks deadcode:exports, while current main invokes that newer command after checking only for deadcode:dependencies; the first PR commit demonstrates the failing contract and a narrow compatibility repair.

Is this the best way to solve the issue?

No. Capability-based dispatch is the right mechanism, but the latest head also disables current-target export enforcement even though the earlier head proves the historical compatibility problem can be solved without that rollback.

Full review comments:

  • [P1] Restore the current-target unused-export ratchet — .github/workflows/ci.yml:1606-1609
    This branch skips deadcode:exports even when the current checked-out target provides it, so new unused exports and stale required baseline entries no longer fail check-dependencies. The immediately preceding merged contract intentionally enforced that ratchet, and the first commit on this PR already demonstrates the narrower fix: preserve it for current targets while capability-selecting historical scripts.
    Confidence: 0.98

Overall correctness: patch is incorrect
Overall confidence: 0.97

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning high; reviewed against 7c72fef247a9.

Label changes

Label changes:

  • add merge-risk: 🚨 automation: The branch stops required CI from rejecting new or stale unused-export baseline entries.
  • add rating: 🦐 gold shrimp: Overall readiness is 🦐 gold shrimp; proof is 🌊 off-meta tidepool and patch quality is 🦐 gold shrimp.
  • add status: ⏳ waiting on author: ClawSweeper has contributor-facing work open and is waiting for author action. Not applicable: The external-contributor proof gate does not apply to this repository-member PR; the supplied Testbox workflow-guard run and exact-head CI are appropriate supplemental evidence.
  • remove rating: 🦞 diamond lobster: Current PR rating is rating: 🦐 gold shrimp, so this older rating label is no longer current.
  • remove status: 👀 ready for maintainer look: Current PR status label is status: ⏳ waiting on author.

Label justifications:

  • P2: This is a bounded contributor-facing CI regression with release-validation impact but no runtime user impact.
  • merge-risk: 🚨 automation: The branch stops required CI from rejecting new or stale unused-export baseline entries.
  • rating: 🦐 gold shrimp: Overall readiness is 🦐 gold shrimp; proof is 🌊 off-meta tidepool and patch quality is 🦐 gold shrimp.
  • status: ⏳ waiting on author: ClawSweeper has contributor-facing work open and is waiting for author action. Not applicable: The external-contributor proof gate does not apply to this repository-member PR; the supplied Testbox workflow-guard run and exact-head CI are appropriate supplemental evidence.
Evidence reviewed

PR surface:

Tests +94, Docs 0, Config +9. Total +103 across 3 files.

View PR surface stats
Area Files Added Removed Net
Source 0 0 0 0
Tests 1 94 0 +94
Docs 1 1 1 0
Config 1 12 3 +9
Generated 0 0 0 0
Other 0 0 0 0
Total 3 107 4 +103

Acceptance criteria:

  • [P1] node scripts/run-vitest.mjs test/scripts/ci-workflow-guards.test.ts.
  • [P1] actionlint .github/workflows/ci.yml.
  • [P1] pnpm format:check -- .github/workflows/ci.yml docs/ci.md test/scripts/ci-workflow-guards.test.ts.
  • [P1] git diff --check.

What I checked:

  • Current-head behavior: The dependency shard invokes only deadcode:dependencies and deadcode:unused-files whenever those scripts exist, including current targets, so deadcode:exports is no longer enforced. (.github/workflows/ci.yml:1606, 02656354d317)
  • Established CI contract: Merged commit a425807 added the unused-export baseline as a required dependency-shard ratchet and documented that new findings and stale required entries fail CI. (.github/workflows/ci.yml:1597, a425807c31d3)
  • Narrow repair already demonstrated: The first commit on this PR preserved deadcode:exports for current targets while selecting target-owned historical checks, proving frozen compatibility does not require removing current enforcement. (.github/workflows/ci.yml:1599, 90c4a6ffb1f4)
  • Historical incompatibility: The shipped v2026.6.11 package exposes dependency and unused-file dead-code scripts but not the newer deadcode:exports command, confirming the frozen-target reproduction. (package.json:130, e085fa1a3ffd)

Likely related people:

  • steipete: Authored the merged unused-export ratchet and recent historical-target CI framework, making this the strongest routing candidate for the intended enforcement contract. (role: introduced current behavior; confidence: high; commits: a425807c31d3, 36e81bf45eca; files: .github/workflows/ci.yml, test/scripts/ci-workflow-guards.test.ts, scripts/check-deadcode-exports.mjs)
  • vincentkoc: Authored both revisions of this repair and has prior merged history on release CI and dead-code configuration surfaces. (role: recent CI area contributor; confidence: high; commits: 90c4a6ffb1f4, 02656354d317, e085fa1a3ffd; files: .github/workflows/ci.yml, test/scripts/ci-workflow-guards.test.ts, docs/ci.md)
What the crustacean ranks mean
  • 🦀 challenger crab: rare, exceptional readiness with strong proof, clean implementation, and convincing validation.
  • 🦞 diamond lobster: very strong readiness with only minor maintainer review expected.
  • 🐚 platinum hermit: good normal PR, likely mergeable with ordinary maintainer review.
  • 🦐 gold shrimp: useful signal, but proof or patch confidence is still limited.
  • 🦪 silver shellfish: thin signal; proof, validation, or implementation needs work.
  • 🧂 unranked krab: not merge-ready because proof is missing/unusable or there are serious correctness or safety concerns.
  • 🌊 off-meta tidepool: rating does not apply to this item.

Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

How this review workflow works
  • ClawSweeper keeps one durable marker-backed review comment per issue or PR.
  • Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
  • A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
  • PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
  • Maintainers can also comment @clawsweeper review to request a fresh review only.
  • Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
  • Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
  • Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.
Review history (1 earlier review cycle)
  • reviewed 2026-07-12T21:11:39.117Z sha 90c4a6f :: needs maintainer review before merge. :: none

@vincentkoc vincentkoc changed the title fix(ci): preserve frozen deadcode contracts fix(ci): keep unused exports advisory Jul 12, 2026
@openclaw-barnacle openclaw-barnacle Bot added the docs Improvements or additions to documentation label Jul 12, 2026
@vincentkoc
vincentkoc merged commit 2c06dfd into main Jul 12, 2026
99 of 103 checks passed
@vincentkoc
vincentkoc deleted the fix/ci-frozen-deadcode-probes branch July 12, 2026 21:47
@vincentkoc

vincentkoc commented Jul 12, 2026

Copy link
Copy Markdown
Member Author

Merged via squash.

@clawsweeper clawsweeper Bot added rating: 🦐 gold shrimp Decent PR readiness signal, but merge confidence is limited. status: ⏳ waiting on author ClawSweeper has contributor-facing work open and is waiting for author action. merge-risk: 🚨 automation 🚨 May affect CI, automerge, proof capture, label sync, or maintainer automation. and removed rating: 🦞 diamond lobster Very strong PR readiness with only minor maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. labels Jul 12, 2026
@github-actions github-actions Bot mentioned this pull request Jul 12, 2026
Open
@steipete steipete mentioned this pull request Jul 13, 2026
Merged
github-actions Bot pushed a commit to Desicool/openclaw that referenced this pull request Jul 13, 2026
@vincentkoc
fix(ci): keep unused exports advisory (openclaw#105704)
49d7c1c 
* fix(ci): preserve frozen deadcode contracts

* fix(ci): keep unused exports advisory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@vincentkoc vincentkoc

Labels

docs Improvements or additions to documentation maintainer Maintainer-authored PR merge-risk: 🚨 automation 🚨 May affect CI, automerge, proof capture, label sync, or maintainer automation. P2 Normal backlog priority with limited blast radius. rating: 🦐 gold shrimp Decent PR readiness signal, but merge confidence is limited. size: S status: ⏳ waiting on author ClawSweeper has contributor-facing work open and is waiting for author action.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@vincentkoc