Skip to content

refactor(process): trim internal type surface#105599

Merged
vincentkoc merged 1 commit into
mainfrom
refactor/trim-process-internals
Jul 12, 2026
Merged

refactor(process): trim internal type surface#105599
vincentkoc merged 1 commit into
mainfrom
refactor/trim-process-internals

Conversation

@vincentkoc

Copy link
Copy Markdown
Member

What Problem This Solves

The process supervisor exposed a dead mode alias and two result/registry types that have no consumers outside their defining modules. This adds accidental type surface without a contract.

Why This Change Was Made

  • Delete the unused SpawnMode alias and its barrel re-export; SpawnInput already owns the closed "child" | "pty" modes.
  • Keep RunRegistry private to the registry implementation.
  • Keep SpawnWithFallbackResult private to the spawn utility.

User Impact

No runtime behavior change. Supervisor spawning, registry retention, and fallback execution use the same implementations and return shapes.

Evidence

  • Exhaustive repository search and codebase-memory indexing found zero SpawnMode consumers, only a local RunRegistry plus the test's inferred alias, and only a local SpawnWithFallbackResult.
  • Testbox: 15 focused process tests passed.
  • Testbox check:changed passed the full core lane.
  • Fresh gpt-5.6-sol medium autoreview: no findings, 0.98 confidence.
  • git diff --check: passed.

@vincentkoc vincentkoc self-assigned this Jul 12, 2026
@openclaw-barnacle openclaw-barnacle Bot added size: XS maintainer Maintainer-authored PR labels Jul 12, 2026
@vincentkoc

Copy link
Copy Markdown
Member Author

Land-ready proof:

  • Exact PR head: 5c443ae8b63094b6f138f4311adae546f4304d36.
  • Testbox tbx_01kxbn3ckehgvj12frmwbya7re: 15 focused process tests passed.
  • Testbox touched-file check:changed: full core lane passed.
  • Fresh gpt-5.6-sol medium autoreview: no findings, patch correct, 0.98 confidence.
  • Codebase-memory index and exhaustive search found no SpawnMode consumer and no outside consumer for the two privatized result types.
  • git diff --check: passed.
  • scripts/pr review-validate-artifacts 105599: passed.
  • OPENCLAW_TESTBOX=1 scripts/pr prepare-run 105599: hosted exact-head gates passed.

No docs or changelog update is required for this internal type cleanup.

@vincentkoc
vincentkoc marked this pull request as ready for review July 12, 2026 18:28
@vincentkoc
vincentkoc merged commit 26c4187 into main Jul 12, 2026
107 of 109 checks passed
@vincentkoc
vincentkoc deleted the refactor/trim-process-internals branch July 12, 2026 18:28
@vincentkoc

Copy link
Copy Markdown
Member Author

Merged via squash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintainer Maintainer-authored PR size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant