feat(feishu): add quota optimization flags#10513
Merged
Takhoffman merged 2 commits intoopenclaw:mainfrom Feb 28, 2026
Merged
Conversation
Contributor
Additional Comments (1)
Prompt To Fix With AIThis is a comment left during a code review.
Path: extensions/feishu/src/bot.ts
Line: 526:529
Comment:
**Permission error variable scope**
`permissionErrorForAgent` is assigned inside the `resolveSenderNames` flag block, but it is no longer declared in the function scope (it used to be declared before the block). This will be a runtime/TS error (or will reference an outer variable unintentionally) and also breaks the later `if (permissionErrorForAgent)` notification path.
```suggestion
// Track permission error to inform agent later (with cooldown to avoid repetition)
let permissionErrorForAgent: PermissionError | undefined;
// Resolve sender display name (best-effort) so the agent can attribute messages correctly.
// Optimization: skip if disabled to save API quota (Feishu free tier limit)
if (feishuCfg?.resolveSenderNames !== false) {
```
How can I resolve this? If you propose a fix, please make it concise. |
b016bad to
48a28c5
Compare
bfc1ccb to
f92900f
Compare
|
This pull request has been automatically marked as stale due to inactivity. |
Contributor
|
The feature idea is good, but this PR is not ready to land in current form. What is good:
What is missing/blocking:
Recommended next step:
|
48a28c5 to
482316b
Compare
r4jiv007
pushed a commit
to r4jiv007/openclaw
that referenced
this pull request
Feb 28, 2026
…igUncle Verified: - pnpm build - pnpm check - pnpm vitest run --config vitest.extensions.config.ts extensions/feishu/src/config-schema.test.ts extensions/feishu/src/reply-dispatcher.test.ts extensions/feishu/src/bot.test.ts Co-authored-by: BigUncle <[email protected]> Co-authored-by: Tak Hoffman <[email protected]>
mylukin
pushed a commit
to mylukin/openclaw
that referenced
this pull request
Feb 28, 2026
…igUncle Verified: - pnpm build - pnpm check - pnpm vitest run --config vitest.extensions.config.ts extensions/feishu/src/config-schema.test.ts extensions/feishu/src/reply-dispatcher.test.ts extensions/feishu/src/bot.test.ts Co-authored-by: BigUncle <[email protected]> Co-authored-by: Tak Hoffman <[email protected]>
wanjizheng
pushed a commit
to wanjizheng/openclaw
that referenced
this pull request
Feb 28, 2026
…igUncle Verified: - pnpm build - pnpm check - pnpm vitest run --config vitest.extensions.config.ts extensions/feishu/src/config-schema.test.ts extensions/feishu/src/reply-dispatcher.test.ts extensions/feishu/src/bot.test.ts Co-authored-by: BigUncle <[email protected]> Co-authored-by: Tak Hoffman <[email protected]>
wanjizheng
pushed a commit
to wanjizheng/openclaw
that referenced
this pull request
Feb 28, 2026
…igUncle Verified: - pnpm build - pnpm check - pnpm vitest run --config vitest.extensions.config.ts extensions/feishu/src/config-schema.test.ts extensions/feishu/src/reply-dispatcher.test.ts extensions/feishu/src/bot.test.ts Co-authored-by: BigUncle <[email protected]> Co-authored-by: Tak Hoffman <[email protected]> (cherry picked from commit fe0659a)
wanjizheng
pushed a commit
to wanjizheng/openclaw
that referenced
this pull request
Feb 28, 2026
…igUncle Verified: - pnpm build - pnpm check - pnpm vitest run --config vitest.extensions.config.ts extensions/feishu/src/config-schema.test.ts extensions/feishu/src/reply-dispatcher.test.ts extensions/feishu/src/bot.test.ts Co-authored-by: BigUncle <[email protected]> Co-authored-by: Tak Hoffman <[email protected]> (cherry picked from commit fe0659a)
wanjizheng
pushed a commit
to wanjizheng/openclaw
that referenced
this pull request
Feb 28, 2026
…igUncle Verified: - pnpm build - pnpm check - pnpm vitest run --config vitest.extensions.config.ts extensions/feishu/src/config-schema.test.ts extensions/feishu/src/reply-dispatcher.test.ts extensions/feishu/src/bot.test.ts Co-authored-by: BigUncle <[email protected]> Co-authored-by: Tak Hoffman <[email protected]> (cherry picked from commit fe0659a)
vincentkoc
pushed a commit
to Sid-Qin/openclaw
that referenced
this pull request
Feb 28, 2026
…igUncle Verified: - pnpm build - pnpm check - pnpm vitest run --config vitest.extensions.config.ts extensions/feishu/src/config-schema.test.ts extensions/feishu/src/reply-dispatcher.test.ts extensions/feishu/src/bot.test.ts Co-authored-by: BigUncle <[email protected]> Co-authored-by: Tak Hoffman <[email protected]>
vincentkoc
pushed a commit
to rylena/rylen-openclaw
that referenced
this pull request
Feb 28, 2026
…igUncle Verified: - pnpm build - pnpm check - pnpm vitest run --config vitest.extensions.config.ts extensions/feishu/src/config-schema.test.ts extensions/feishu/src/reply-dispatcher.test.ts extensions/feishu/src/bot.test.ts Co-authored-by: BigUncle <[email protected]> Co-authored-by: Tak Hoffman <[email protected]>
newtontech
pushed a commit
to newtontech/openclaw-fork
that referenced
this pull request
Feb 28, 2026
…igUncle Verified: - pnpm build - pnpm check - pnpm vitest run --config vitest.extensions.config.ts extensions/feishu/src/config-schema.test.ts extensions/feishu/src/reply-dispatcher.test.ts extensions/feishu/src/bot.test.ts Co-authored-by: BigUncle <[email protected]> Co-authored-by: Tak Hoffman <[email protected]>
wanjizheng
pushed a commit
to wanjizheng/openclaw
that referenced
this pull request
Mar 1, 2026
…igUncle Verified: - pnpm build - pnpm check - pnpm vitest run --config vitest.extensions.config.ts extensions/feishu/src/config-schema.test.ts extensions/feishu/src/reply-dispatcher.test.ts extensions/feishu/src/bot.test.ts Co-authored-by: BigUncle <[email protected]> Co-authored-by: Tak Hoffman <[email protected]>
wanjizheng
pushed a commit
to wanjizheng/openclaw
that referenced
this pull request
Mar 1, 2026
…igUncle Verified: - pnpm build - pnpm check - pnpm vitest run --config vitest.extensions.config.ts extensions/feishu/src/config-schema.test.ts extensions/feishu/src/reply-dispatcher.test.ts extensions/feishu/src/bot.test.ts Co-authored-by: BigUncle <[email protected]> Co-authored-by: Tak Hoffman <[email protected]>
6 tasks
hughdidit
pushed a commit
to hughdidit/DAISy-Agency
that referenced
this pull request
Mar 1, 2026
…igUncle Verified: - pnpm build - pnpm check - pnpm vitest run --config vitest.extensions.config.ts extensions/feishu/src/config-schema.test.ts extensions/feishu/src/reply-dispatcher.test.ts extensions/feishu/src/bot.test.ts Co-authored-by: BigUncle <[email protected]> Co-authored-by: Tak Hoffman <[email protected]> (cherry picked from commit 27882dc) # Conflicts: # CHANGELOG.md # extensions/feishu/src/bot.ts # extensions/feishu/src/config-schema.ts
ansh
pushed a commit
to vibecode/openclaw
that referenced
this pull request
Mar 2, 2026
…igUncle Verified: - pnpm build - pnpm check - pnpm vitest run --config vitest.extensions.config.ts extensions/feishu/src/config-schema.test.ts extensions/feishu/src/reply-dispatcher.test.ts extensions/feishu/src/bot.test.ts Co-authored-by: BigUncle <[email protected]> Co-authored-by: Tak Hoffman <[email protected]>
steipete
pushed a commit
to Sid-Qin/openclaw
that referenced
this pull request
Mar 2, 2026
…igUncle Verified: - pnpm build - pnpm check - pnpm vitest run --config vitest.extensions.config.ts extensions/feishu/src/config-schema.test.ts extensions/feishu/src/reply-dispatcher.test.ts extensions/feishu/src/bot.test.ts Co-authored-by: BigUncle <[email protected]> Co-authored-by: Tak Hoffman <[email protected]>
safzanpirani
pushed a commit
to safzanpirani/clawdbot
that referenced
this pull request
Mar 2, 2026
…igUncle Verified: - pnpm build - pnpm check - pnpm vitest run --config vitest.extensions.config.ts extensions/feishu/src/config-schema.test.ts extensions/feishu/src/reply-dispatcher.test.ts extensions/feishu/src/bot.test.ts Co-authored-by: BigUncle <[email protected]> Co-authored-by: Tak Hoffman <[email protected]>
steipete
pushed a commit
to Sid-Qin/openclaw
that referenced
this pull request
Mar 2, 2026
…igUncle Verified: - pnpm build - pnpm check - pnpm vitest run --config vitest.extensions.config.ts extensions/feishu/src/config-schema.test.ts extensions/feishu/src/reply-dispatcher.test.ts extensions/feishu/src/bot.test.ts Co-authored-by: BigUncle <[email protected]> Co-authored-by: Tak Hoffman <[email protected]>
venjiang
pushed a commit
to venjiang/openclaw
that referenced
this pull request
Mar 2, 2026
…igUncle Verified: - pnpm build - pnpm check - pnpm vitest run --config vitest.extensions.config.ts extensions/feishu/src/config-schema.test.ts extensions/feishu/src/reply-dispatcher.test.ts extensions/feishu/src/bot.test.ts Co-authored-by: BigUncle <[email protected]> Co-authored-by: Tak Hoffman <[email protected]>
robertchang-ga
pushed a commit
to robertchang-ga/openclaw
that referenced
this pull request
Mar 2, 2026
…igUncle Verified: - pnpm build - pnpm check - pnpm vitest run --config vitest.extensions.config.ts extensions/feishu/src/config-schema.test.ts extensions/feishu/src/reply-dispatcher.test.ts extensions/feishu/src/bot.test.ts Co-authored-by: BigUncle <[email protected]> Co-authored-by: Tak Hoffman <[email protected]>
execute008
pushed a commit
to execute008/openclaw
that referenced
this pull request
Mar 2, 2026
…igUncle Verified: - pnpm build - pnpm check - pnpm vitest run --config vitest.extensions.config.ts extensions/feishu/src/config-schema.test.ts extensions/feishu/src/reply-dispatcher.test.ts extensions/feishu/src/bot.test.ts Co-authored-by: BigUncle <[email protected]> Co-authored-by: Tak Hoffman <[email protected]>
hughdidit
pushed a commit
to hughdidit/DAISy-Agency
that referenced
this pull request
Mar 3, 2026
…igUncle Verified: - pnpm build - pnpm check - pnpm vitest run --config vitest.extensions.config.ts extensions/feishu/src/config-schema.test.ts extensions/feishu/src/reply-dispatcher.test.ts extensions/feishu/src/bot.test.ts Co-authored-by: BigUncle <[email protected]> Co-authored-by: Tak Hoffman <[email protected]> (cherry picked from commit 27882dc) # Conflicts: # CHANGELOG.md
dorgonman
pushed a commit
to kanohorizonia/openclaw
that referenced
this pull request
Mar 3, 2026
…igUncle Verified: - pnpm build - pnpm check - pnpm vitest run --config vitest.extensions.config.ts extensions/feishu/src/config-schema.test.ts extensions/feishu/src/reply-dispatcher.test.ts extensions/feishu/src/bot.test.ts Co-authored-by: BigUncle <[email protected]> Co-authored-by: Tak Hoffman <[email protected]>
sachinkundu
pushed a commit
to sachinkundu/openclaw
that referenced
this pull request
Mar 6, 2026
…igUncle Verified: - pnpm build - pnpm check - pnpm vitest run --config vitest.extensions.config.ts extensions/feishu/src/config-schema.test.ts extensions/feishu/src/reply-dispatcher.test.ts extensions/feishu/src/bot.test.ts Co-authored-by: BigUncle <[email protected]> Co-authored-by: Tak Hoffman <[email protected]>
zooqueen
pushed a commit
to hanzoai/bot
that referenced
this pull request
Mar 6, 2026
…igUncle Verified: - pnpm build - pnpm check - pnpm vitest run --config vitest.extensions.config.ts extensions/feishu/src/config-schema.test.ts extensions/feishu/src/reply-dispatcher.test.ts extensions/feishu/src/bot.test.ts Co-authored-by: BigUncle <[email protected]> Co-authored-by: Tak Hoffman <[email protected]>
Mateljan1
pushed a commit
to Mateljan1/openclaw
that referenced
this pull request
Mar 7, 2026
…igUncle Verified: - pnpm build - pnpm check - pnpm vitest run --config vitest.extensions.config.ts extensions/feishu/src/config-schema.test.ts extensions/feishu/src/reply-dispatcher.test.ts extensions/feishu/src/bot.test.ts Co-authored-by: BigUncle <[email protected]> Co-authored-by: Tak Hoffman <[email protected]>
alexey-pelykh
pushed a commit
to remoteclaw/remoteclaw
that referenced
this pull request
Mar 15, 2026
…igUncle Verified: - pnpm build - pnpm check - pnpm vitest run --config vitest.extensions.config.ts extensions/feishu/src/config-schema.test.ts extensions/feishu/src/reply-dispatcher.test.ts extensions/feishu/src/bot.test.ts Co-authored-by: BigUncle <[email protected]> Co-authored-by: Tak Hoffman <[email protected]> (cherry picked from commit 27882dc)
alexey-pelykh
added a commit
to remoteclaw/remoteclaw
that referenced
this pull request
Mar 15, 2026
…igUncle (#1471) Verified: - pnpm build - pnpm check - pnpm vitest run --config vitest.extensions.config.ts extensions/feishu/src/config-schema.test.ts extensions/feishu/src/reply-dispatcher.test.ts extensions/feishu/src/bot.test.ts (cherry picked from commit 27882dc) Co-authored-by: BigUncle <[email protected]> Co-authored-by: BigUncle <[email protected]> Co-authored-by: Tak Hoffman <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
Feishu free-tier API quota is tight; these opt-out flags let users reduce unnecessary
requests without changing defaults.
Changes
typingIndicatorandresolveSenderNamesto Feishu config schemaNotes
Greptile Overview
Greptile Summary
typingIndicator,resolveSenderNames) intended to reduce free-tier API quota usage.Confidence Score: 3/5
permissionErrorForAgentappears to have been moved under a conditional without a matching outer-scope declaration, breaking the later permission-notification path and likely failing build/typecheck.(3/5) Reply to the agent's comments like "Can you suggest a fix for this @greptileai?" or ask follow-up questions!