Skip to content

fix(ui): localize remaining Control UI copy#105008

Merged
vincentkoc merged 9 commits into
mainfrom
fix/control-ui-i18n-complete-20260712
Jul 12, 2026
Merged

fix(ui): localize remaining Control UI copy#105008
vincentkoc merged 9 commits into
mainfrom
fix/control-ui-i18n-complete-20260712

Conversation

@vincentkoc

@vincentkoc vincentkoc commented Jul 12, 2026

Copy link
Copy Markdown
Member

Related: #52254

What Problem This Solves

Fixes an issue where users selecting a non-English Control UI locale would still encounter English-only labels, help text, tooltips, empty states, status copy, and screen-reader announcements across core workflows.

Why This Change Was Made

Routes the remaining user-facing Control UI copy through the canonical English source locale while preserving protocol values, product names, command syntax, and other intentional literals. The raw-copy baseline drops from 724 entries to 82 reviewed exceptions.

Generated foreign locale bundles remain owned by the post-merge control-ui-locale-refresh workflow and will follow in #104718 after this source PR lands.

User Impact

Control UI localization now covers settings and config forms, agents, tools, skills, memory, nodes, plugins and MCP, cron, chat, channels, sessions, usage, workboard, file previews, GitHub previews, and shared navigation controls. Locale changes also update dynamic previews, tool details, and slash-command accessibility announcements consistently.

Evidence

  • Focused Testbox validation: 204 chat view and tool-card tests passed.
  • Full Control UI suite: 225 files and 3,558 tests passed; the only expected source-phase failure was generated-locale parity pending the post-merge refresh.
  • Additional focused Testbox runs covered 56 initial UI tests, 22 cron tests, and 65 Plugins/MCP/chat tests.
  • Structured autoreview completed with no accepted or actionable findings after the review-driven accessibility fix.
  • git diff --check passes; the source PR contains no generated foreign-locale bundle changes.

@vincentkoc vincentkoc self-assigned this Jul 12, 2026
@openclaw-barnacle openclaw-barnacle Bot added app: web-ui App: web-ui size: XL maintainer Maintainer-authored PR labels Jul 12, 2026
@vincentkoc
vincentkoc marked this pull request as ready for review July 12, 2026 05:35
@vincentkoc

vincentkoc commented Jul 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

Land-ready at linear head 64a77aca5fe84600ce62161f7167042b60d28fc4.

Proof:

  • Blacksmith Testbox tbx_01kxaa8v7wzpy4p8qe4hnp6d4x
    • pnpm --dir ui test src/pages/chat/chat-view.test.ts src/pages/chat/components/chat-tool-cards.test.ts — 204 passed
    • pnpm --dir ui test src/components/mcp-app-view.test.ts — passed
    • pnpm --dir ui test src/pages/skill-workshop/proposals.test.ts src/pages/skill-workshop/skill-workshop-page.test.ts src/pages/skills/view.test.ts — 23 passed
    • pnpm exec oxlint ui/src/components/mcp-app-view.ts — 0 warnings, 0 errors
    • Full Control UI suite — 225 files / 3,558 tests passed; generated-locale parity is intentionally deferred to the post-merge refresh
  • Additional focused Testbox runs: 56 initial UI tests, 22 cron tests, and 65 Plugins/MCP/chat tests passed
  • Structured autoreview: no accepted or actionable findings after the accessibility, lifecycle, and current-main indexed-access overlap fixes
  • git diff --check passes; no generated foreign-locale bundles are included
  • OPENCLAW_TESTBOX=1 scripts/pr prepare-run 105008 passed in hosted_exact_or_recent_rebase mode
  • The PR is a nine-commit linear stack on current main; GitHub rebase merge preserves every commit without squashing

Known follow-up: the post-merge locale workflow will refresh #104718, which must land before closing #52254.

@clawsweeper clawsweeper Bot mentioned this pull request Jul 12, 2026
Closed
@clawsweeper

clawsweeper Bot commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

Codex review: stale review; fresh review needed.

Summary
The latest durable ClawSweeper review was for head 8331f59ccc6d038d8ca701da186f96ee164f4d60, but the PR head is now e7dc6527db9d1fb8acf771a07a88f913b61f1cd5. Its old verdict and PR readiness labels are no longer current.

Next step
Run or wait for a fresh ClawSweeper review on the current PR head.

@vincentkoc
vincentkoc force-pushed the fix/control-ui-i18n-complete-20260712 branch from e7dc652 to 64a77ac Compare July 12, 2026 05:43
@vincentkoc
vincentkoc merged commit 9b5fbee into main Jul 12, 2026
73 of 76 checks passed
@vincentkoc
vincentkoc deleted the fix/control-ui-i18n-complete-20260712 branch July 12, 2026 05:45
@vincentkoc

vincentkoc commented Jul 12, 2026

Copy link
Copy Markdown
Member Author

Merged via rebase.

@steipete steipete mentioned this pull request Jul 12, 2026
Closed
This was referenced Jul 12, 2026
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Jul 12, 2026
Closed
Closed
Closed
Closed
Closed
This was referenced Jul 12, 2026
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@vincentkoc vincentkoc

Labels

app: web-ui App: web-ui maintainer Maintainer-authored PR size: XL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@vincentkoc