refactor(scripts): extract legacy-store path domain#104894
Merged
Merged
Conversation
openclaw-barnacle
Bot
added
scripts
vincentkoc
marked this pull request as ready for review
July 12, 2026 02:19
Member
Author
|
Merged via squash.
|
github-actions Bot
pushed a commit
to Desicool/openclaw
that referenced
this pull request
Jul 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #104871
What Problem This Solves
The database-first legacy-store analyzer mixed TypeScript traversal with a dense set of value-domain merge rules. That made branch semantics difficult to audit and increased the cost of changing the analyzer safely.
Why This Change Was Made
This extracts the pure literal, object-property, sentinel, and branch-assignment merge domain into one private script helper. The analyzer keeps the same inputs, outputs, CLI behavior, allowlists, and detection rules.
User Impact
No user-visible behavior or public contract changes. Config, SDK, protocol, generated files, CLI options, and runtime storage behavior are unchanged. Maintainers and coding agents get a smaller analyzer core with one test-covered location for branch-value semantics.
Evidence
corepack pnpm test:serial test/scripts/check-database-first-legacy-stores.test.ts: 469 tests passed on Blacksmith Testboxtbx_01kx9zzm3ethj75acmxgj7fa4b.corepack pnpm check:changed: passed on the same Testbox..agents/skills/autoreview/scripts/autoreview --mode uncommitted --base origin/main: clean at 0.99 confidence.oxfmt --check,node --check, andgit diff --check: passed.