Android: polish workspace file navigation by IWhatsskill · Pull Request #104873 · openclaw/openclaw

IWhatsskill · 2026-07-12T01:46:07Z

[AI-assisted]

What Problem This Solves

Workspace browsing loses context inside nested folders: the header only shows the leaf folder name, and users cannot refresh a listing without navigating away and back.

Why This Change Was Made

The Android Files screen now shows the relative workspace path below the folder title and adds a refresh action that reuses the existing listing request and loading state. Refresh and pagination share one in-flight guard, so they cannot launch concurrently or publish directory results out of order. Error handling, previews, sharing, Gateway APIs, and transport behavior remain unchanged. The native i18n inventory is synchronized for the accessibility label.

User Impact

Nested workspace navigation is easier to understand at a glance, changed files can be refreshed in place with one tap, and refresh cannot race pagination into stale, duplicated, or skipped rows.

Evidence

Focused Android validation passed after the review repair and current-main merge:

WorkspaceFilesTest, including request-in-flight regression coverage
pnpm native:i18n:check
pnpm android:i18n:check
git diff --check

The visible behavior was tested on a lane-a Android emulator against an isolated, paired OpenClaw Gateway. The online gate showed Gateway online, Nodes 1/1, Approvals 0, and no pending device or node requests. The concurrency repair does not change the demonstrated layout or interaction.

Before	After

After — navigate nested folders and refresh the current listing:

after-workspace-files-navigation-refresh-20260712-v1.mp4

clawsweeper · 2026-07-12T02:00:56Z

Codex review: needs maintainer review before merge. Reviewed July 11, 2026, 11:54 PM ET / July 12, 2026, 03:54 UTC.

Summary
The branch adds a relative workspace-path subtitle, in-place refresh action, shared refresh/pagination request guard, regression coverage, and synchronized native i18n metadata to the Android workspace Files screen.

PR surface: Other +54. Total +54 across 3 files.

Reproducibility: not applicable. This PR adds a small Android navigation affordance rather than repairing a defined broken behavior contract. The earlier branch race is source-reproducible from the first reviewed head and demonstrably repaired on the current head.

Review metrics: none identified.

Merge readiness
Overall: 🦞 diamond lobster
Proof: 🦀 challenger crab ✨ media proof bonus
Patch quality: 🦞 diamond lobster
Result: ready for maintainer review.

Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch.

Risk before merge

[P1] The exact-head Android build check was still running at final inspection; this is a routine merge gate rather than evidence of a patch defect.

Maintainer options:

Decide the mitigation before merge
Merge the focused screen-local improvement after the remaining exact-head build gate succeeds, retaining the common in-flight guard and the existing Gateway, navigation, preview, sharing, and pagination ownership.
Pause or close
Do not merge this PR until maintainers decide whether the risk is worth taking.

Next step before merge

No automated repair action remains; ordinary maintainer review and completion of the exact-head build gate are appropriate.

Security
Cleared: The patch changes Compose UI state, a pure helper test, and generated localization metadata without introducing a concrete security or supply-chain concern.

Review details

Best possible solution:

Merge the focused screen-local improvement after the remaining exact-head build gate succeeds, retaining the common in-flight guard and the existing Gateway, navigation, preview, sharing, and pagination ownership.

Do we have a high-confidence way to reproduce the issue?

Not applicable; this PR adds a small Android navigation affordance rather than repairing a defined broken behavior contract. The earlier branch race is source-reproducible from the first reviewed head and demonstrably repaired on the current head.

Is this the best way to solve the issue?

Yes. Extending the established screen and canonical listing request is the narrowest maintainable approach, and the common in-flight guard protects the refresh/pagination invariant without duplicating behavior.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning high; reviewed against 630a8c256e01.

Label changes

Label changes:

add rating: 🦞 diamond lobster: Overall readiness is 🦞 diamond lobster; proof is 🦀 challenger crab and patch quality is 🦞 diamond lobster.
remove rating: 🐚 platinum hermit: Current PR rating is rating: 🦞 diamond lobster, so this older rating label is no longer current.

Label justifications:

P3: This is bounded Android navigation and refresh polish with limited blast radius and no remaining correctness blocker.
rating: 🦞 diamond lobster: Overall readiness is 🦞 diamond lobster; proof is 🦀 challenger crab and patch quality is 🦞 diamond lobster.
status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR. Sufficient (screenshot): Valid before/after Android emulator screenshots directly show the relative path and refresh affordance, with a paired-Gateway recording supplying supplemental interaction proof.
proof: sufficient: Contributor real behavior proof is sufficient. Valid before/after Android emulator screenshots directly show the relative path and refresh affordance, with a paired-Gateway recording supplying supplemental interaction proof.
proof: 📸 screenshot: Contributor real behavior proof includes screenshot evidence. Valid before/after Android emulator screenshots directly show the relative path and refresh affordance, with a paired-Gateway recording supplying supplemental interaction proof.

Evidence reviewed

PR surface:

Other +54. Total +54 across 3 files.

View PR surface stats

Area	Files	Added	Removed	Net
Source	0	0	0	0
Tests	0	0	0	0
Docs	0	0	0	0
Config	0	0	0	0
Generated	0	0	0	0
Other	3	72	18	+54
Total	3	72	18	+54

What I checked:

Exact-head request serialization: Refresh and pagination derive availability from the same loading-or-loadingMore guard; refresh marks loading before relaunching the canonical listing effect, and both request paths clear their state in finally blocks. (apps/android/app/src/main/java/ai/openclaw/app/ui/WorkspaceFilesScreen.kt:118, a64a369ac68f)
Prior finding repaired: Commit c1e0666 replaced the separate pagination-only gate with the common request guard and added focused regression coverage; later commits are main merges and do not alter the reviewed implementation. (apps/android/app/src/test/java/ai/openclaw/app/WorkspaceFilesTest.kt:10, c1e066680e3b)
Existing owner boundary retained: The implementation reuses the established WorkspaceFilesScreen and MainViewModel/NodeRuntime listing wrapper rather than adding another Gateway, navigation, storage, or transport path. (apps/android/app/src/main/java/ai/openclaw/app/MainViewModel.kt:1051, 630a8c256e01)
Direct real-behavior proof: The downloaded before/after emulator screenshots visibly show the new relative path and refresh action, and the linked MP4 supplies supplemental navigation-and-refresh interaction evidence against a paired Gateway. (a64a369ac68f)
Feature provenance: The related merged PR introduced the Android workspace Files screen, listing wrappers, navigation reset, previews, sharing, pagination, and parser tests extended by this patch. (apps/android/app/src/main/java/ai/openclaw/app/ui/WorkspaceFilesScreen.kt:73, 61a29a78364a)
Exact-head checks and clean checkout: The reviewed head remains unchanged; all completed relevant Android tests, lint, localization, security, and proof checks are successful, while android-build-play remains in progress. The target checkout remains clean. (a64a369ac68f)

Likely related people:

steipete: Introduced and merged the Android workspace Files feature and has the clearest merged history for its screen, listing contract, navigation state, and tests. (role: feature introducer, merger, and recent area contributor; confidence: high; commits: 4188f9991a3a, b034b986a8df, 61a29a78364a; files: apps/android/app/src/main/java/ai/openclaw/app/ui/WorkspaceFilesScreen.kt, apps/android/app/src/main/java/ai/openclaw/app/WorkspaceFiles.kt, apps/android/app/src/main/java/ai/openclaw/app/MainViewModel.kt)

What the crustacean ranks mean

🦀 challenger crab: rare, exceptional readiness with strong proof, clean implementation, and convincing validation.
🦞 diamond lobster: very strong readiness with only minor maintainer review expected.
🐚 platinum hermit: good normal PR, likely mergeable with ordinary maintainer review.
🦐 gold shrimp: useful signal, but proof or patch confidence is still limited.
🦪 silver shellfish: thin signal; proof, validation, or implementation needs work.
🧂 unranked krab: not merge-ready because proof is missing/unusable or there are serious correctness or safety concerns.
🌊 off-meta tidepool: rating does not apply to this item.

Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

How this review workflow works

ClawSweeper keeps one durable marker-backed review comment per issue or PR.
Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
Maintainers can also comment @clawsweeper review to request a fresh review only.
Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

Review history (2 earlier review cycles)

reviewed 2026-07-12T01:59:18.061Z sha 47ca668 :: needs changes before merge. :: [P2] Prevent refresh from racing pagination
reviewed 2026-07-12T02:58:30.930Z sha ee07e01 :: needs maintainer review before merge. :: none

…ce-files-navigation

IWhatsskill · 2026-07-12T02:49:53Z

@clawsweeper re-review

clawsweeper · 2026-07-12T02:49:56Z

🦞🧹
ClawSweeper re-review requested.

I asked ClawSweeper to review this item again.
Action: item re-review queued (workflow sweep.yml, event repository_dispatch).
Result: the existing ClawSweeper review comment will be edited in place when the review finishes.

Re-review progress:

State: Complete
Detail: The targeted re-review published an exact durable review comment and queued an executing target-wide serialized router scan.
Run: https://github.com/openclaw/clawsweeper/actions/runs/29177419337
Updated: 2026-07-12T03:00:14.139Z

* fix(android): polish workspace file navigation * fix(android): serialize workspace file requests --------- Co-authored-by: IWhatsskill <[email protected]> Co-authored-by: Colin Johnson <[email protected]>

fix(android): polish workspace file navigation

47ca668

openclaw-barnacle Bot added app: android App: android size: S labels Jul 12, 2026

IWhatsskill marked this pull request as ready for review July 12, 2026 01:46

IWhatsskill added 3 commits July 12, 2026 04:11

Merge remote-tracking branch 'origin/main' into codex/android-workspa…

870d984

…ce-files-navigation

fix(android): serialize workspace file requests

c1e0666

Merge remote-tracking branch 'origin/main' into codex/android-workspa…

ee07e01

…ce-files-navigation

Merge branch 'main' into codex/android-workspace-files-navigation

a64a369

clawsweeper Bot added rating: 🦞 diamond lobster Very strong PR readiness with only minor maintainer review expected. and removed rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. labels Jul 12, 2026

Solvely-Colin merged commit 86b10ff into openclaw:main Jul 12, 2026
91 of 93 checks passed

github-actions Bot mentioned this pull request Jul 12, 2026

📡 Upstream Digest — 2026-07-12 05:23 UTC curtismercier/openclaw-mods#1268

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Android: polish workspace file navigation#104873

Android: polish workspace file navigation#104873
Solvely-Colin merged 5 commits into
openclaw:mainfrom
IWhatsskill:codex/android-workspace-files-navigation

IWhatsskill commented Jul 12, 2026 •

edited

Loading

Uh oh!

clawsweeper Bot commented Jul 12, 2026 •

edited

Loading

Uh oh!

IWhatsskill commented Jul 12, 2026

Uh oh!

clawsweeper Bot commented Jul 12, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

IWhatsskill commented Jul 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Problem This Solves

Why This Change Was Made

User Impact

Evidence

Uh oh!

clawsweeper Bot commented Jul 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

IWhatsskill commented Jul 12, 2026

Uh oh!

clawsweeper Bot commented Jul 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

IWhatsskill commented Jul 12, 2026 •

edited

Loading

clawsweeper Bot commented Jul 12, 2026 •

edited

Loading

clawsweeper Bot commented Jul 12, 2026 •

edited

Loading