fix(agents): surface utility-model narration failures and show the utility model in models status#104770
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5146a2d550
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const { provider, modelId, profileId } = prepared.selection; | ||
| utilityModelLabel = `${provider}/${modelId}${profileId ? ` via ${profileId}` : ""}`; |
There was a problem hiding this comment.
Use resolved auth profile in narration warning
When the utility credential is selected by auth order/last-good rather than an explicit @profile suffix, prepared.selection.profileId is unset even though prepared.auth.profileId names the profile actually used. In that common case (for example the revoked openai:api-key profile described by the fix), the new warn omits the profile operators need to repair, so the default-level signal still does not identify the bad credential.
Useful? React with 👍 / 👎.
| const utilitySetting = readUtilityModelSetting(cfg, workspaceAgentId); | ||
| const utilityModelRef = resolveUtilityModelRefForAgent({ cfg, agentId: workspaceAgentId }); |
There was a problem hiding this comment.
Include utility model in auth status checks
This computes and reports utilityModelRef, but the auth/check/probe inputs below are still built only from default, fallback, image, and allowed models. With a primary like anthropic/... and a utility model like openai/..., models status --check will not put OpenAI in missingProvidersInUse and --probe will not target the utility model, so the dead utility credential this output is meant to expose remains outside the diagnostic path.
Useful? React with 👍 / 👎.
|
Codex review: needs real behavior proof before merge. Reviewed July 11, 2026, 8:05 PM ET / July 12, 2026, 00:05 UTC. Summary PR surface: Source +90, Tests +141. Total +231 across 4 files. Reproducibility: yes. Current-head source deterministically demonstrates the preparation-disable path, external-profile mismatch, and profile-suffix loss without requiring a speculative runtime state. Review metrics: none identified. Root-cause cluster Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Proof guidance:
Risk before merge
Maintainer options:
Next step before merge
Security Review findings
Review detailsBest possible solution: Use one canonical utility selection containing provider, model, auth profile, and preparation failure context for runtime warnings, status route analysis, and probes, while keeping the separate transport repair outside this PR. Do we have a high-confidence way to reproduce the issue? Yes. Current-head source deterministically demonstrates the preparation-disable path, external-profile mismatch, and profile-suffix loss without requiring a speculative runtime state. Is this the best way to solve the issue? No. The operator-visibility direction is appropriate, but the current implementation does not yet cover all credential-selection and silent-disable paths central to the report. Full review comments:
Overall correctness: patch is incorrect AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 7027d2c22728. Label changesLabel justifications:
Evidence reviewedPR surface: Source +90, Tests +141. Total +231 across 4 files. View PR surface stats
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
Review history (3 earlier review cycles)
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 00c4dcb145
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| narratorLog.warn( | ||
| `narration disabled after ${consecutiveFailures} consecutive failures` + | ||
| (utilityModelLabel ? ` (${utilityModelLabel})` : "") + | ||
| (lastFailure ? `: ${lastFailure}` : ""), | ||
| ); |
There was a problem hiding this comment.
Warn when preparation disables narration
When the utility model cannot be prepared at all (for example missing auth, an unknown configured utility model, or provider auth setup failure), prepareNarrationModel returns null and the default generator sets disabled = true before a second failure can occur, so this newly added warning never runs. In that failure mode narration still silently falls back to raw tool lines even though the verbose-only preparation error has the exact model/auth detail operators need.
Useful? React with 👍 / 👎.
…ility model in models status Narration failures were verbose-only, so a dead utility-model credential silently degraded channel progress drafts back to raw tool lines. The narrator now warns once per turn when it disables after consecutive failures, naming the utility model + auth profile, and openclaw models status renders the resolved utility model (config / provider default / disabled) in human and JSON output. Formatting verified remotely via Testbox format:check (hook bypassed: no node_modules in this worktree). Fixes #104764
The utility ref was rendered but not registered as a provider use, so missing utility-provider auth kept --check green (Codex review P2). Utility completions ride the plain API path like image models. Formatting verified remotely via Testbox format:check.
…viders main's route analysis reports per-model issues; a same-provider utility ref duplicated route reports (CI: incompatible-routes test). Shared providers are already analyzed via their configured uses; utility-only providers still enter the analysis so they stay visible to status. Formatting verified remotely via Testbox format:check.
00c4dcb to
380c647
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 380c6470d8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| normalizedUtilityProvider && | ||
| !providerUseRefs.some((use) => use.provider === normalizedUtilityProvider) | ||
| ) { | ||
| addProviderUse(utilityModelRef, false); |
There was a problem hiding this comment.
Include utility OpenAI in external profile loading
When this adds an OpenAI utility model while the primary/fallback text models are non-OpenAI, the auth store has already been selected from textUsesOpenAI using only default/fallbacks, so it is loaded via ensureAuthProfileStoreWithoutExternalProfiles. Runtime utility calls go through prepareSimpleCompletionModelForAgent/getApiKeyForModel, which scopes external CLI discovery to the actual provider, so users with only a Codex/ChatGPT external OpenAI profile can get models status --check reporting missing utility auth even though narration/titles can authenticate.
Useful? React with 👍 / 👎.
Same-provider dedupe hid the documented incident class: an OAuth-healthy primary says nothing about the utility model's plain API route (Codex review round 3). The openai route-test fixture now pins utilityModel off so route tests stay focused on their configured models, and a dedicated test covers the OAuth-primary/api-key-utility scenario. Formatting verified remotely via Testbox format:check.
…s status Uses without codex fallback previously skipped per-model route resolution (image-auth scoping), so the utility ref never produced missing-auth route issues. Route scope is now explicit: text uses get evaluateModelAuth, image uses keep provider-wide availability. Formatting verified remotely via Testbox format:check.
…abels --probe candidates now include the utility ref so utility-only providers probe the actual configured model instead of an arbitrary catalog entry (Codex review round 4). Inline comment records that the status resolver never falls back to the primary, so 'provider default' labels are exact. Formatting verified remotely via Testbox format:check.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fb66ac71e8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // their own right: an OAuth-healthy primary does not prove the utility's | ||
| // plain API path, so the ref gets full route analysis without inheriting | ||
| // the primary's codex-runtime fallback. | ||
| addProviderUse(utilityModelRef, false, "text"); |
There was a problem hiding this comment.
Preserve utility auth-profile suffixes
When the utility ref is profile-qualified, for example openai/gpt-5.6@openai:revoked, this new status use strips the suffix via resolveStatusModelRef/resolveModelRefFromString before building providerUseRefs, so route/auth analysis can select some other healthy OpenAI profile or env key and report models status --check as OK. Runtime utility completions still pass the suffix as selection.profileId into getApiKeyForModel, which uses that profile directly, so the narrator can keep failing on the bad suffixed credential while the diagnostic added here misses it; carry the parsed profile through as a locked/preferred profile for this utility use.
Useful? React with 👍 / 👎.
…iagnostics utilityModel accepts aliases, so status now reports the resolved provider/model instead of the raw alias, and identical route issues from overlapping primary/utility refs collapse to one entry (Codex round 5). Formatting verified remotely via Testbox format:check.
|
Merged via squash.
|
…facts discoverModels-time normalization resolves bundled provider policy surfaces; since #104770 grew that artifact graph, loading it inside the vitest runner hangs the openai-completions preservation test past its 120s timeout (fails on plain main). Mock the surface module like model-selection.test.ts already does so the discovery test stays hermetic. (cherry picked from commit dbc176eda442be959b069e14ce6d3e93c083593e)
…facts discoverModels-time normalization resolves bundled provider policy surfaces; since #104770 grew that artifact graph, loading it inside the vitest runner hangs the openai-completions preservation test past its 120s timeout (fails on plain main). Mock the surface module like model-selection.test.ts already does so the discovery test stays hermetic. (cherry picked from commit dbc176eda442be959b069e14ce6d3e93c083593e)
…facts discoverModels-time normalization resolves bundled provider policy surfaces; since #104770 grew that artifact graph, loading it inside the vitest runner hangs the openai-completions preservation test past its 120s timeout (fails on plain main). Mock the surface module like model-selection.test.ts already does so the discovery test stays hermetic. (cherry picked from commit dbc176eda442be959b069e14ce6d3e93c083593e)
- android: capture createdAtMs on the pending exec-approval write at registration; canonical readback after a refresh that already replaced the visible rows was dropping the approval instead of surfacing the still-pending reconciliation message (#104913 merged without this) - android: generous CI timeout ceilings in GatewayExecApprovalRuntimeTest - agents: hermetic model-discovery test via the plugins/provider-runtime boundary (lazy plugin-runtime resolution hangs vitest workers since #104770) - cli: usage-cost settle-budget test asserts the budget bound on every call instead of pinning the poll count (fast hosts fit a second poll in 50ms) - protocol coverage: allowlist session.approval for ios/android (native review rides exec.approval push/nudge delivery) - docs map, native i18n inventory, plugin-sdk api baseline regenerated
- android: capture createdAtMs on the pending exec-approval write at registration; canonical readback after a refresh that already replaced the visible rows was dropping the approval instead of surfacing the still-pending reconciliation message (#104913 merged without this) - android: generous CI timeout ceilings in GatewayExecApprovalRuntimeTest - agents: hermetic model-discovery test via the plugins/provider-runtime boundary (lazy plugin-runtime resolution hangs vitest workers since #104770) - cli: usage-cost settle-budget test asserts the budget bound on every call instead of pinning the poll count (fast hosts fit a second poll in 50ms) - protocol coverage: allowlist session.approval for ios/android (native review rides exec.approval push/nudge delivery) - docs map, native i18n inventory, plugin-sdk api baseline regenerated
- android: capture createdAtMs on the pending exec-approval write at registration; canonical readback after a refresh that already replaced the visible rows was dropping the approval instead of surfacing the still-pending reconciliation message (#104913 merged without this) - android: generous CI timeout ceilings in GatewayExecApprovalRuntimeTest - agents: hermetic model-discovery test via the plugins/provider-runtime boundary (lazy plugin-runtime resolution hangs vitest workers since #104770) - cli: usage-cost settle-budget test asserts the budget bound on every call instead of pinning the poll count (fast hosts fit a second poll in 50ms) - protocol coverage: allowlist session.approval for ios/android (native review rides exec.approval push/nudge delivery) - docs map, native i18n inventory, plugin-sdk api baseline regenerated
…ility model in models status (openclaw#104770) * fix(agents): surface utility-model narration failures and show the utility model in models status Narration failures were verbose-only, so a dead utility-model credential silently degraded channel progress drafts back to raw tool lines. The narrator now warns once per turn when it disables after consecutive failures, naming the utility model + auth profile, and openclaw models status renders the resolved utility model (config / provider default / disabled) in human and JSON output. Formatting verified remotely via Testbox format:check (hook bypassed: no node_modules in this worktree). Fixes openclaw#104764 * fix(models): include the utility model in models status auth analysis The utility ref was rendered but not registered as a provider use, so missing utility-provider auth kept --check green (Codex review P2). Utility completions ride the plain API path like image models. Formatting verified remotely via Testbox format:check. * fix(models): register the utility model only for otherwise-unused providers main's route analysis reports per-model issues; a same-provider utility ref duplicated route reports (CI: incompatible-routes test). Shared providers are already analyzed via their configured uses; utility-only providers still enter the analysis so they stay visible to status. Formatting verified remotely via Testbox format:check. * fix(models): always analyze the utility model route in models status Same-provider dedupe hid the documented incident class: an OAuth-healthy primary says nothing about the utility model's plain API route (Codex review round 3). The openai route-test fixture now pins utilityModel off so route tests stay focused on their configured models, and a dedicated test covers the OAuth-primary/api-key-utility scenario. Formatting verified remotely via Testbox format:check. * fix(models): give the utility model full text-route analysis in models status Uses without codex fallback previously skipped per-model route resolution (image-auth scoping), so the utility ref never produced missing-auth route issues. Route scope is now explicit: text uses get evaluateModelAuth, image uses keep provider-wide availability. Formatting verified remotely via Testbox format:check. * fix(models): probe the configured utility model and document source labels --probe candidates now include the utility ref so utility-only providers probe the actual configured model instead of an arbitrary catalog entry (Codex review round 4). Inline comment records that the status resolver never falls back to the primary, so 'provider default' labels are exact. Formatting verified remotely via Testbox format:check. * fix(models): canonicalize the reported utility ref and dedupe route diagnostics utilityModel accepts aliases, so status now reports the resolved provider/model instead of the raw alias, and identical route issues from overlapping primary/utility refs collapse to one entry (Codex round 5). Formatting verified remotely via Testbox format:check.
- android: capture createdAtMs on the pending exec-approval write at registration; canonical readback after a refresh that already replaced the visible rows was dropping the approval instead of surfacing the still-pending reconciliation message (#104913 merged without this) - android: generous CI timeout ceilings in GatewayExecApprovalRuntimeTest - agents: hermetic model-discovery test via the plugins/provider-runtime boundary (lazy plugin-runtime resolution hangs vitest workers since #104770) - cli: usage-cost settle-budget test asserts the budget bound on every call instead of pinning the poll count (fast hosts fit a second poll in 50ms) - protocol coverage: allowlist session.approval for ios/android (native review rides exec.approval push/nudge delivery) - docs map, native i18n inventory, plugin-sdk api baseline regenerated
- android: capture createdAtMs on the pending exec-approval write at registration; canonical readback after a refresh that already replaced the visible rows was dropping the approval instead of surfacing the still-pending reconciliation message (#104913 merged without this) - android: generous CI timeout ceilings in GatewayExecApprovalRuntimeTest - agents: hermetic model-discovery test via the plugins/provider-runtime boundary (lazy plugin-runtime resolution hangs vitest workers since #104770) - cli: usage-cost settle-budget test asserts the budget bound on every call instead of pinning the poll count (fast hosts fit a second poll in 50ms) - protocol coverage: allowlist session.approval for ios/android (native review rides exec.approval push/nudge delivery) - docs map, native i18n inventory, plugin-sdk api baseline regenerated
- android: capture createdAtMs on the pending exec-approval write at registration; canonical readback after a refresh that already replaced the visible rows was dropping the approval instead of surfacing the still-pending reconciliation message (#104913 merged without this) - android: generous CI timeout ceilings in GatewayExecApprovalRuntimeTest - agents: hermetic model-discovery test via the plugins/provider-runtime boundary (lazy plugin-runtime resolution hangs vitest workers since #104770) - cli: usage-cost settle-budget test asserts the budget bound on every call instead of pinning the poll count (fast hosts fit a second poll in 50ms) - protocol coverage: allowlist session.approval for ios/android (native review rides exec.approval push/nudge delivery) - docs map, native i18n inventory, plugin-sdk api baseline regenerated
- android: capture createdAtMs on the pending exec-approval write at registration; canonical readback after a refresh that already replaced the visible rows was dropping the approval instead of surfacing the still-pending reconciliation message (#104913 merged without this) - android: generous CI timeout ceilings in GatewayExecApprovalRuntimeTest - agents: hermetic model-discovery test via the plugins/provider-runtime boundary (lazy plugin-runtime resolution hangs vitest workers since #104770) - cli: usage-cost settle-budget test asserts the budget bound on every call instead of pinning the poll count (fast hosts fit a second poll in 50ms) - protocol coverage: allowlist session.approval for ios/android (native review rides exec.approval push/nudge delivery) - docs map, native i18n inventory, plugin-sdk api baseline regenerated
- android: capture createdAtMs on the pending exec-approval write at registration; canonical readback after a refresh that already replaced the visible rows was dropping the approval instead of surfacing the still-pending reconciliation message (#104913 merged without this) - android: generous CI timeout ceilings in GatewayExecApprovalRuntimeTest - agents: hermetic model-discovery test via the plugins/provider-runtime boundary (lazy plugin-runtime resolution hangs vitest workers since #104770) - cli: usage-cost settle-budget test asserts the budget bound on every call instead of pinning the poll count (fast hosts fit a second poll in 50ms) - protocol coverage: allowlist session.approval for ios/android (native review rides exec.approval push/nudge delivery) - docs map, native i18n inventory, plugin-sdk api baseline regenerated
… gates (#104837) * feat(gateway): propagate approvals to ancestor sessions with replay Squash-rebased #103921 segment onto the native-clients tip on current main. Session-scoped approval events publish sanitized pending/terminal transitions to opted-in session audiences, with authoritative pending replay on stream subscribe and durable-expiry reconciliation through the owning manager. SessionApprovalEvent/Replay wire types export from the approvals owner module; Swift models regenerated. (cherry picked from commit 2d1dcf9747044710111d0c730fc46ba6013a165c) (cherry picked from commit ccf88efd56b513d07599ffcee997bf0cddaf9adc) (cherry picked from commit 8eb33f59f00ec9ee4625259b76bd7ae60d2cd480) (cherry picked from commit c297cbc93c8401e9c79c20f242245a194f5dd236) (cherry picked from commit 93d68f28601ff37d863da4db009504993a22533a) (cherry picked from commit d285ccd8b2f212bb57e814107e7709c896e96b7d) (cherry picked from commit 5c536982231402b1b58d1683794ea9948b32d077) (cherry picked from commit 1646e5b6dc4dd20de54e10f110a5909be18d7d50) (cherry picked from commit 35cf1b705b247fb282f4d56ffe74bd2fb238221f) (cherry picked from commit 4f8ef36) (cherry picked from commit 74fbdcc99d5fff062d67760a51dba4ee9e84479b) (cherry picked from commit 222b285502681d2be14b1819798e9ee5555f431e) (cherry picked from commit b9e744951f676b600e7c5322bfd04b0e99797c07) (cherry picked from commit 9e904ef) (cherry picked from commit 678f238) (cherry picked from commit 72842e5) (cherry picked from commit be74c25) (cherry picked from commit 93ba8c4) (cherry picked from commit 8f23761) * feat(gateway): fail-closed plugin and tool approval gates Squash-rebased #103932 segment onto the ancestor-propagation tip on current main. Plugin node.invoke approvals claim a one-shot allow-once decision before handing execution authority to the policy, so observation or retry cannot replay a consumed approval; sibling tool gates bind approval ids to their originating reviewer identity. (cherry picked from commit 122df0d75281f572c012b6484ed5daf085d1d577) (cherry picked from commit f23d8ac240a8dcf2a42c4daaae962263975a0ae8) (cherry picked from commit 8632fb6436a224dac7a9a9ef0216884530de2c24) (cherry picked from commit d9fe2dd5c53665e5732f5f3da5ed1907a686ade8) (cherry picked from commit bb139f2c8aa36ddad70413e1ef79ff491a6f2ecd) (cherry picked from commit 9b3e056b68ea515c7d4baef269289b6670570480) (cherry picked from commit b11e66b59a7af1f3b08712de06864aed64d349e4) (cherry picked from commit a12916ee592d03dfa35e86a2aaede4476a5d4e5d) (cherry picked from commit d699de840fc8346892b9ae244fe3c3e8c4413032) (cherry picked from commit 9b7e5a9) (cherry picked from commit 4b507593f1b2f10b4496984c84a2803b853e5c5e) (cherry picked from commit 56408a186733c4eeb5aa76bd5907cde7b0cd3d5b) (cherry picked from commit a4051d6d8353d39d6fa0b5d69c36e06c3cd3e796) (cherry picked from commit 7682980) (cherry picked from commit a8b493f) (cherry picked from commit aceb990) (cherry picked from commit a29b0e7) (cherry picked from commit 2e3be08) (cherry picked from commit c9ae3d7) * fix: main-gate repairs for the durable-approvals stack - android: capture createdAtMs on the pending exec-approval write at registration; canonical readback after a refresh that already replaced the visible rows was dropping the approval instead of surfacing the still-pending reconciliation message (#104913 merged without this) - android: generous CI timeout ceilings in GatewayExecApprovalRuntimeTest - agents: hermetic model-discovery test via the plugins/provider-runtime boundary (lazy plugin-runtime resolution hangs vitest workers since #104770) - cli: usage-cost settle-budget test asserts the budget bound on every call instead of pinning the poll count (fast hosts fit a second poll in 50ms) - protocol coverage: allowlist session.approval for ios/android (native review rides exec.approval push/nudge delivery) - docs map, native i18n inventory, plugin-sdk api baseline regenerated
… gates (openclaw#104837) * feat(gateway): propagate approvals to ancestor sessions with replay Squash-rebased openclaw#103921 segment onto the native-clients tip on current main. Session-scoped approval events publish sanitized pending/terminal transitions to opted-in session audiences, with authoritative pending replay on stream subscribe and durable-expiry reconciliation through the owning manager. SessionApprovalEvent/Replay wire types export from the approvals owner module; Swift models regenerated. (cherry picked from commit 2d1dcf9747044710111d0c730fc46ba6013a165c) (cherry picked from commit ccf88efd56b513d07599ffcee997bf0cddaf9adc) (cherry picked from commit 8eb33f59f00ec9ee4625259b76bd7ae60d2cd480) (cherry picked from commit c297cbc93c8401e9c79c20f242245a194f5dd236) (cherry picked from commit 93d68f28601ff37d863da4db009504993a22533a) (cherry picked from commit d285ccd8b2f212bb57e814107e7709c896e96b7d) (cherry picked from commit 5c536982231402b1b58d1683794ea9948b32d077) (cherry picked from commit 1646e5b6dc4dd20de54e10f110a5909be18d7d50) (cherry picked from commit 35cf1b705b247fb282f4d56ffe74bd2fb238221f) (cherry picked from commit 4f8ef36) (cherry picked from commit 74fbdcc99d5fff062d67760a51dba4ee9e84479b) (cherry picked from commit 222b285502681d2be14b1819798e9ee5555f431e) (cherry picked from commit b9e744951f676b600e7c5322bfd04b0e99797c07) (cherry picked from commit 9e904ef) (cherry picked from commit 678f238) (cherry picked from commit 72842e5) (cherry picked from commit be74c25) (cherry picked from commit 93ba8c4) (cherry picked from commit 8f23761) * feat(gateway): fail-closed plugin and tool approval gates Squash-rebased openclaw#103932 segment onto the ancestor-propagation tip on current main. Plugin node.invoke approvals claim a one-shot allow-once decision before handing execution authority to the policy, so observation or retry cannot replay a consumed approval; sibling tool gates bind approval ids to their originating reviewer identity. (cherry picked from commit 122df0d75281f572c012b6484ed5daf085d1d577) (cherry picked from commit f23d8ac240a8dcf2a42c4daaae962263975a0ae8) (cherry picked from commit 8632fb6436a224dac7a9a9ef0216884530de2c24) (cherry picked from commit d9fe2dd5c53665e5732f5f3da5ed1907a686ade8) (cherry picked from commit bb139f2c8aa36ddad70413e1ef79ff491a6f2ecd) (cherry picked from commit 9b3e056b68ea515c7d4baef269289b6670570480) (cherry picked from commit b11e66b59a7af1f3b08712de06864aed64d349e4) (cherry picked from commit a12916ee592d03dfa35e86a2aaede4476a5d4e5d) (cherry picked from commit d699de840fc8346892b9ae244fe3c3e8c4413032) (cherry picked from commit 9b7e5a9) (cherry picked from commit 4b507593f1b2f10b4496984c84a2803b853e5c5e) (cherry picked from commit 56408a186733c4eeb5aa76bd5907cde7b0cd3d5b) (cherry picked from commit a4051d6d8353d39d6fa0b5d69c36e06c3cd3e796) (cherry picked from commit 7682980) (cherry picked from commit a8b493f) (cherry picked from commit aceb990) (cherry picked from commit a29b0e7) (cherry picked from commit 2e3be08) (cherry picked from commit c9ae3d7) * fix: main-gate repairs for the durable-approvals stack - android: capture createdAtMs on the pending exec-approval write at registration; canonical readback after a refresh that already replaced the visible rows was dropping the approval instead of surfacing the still-pending reconciliation message (openclaw#104913 merged without this) - android: generous CI timeout ceilings in GatewayExecApprovalRuntimeTest - agents: hermetic model-discovery test via the plugins/provider-runtime boundary (lazy plugin-runtime resolution hangs vitest workers since openclaw#104770) - cli: usage-cost settle-budget test asserts the budget bound on every call instead of pinning the poll count (fast hosts fit a second poll in 50ms) - protocol coverage: allowlist session.approval for ios/android (native review rides exec.approval push/nudge delivery) - docs map, native i18n inventory, plugin-sdk api baseline regenerated
What Problem This Solves
Utility-model narration (#103463, #103769) fails silently when its credential is dead. Observed live on the Molty gateway: the primary model rides Codex OAuth, but the derived utility model (
openai/gpt-5.6-luna) resolves theopenai:api-keyauth profile, which held a revoked key. Every narration call 401ed, the narrator disabled itself after 2 consecutive failures, and Discord kept showing the old raw tool lines — with zero operator-visible signal:logVerbose-only, and the log line did not name the agent, model, or auth profile;openclaw models statusnever mentioned the utility model, so nothing showed that narration depends on a different auth path than the primary.Fixes #104764.
Why This Change Was Made
A dead utility credential silently degrades the product experience (narrated progress drafts fall back to raw tool lines). The failure needs to be visible at default log levels and the utility model needs to be inspectable in
models status, which owns runtime auth visibility (--probe/--check).User Impact
narration disabled after 2 consecutive failures (openai/gpt-5.6-luna via openai:api-key): OpenAI API error (401): …— naming exactly what to repair.openclaw models statusshows aUtility modelline (explicit config / provider default / disabled) and autilityModel: { ref, source }field in--json.Evidence
progress-narrator: completion failed: OpenAI API error (401): 401 Incorrect API key provided: sk-proj-…repeated per turn while Discord rendered old-style tool lines; details in Utility-model narration fails silently on dead API-key profiles; models status hides the utility model #104764.tbx_01kx9pjsm0ct72rze4k3ks3zzh, run):pnpm format:checkgreen;pnpm test src/auto-reply/reply/progress-narrator.test.ts src/commands/models/list.status.test.ts→ 15 + 34 tests pass, including the new warn assertion and the newutilityModelJSON cases (explicit config and disabled).Follow-up tracked separately in #104764:
models status --proberoutesapi_key-profile probes through the codex app-server harness, which cannot validate an API key (needs the Codex-contract review gate).