Skip to content

fix(ci): make owner-approved Testbox landing reliable#104726

Merged
steipete merged 3 commits into
mainfrom
codex/fix-owner-testbox-gates
Jul 11, 2026
Merged

fix(ci): make owner-approved Testbox landing reliable#104726
steipete merged 3 commits into
mainfrom
codex/fix-owner-testbox-gates

Conversation

@steipete

Copy link
Copy Markdown
Contributor

What Problem This Solves

Owner-approved contributor landing through OPENCLAW_PR_GATES_REMOTE=testbox currently fails unrelated full-suite tests. The outer gate intentionally sets PNPM_CONFIG_VERIFY_DEPS_BEFORE_RUN=install, but nested gateway CPU scenarios inherit that value even though their build contract requires dependency re-verification to stay disabled. The Google local OAuth test also remained on the old two-argument token-exchange expectation after abort-signal forwarding was added.

Why This Change Was Made

  • Force nested gateway CPU build/QA commands to use PNPM_CONFIG_VERIFY_DEPS_BEFORE_RUN=false after the outer Testbox has hydrated dependencies.
  • Make both scenario tests inject the conflicting outer value so the regression is deterministic.
  • Prove Google local OAuth forwards its abort signal to token exchange.
  • State that an explicit owner/maintainer request to land named reviewed PRs is the required credentialed-Testbox approval and document the native remote-gate command.

User Impact

No product runtime behavior changes. Maintainers can land reviewed fork PRs through the native owner-approved Testbox path without a redundant authorization prompt or environment-dependent tooling failures.

Evidence

  • Blacksmith Testbox tbx_01kx9jqxzxc314etvn400cf9pj / Actions run 29169574508: 15 gateway CPU scenario tests and the Google OAuth local-login test passed with outer PNPM_CONFIG_VERIFY_DEPS_BEFORE_RUN=install.
  • pnpm exec oxfmt --check on the three code/test files.
  • Focused canonical oxlint on the three code/test files.
  • Fresh autoreview: no actionable findings, 0.90 confidence.
  • git diff --check.

@openclaw-barnacle openclaw-barnacle Bot added scripts Repository scripts extensions: google size: XS maintainer Maintainer-authored PR labels Jul 11, 2026
@steipete

Copy link
Copy Markdown
Contributor Author

Land-ready maintainer proof:

  • Exact head: 37b44047ae537a81a07dbebd9c2eeb60dd279dc2
  • Focused Blacksmith Testbox: tbx_01kx9jqxzxc314etvn400cf9pj (Actions run 29169574508); 15 gateway CPU scenario tests plus the Google OAuth local-login regression test passed under a hostile outer PNPM_CONFIG_VERIFY_DEPS_BEFORE_RUN=install.
  • Full exact-head CI: run 29169703336, all required jobs green.
  • Fresh autoreview: clean, confidence 0.90.
  • Repository-native prepare: OPENCLAW_TESTBOX=1 scripts/pr prepare-run 104726; hosted exact-head gates passed and the remote PR tree matched the prepared tree.

This fixes the owner landing path itself: an explicit owner/maintainer instruction to land reviewed PRs now counts as Testbox authorization, and nested gateway CPU checks no longer inherit the outer dependency-install policy.

@steipete
steipete merged commit 2a479bd into main Jul 11, 2026
130 of 134 checks passed
@steipete
steipete deleted the codex/fix-owner-testbox-gates branch July 11, 2026 22:04
@steipete

Copy link
Copy Markdown
Contributor Author

Merged via squash.

github-actions Bot pushed a commit to Desicool/openclaw that referenced this pull request Jul 12, 2026
* fix(ci): isolate nested pnpm verification

* test(google): verify OAuth abort signal forwarding

* docs: treat owner land requests as Testbox approval
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

extensions: google maintainer Maintainer-authored PR scripts Repository scripts size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant