fix(macos): remove duplicate sidebar toggle buttons in the Mac app dashboard#104694
Merged
Conversation
Contributor
Author
|
Merged via squash.
|
github-actions Bot
pushed a commit
to Desicool/openclaw
that referenced
this pull request
Jul 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
Fixes an issue where the macOS app dashboard showed two sidebar toggle buttons in every navigation state: the native titlebar toggle (next to the traffic lights) plus the Control UI's own controls — the collapse button in the sidebar brand row, the floating expand button while collapsed, and the drawer hamburger at narrow widths. The floating expand button also popped visible after using the titlebar toggle because collapse focus restoration force-revealed the "retired" control through its focus-visible escape hatch.
Why This Change Was Made
The Mac app already stamps
openclaw-native-navon the document root to advertise its titlebar toggle (DashboardWindowController.installNativeChromeScript), but the Control UI only soft-hid the floating expand button (opacity 0, focusable), and never hid the brand-row collapse button or the narrow-width hamburger. In the Mac app the titlebar button should be the only sidebar toggle; plain browsers and older app builds (which only stampopenclaw-native-macos) keep the web controls.User Impact
restoreFocusTofallback, also used by the resize-dismiss path).Evidence
ui/src/e2e/native-nav-sidebar-toggle.e2e.test.ts(4 tests) covers plain-browser vs native-nav at desktop and narrow widths, including drawer toggling through theopenclaw:native-toggle-sidebarevent and focus anchoring after collapse/close.tbx_01kx9csvwet4p9h7jbgpjfwnrt; final combinedpnpm check:changed+ focused e2e run green ontbx_01kx9dw3pfcx8nz14wnjq66815(exit 0, patch-identical content pre-rebase).