Skip to content

fix(macos): dashboard titlebar buttons sit too close together#104572

Merged
steipete merged 1 commit into
mainfrom
claude/button-padding-spacing-053c47
Jul 11, 2026
Merged

fix(macos): dashboard titlebar buttons sit too close together#104572
steipete merged 1 commit into
mainfrom
claude/button-padding-spacing-053c47

Conversation

@steipete

Copy link
Copy Markdown
Contributor

Related: #104380

What Problem This Solves

Fixes an issue where the macOS dashboard window's titlebar controls (sidebar toggle, back, forward) sit too close together next to the traffic lights, making them look cramped and easy to mis-click.

Why This Change Was Made

The titlebar accessory introduced in #104380 laid out the three buttons in an NSStackView with a 6pt gap. Doubling the gap to 12pt (Safari-like spacing) and widening the fixed accessory frame accordingly keeps the button sizes unchanged while giving each control breathing room.

User Impact

The sidebar toggle and back/forward buttons in the macOS app titlebar are visually separated and easier to hit; no behavior change.

Evidence

  • swift build of apps/macos succeeds on macOS (Darwin 25.5).
  • Geometry: accessory frame width goes 104 → 116 to absorb the two extra 6pt gaps (12 leading inset + 3 × ~27pt buttons + 2 × 12pt spacing), so button hit areas are unchanged.
  • No tests or web-UI CSS reference the accessory width; only the titlebar height CSS variable (unchanged) is shared with ui/.

@openclaw-barnacle openclaw-barnacle Bot added app: macos App: macos size: XS maintainer Maintainer-authored PR labels Jul 11, 2026
@clawsweeper clawsweeper Bot added rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. P3 Low-priority cleanup, docs, polish, ergonomics, or speculative work. labels Jul 11, 2026
@clawsweeper

clawsweeper Bot commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Codex review: needs real behavior proof before merge. Reviewed July 11, 2026, 1:10 PM ET / 17:10 UTC.

Summary
The PR increases spacing between the native macOS dashboard sidebar/back/forward titlebar buttons from 6pt to 12pt and widens their fixed accessory frame from 104pt to 116pt.

PR surface: Other +2. Total +2 across 1 file.

Reproducibility: not applicable. as a deterministic functional failure; current source establishes the original 6pt geometry, while whether it appears cramped is a visual UI judgment.

Review metrics: none identified.

Merge readiness
Overall: 🐚 platinum hermit
Proof: 🌊 off-meta tidepool
Patch quality: 🐚 platinum hermit
Result: ready for maintainer review.

Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch.

Rank-up moves:

  • none.

Next step before merge

  • [P1] No concrete repair is needed; the clean patch remains open for ordinary protected maintainer review and merge handling.

Security
Cleared: The patch only changes AppKit layout constants and a local explanatory comment, with no security or supply-chain impact.

Review details

Best possible solution:

Merge the localized spacing and frame adjustment after routine maintainer visual confirmation; retain the existing fitting-width smoke assertion to guard against clipped controls.

Do we have a high-confidence way to reproduce the issue?

Not applicable as a deterministic functional failure; current source establishes the original 6pt geometry, while whether it appears cramped is a visual UI judgment.

Is this the best way to solve the issue?

Yes. The PR changes the existing AppKit layout owner, preserves button behavior, widens the frame by exactly the added gap width, and retains the existing anti-clipping test.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning high; reviewed against a498fc511efa.

Label changes

Label changes:

  • add P3: This is a localized, low-risk native macOS appearance refinement with no behavioral, configuration, or compatibility change.
  • add rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🌊 off-meta tidepool and patch quality is 🐚 platinum hermit.
  • add status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR. Not applicable: The live maintainer label identifies this as a protected maintainer-authored review path where the external-contributor real-behavior proof gate does not apply.

Label justifications:

  • P3: This is a localized, low-risk native macOS appearance refinement with no behavioral, configuration, or compatibility change.
  • rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🌊 off-meta tidepool and patch quality is 🐚 platinum hermit.
  • status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR. Not applicable: The live maintainer label identifies this as a protected maintainer-authored review path where the external-contributor real-behavior proof gate does not apply.
Evidence reviewed

PR surface:

Other +2. Total +2 across 1 file.

View PR surface stats
Area Files Added Removed Net
Source 0 0 0 0
Tests 0 0 0 0
Docs 0 0 0 0
Config 0 0 0 0
Generated 0 0 0 0
Other 1 4 2 +2
Total 1 4 2 +2

What I checked:

Likely related people:

  • steipete: Peter Steinberger authored the merged titlebar-sidebar implementation and its tests, and therefore has direct history with the geometry this PR adjusts. (role: feature introducer and recent area contributor; confidence: high; commits: 9321c87c0349, df16372af3e1; files: apps/macos/Sources/OpenClaw/DashboardWindowController.swift, apps/macos/Tests/OpenClawIPCTests/DashboardWindowSmokeTests.swift)
What the crustacean ranks mean
  • 🦀 challenger crab: rare, exceptional readiness with strong proof, clean implementation, and convincing validation.
  • 🦞 diamond lobster: very strong readiness with only minor maintainer review expected.
  • 🐚 platinum hermit: good normal PR, likely mergeable with ordinary maintainer review.
  • 🦐 gold shrimp: useful signal, but proof or patch confidence is still limited.
  • 🦪 silver shellfish: thin signal; proof, validation, or implementation needs work.
  • 🧂 unranked krab: not merge-ready because proof is missing/unusable or there are serious correctness or safety concerns.
  • 🌊 off-meta tidepool: rating does not apply to this item.

Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

How this review workflow works
  • ClawSweeper keeps one durable marker-backed review comment per issue or PR.
  • Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
  • A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
  • PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
  • Maintainers can also comment @clawsweeper review to request a fresh review only.
  • Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
  • Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
  • Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

@steipete
steipete merged commit 60c6960 into main Jul 11, 2026
82 of 90 checks passed
@steipete
steipete deleted the claude/button-padding-spacing-053c47 branch July 11, 2026 17:12
@steipete

Copy link
Copy Markdown
Contributor Author

Merged via squash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app: macos App: macos maintainer Maintainer-authored PR P3 Low-priority cleanup, docs, polish, ergonomics, or speculative work. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. size: XS status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant