fix(macos): dashboard titlebar buttons sit too close together#104572
Conversation
|
Codex review: needs real behavior proof before merge. Reviewed July 11, 2026, 1:10 PM ET / 17:10 UTC. Summary PR surface: Other +2. Total +2 across 1 file. Reproducibility: not applicable. as a deterministic functional failure; current source establishes the original 6pt geometry, while whether it appears cramped is a visual UI judgment. Review metrics: none identified. Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Next step before merge
Security Review detailsBest possible solution: Merge the localized spacing and frame adjustment after routine maintainer visual confirmation; retain the existing fitting-width smoke assertion to guard against clipped controls. Do we have a high-confidence way to reproduce the issue? Not applicable as a deterministic functional failure; current source establishes the original 6pt geometry, while whether it appears cramped is a visual UI judgment. Is this the best way to solve the issue? Yes. The PR changes the existing AppKit layout owner, preserves button behavior, widens the frame by exactly the added gap width, and retains the existing anti-clipping test. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against a498fc511efa. Label changesLabel changes:
Label justifications:
Evidence reviewedPR surface: Other +2. Total +2 across 1 file. View PR surface stats
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
|
Merged via squash.
|
Related: #104380
What Problem This Solves
Fixes an issue where the macOS dashboard window's titlebar controls (sidebar toggle, back, forward) sit too close together next to the traffic lights, making them look cramped and easy to mis-click.
Why This Change Was Made
The titlebar accessory introduced in #104380 laid out the three buttons in an
NSStackViewwith a 6pt gap. Doubling the gap to 12pt (Safari-like spacing) and widening the fixed accessory frame accordingly keeps the button sizes unchanged while giving each control breathing room.User Impact
The sidebar toggle and back/forward buttons in the macOS app titlebar are visually separated and easier to hit; no behavior change.
Evidence
swift buildofapps/macossucceeds on macOS (Darwin 25.5).ui/.