fix: reuse built control UI for live Mac updates#104482
Conversation
|
Codex review: needs maintainer review before merge. Reviewed July 11, 2026, 9:30 AM ET / 13:30 UTC. Summary PR surface: Tests 0, Docs 0, Other +11. Total +11 across 3 files. Reproducibility: yes. from source with high confidence: after the exact-SHA build, Mac packaging independently runs JavaScript and Control UI builds unless both supported skip controls are forced. This read-only review did not execute the macOS workflow itself. Review metrics: none identified. Root-cause cluster Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Next step before merge
Security Review detailsBest possible solution: Keep one verified exact-SHA JavaScript and Control UI build, then sign and atomically swap the Mac bundle without allowing the packaging subprocess to rebuild or clean those artifacts. Do we have a high-confidence way to reproduce the issue? Yes, from source with high confidence: after the exact-SHA build, Mac packaging independently runs JavaScript and Control UI builds unless both supported skip controls are forced. This read-only review did not execute the macOS workflow itself. Is this the best way to solve the issue? Yes. Pinning the existing package controls at the specialized live-updater boundary removes redundant cleanup-capable builds without creating another artifact path or changing ordinary developer packaging behavior. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against fe261b0f59aa. Label changesLabel changes:
Label justifications:
Evidence reviewedPR surface: Tests 0, Docs 0, Other +11. Total +11 across 3 files. View PR surface stats
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
Review history (3 earlier review cycles) |
791cfee to
32c5aa3
Compare
This comment has been minimized.
This comment has been minimized.
|
Merged via squash.
|
* fix: reuse built control UI for live Mac updates * fix: pin live updater Mac build inputs
Summary
distappProof
node scripts/run-vitest.mjs test/scripts/openclaw-live-updater.test.ts(29 passed)git diff --checkRuntime recovery
The failed affected-app pass was recovered by rebuilding the Control UI once, packaging with both JavaScript build paths skipped, verifying the Developer ID bundle, and completing the exact-target swap.