Skip to content

fix: reuse built control UI for live Mac updates#104482

Merged
steipete merged 2 commits into
mainfrom
fix/live-updater-reuse-control-ui
Jul 11, 2026
Merged

fix: reuse built control UI for live Mac updates#104482
steipete merged 2 commits into
mainfrom
fix/live-updater-reuse-control-ui

Conversation

@steipete

Copy link
Copy Markdown
Contributor

Summary

  • reuse the exact-SHA JavaScript and Control UI artifacts during affected Mac app rebuilds
  • pin both packaging skip variables so ambient environment overrides cannot clean the live dist app
  • cover normal and pending-retry Mac update command paths

Proof

  • node scripts/run-vitest.mjs test/scripts/openclaw-live-updater.test.ts (29 passed)
  • git diff --check
  • skill frontmatter YAML parse
  • autoreview clean with no accepted/actionable findings

Runtime recovery

The failed affected-app pass was recovered by rebuilding the Control UI once, packaging with both JavaScript build paths skipped, verifying the Developer ID bundle, and completing the exact-target swap.

@openclaw-barnacle openclaw-barnacle Bot added size: XS maintainer Maintainer-authored PR labels Jul 11, 2026
@steipete steipete self-assigned this Jul 11, 2026
@clawsweeper clawsweeper Bot added rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. P2 Normal backlog priority with limited blast radius. labels Jul 11, 2026
@clawsweeper

clawsweeper Bot commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Codex review: needs maintainer review before merge. Reviewed July 11, 2026, 9:30 AM ET / 13:30 UTC.

Summary
The PR forces live Mac update packaging to reuse the already-built exact-SHA JavaScript and Control UI artifacts, documents that invariant, and updates normal and pending-retry command tests.

PR surface: Tests 0, Docs 0, Other +11. Total +11 across 3 files.

Reproducibility: yes. from source with high confidence: after the exact-SHA build, Mac packaging independently runs JavaScript and Control UI builds unless both supported skip controls are forced. This read-only review did not execute the macOS workflow itself.

Review metrics: none identified.

Root-cause cluster
Relationship: canonical
Canonical: #104482
Summary: This PR is the focused remaining correction for the later packaging cleanup step in the live Mac bundle-preservation failure family.

Members:

Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything.

Merge readiness
Overall: 🦞 diamond lobster
Proof: 🦞 diamond lobster
Patch quality: 🦞 diamond lobster
Result: ready for maintainer review.

Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch.

Next step before merge

  • No automated repair is needed; the protected, assigned PR should proceed through ordinary maintainer landing review.

Security
Cleared: The patch only pins existing local build controls and introduces no dependency, download, secret, permission, package-resolution, publishing, or third-party execution change.

Review details

Best possible solution:

Keep one verified exact-SHA JavaScript and Control UI build, then sign and atomically swap the Mac bundle without allowing the packaging subprocess to rebuild or clean those artifacts.

Do we have a high-confidence way to reproduce the issue?

Yes, from source with high confidence: after the exact-SHA build, Mac packaging independently runs JavaScript and Control UI builds unless both supported skip controls are forced. This read-only review did not execute the macOS workflow itself.

Is this the best way to solve the issue?

Yes. Pinning the existing package controls at the specialized live-updater boundary removes redundant cleanup-capable builds without creating another artifact path or changing ordinary developer packaging behavior.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning high; reviewed against fe261b0f59aa.

Label changes

Label changes:

  • add proof: sufficient: Contributor real behavior proof is sufficient. The PR body provides after-fix live recovery evidence covering the single Control UI build, both later build skips, Developer ID bundle verification, and exact-target swap.
  • add rating: 🦞 diamond lobster: Overall readiness is 🦞 diamond lobster; proof is 🦞 diamond lobster and patch quality is 🦞 diamond lobster.
  • remove rating: 🐚 platinum hermit: Current PR rating is rating: 🦞 diamond lobster, so this older rating label is no longer current.

Label justifications:

  • P2: This fixes a bounded but real reliability failure in internal live Mac update automation without evidence of broader user-runtime impact.
  • rating: 🦞 diamond lobster: Overall readiness is 🦞 diamond lobster; proof is 🦞 diamond lobster and patch quality is 🦞 diamond lobster.
  • status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR. Sufficient (live_output): The PR body provides after-fix live recovery evidence covering the single Control UI build, both later build skips, Developer ID bundle verification, and exact-target swap.
  • proof: sufficient: Contributor real behavior proof is sufficient. The PR body provides after-fix live recovery evidence covering the single Control UI build, both later build skips, Developer ID bundle verification, and exact-target swap.
Evidence reviewed

PR surface:

Tests 0, Docs 0, Other +11. Total +11 across 3 files.

View PR surface stats
Area Files Added Removed Net
Source 0 0 0 0
Tests 1 2 2 0
Docs 1 1 1 0
Config 0 0 0 0
Generated 0 0 0 0
Other 1 13 2 +11
Total 3 16 5 +11

What I checked:

  • Exact-head orchestration: After the canonical exact-SHA build, the PR changes only the Mac restart invocation to force both existing package skip controls while retaining target verification and Gateway health checks. (.agents/skills/openclaw-live-updater/scripts/update-main.mjs:858, 32c5aa3cb048)
  • Independent package builds: The Mac package script independently runs pnpm build unless SKIP_TSC=1 and builds Control UI unless SKIP_UI_BUILD=1, confirming that both controls are required for artifact reuse. (scripts/package-mac-app.sh:204, fe261b0f59aa)
  • Ambient override exposure: The restart script passes SKIP_TSC=${SKIP_TSC:-1}, so an ambient non-empty value other than 1 overrides its default, and it does not otherwise pin SKIP_UI_BUILD; the caller-level invocation closes both paths. (scripts/restart-mac.sh:324, fe261b0f59aa)
  • Normal and retry coverage: Exact-head tests assert the same pinned command for both the normal affected-Mac flow and the pending retry flow. (test/scripts/openclaw-live-updater.test.ts:407, 32c5aa3cb048)
  • Real recovery proof: The PR body reports an after-fix recovery that rebuilt Control UI once, packaged with both JavaScript paths skipped, verified the Developer ID bundle, and completed the exact-target swap. (32c5aa3cb048)
  • Exact-head checks: The current head has successful applicable Node, lint, dependency, and boundary checks; macOS Swift and UI jobs were path-skipped rather than failed. (32c5aa3cb048)

Likely related people:

  • steipete: Authored the merged live-updater introduction and subsequent staged Mac restart, Gateway isolation, and bundle-preservation changes defining the affected path. (role: feature owner and recent area contributor; confidence: high; commits: 2ace363e9866, 2ed24246182f, 107b95e1ad89; files: .agents/skills/openclaw-live-updater/SKILL.md, .agents/skills/openclaw-live-updater/scripts/update-main.mjs, scripts/restart-mac.sh)
What the crustacean ranks mean
  • 🦀 challenger crab: rare, exceptional readiness with strong proof, clean implementation, and convincing validation.
  • 🦞 diamond lobster: very strong readiness with only minor maintainer review expected.
  • 🐚 platinum hermit: good normal PR, likely mergeable with ordinary maintainer review.
  • 🦐 gold shrimp: useful signal, but proof or patch confidence is still limited.
  • 🦪 silver shellfish: thin signal; proof, validation, or implementation needs work.
  • 🧂 unranked krab: not merge-ready because proof is missing/unusable or there are serious correctness or safety concerns.
  • 🌊 off-meta tidepool: rating does not apply to this item.

Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

How this review workflow works
  • ClawSweeper keeps one durable marker-backed review comment per issue or PR.
  • Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
  • A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
  • PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
  • Maintainers can also comment @clawsweeper review to request a fresh review only.
  • Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
  • Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
  • Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.
Review history (3 earlier review cycles)
  • reviewed 2026-07-11T13:10:58.739Z sha 791cfee :: needs real behavior proof before merge. :: none
  • reviewed 2026-07-11T13:17:04.602Z sha 791cfee :: needs real behavior proof before merge. :: none
  • reviewed 2026-07-11T13:25:08.061Z sha 32c5aa3 :: needs real behavior proof before merge. :: none

@steipete
steipete force-pushed the fix/live-updater-reuse-control-ui branch from 791cfee to 32c5aa3 Compare July 11, 2026 13:18
@clawsweeper clawsweeper Bot added the proof: sufficient ClawSweeper judged the real behavior proof convincing. label Jul 11, 2026
@blacksmith-sh

This comment has been minimized.

@clawsweeper clawsweeper Bot added rating: 🦞 diamond lobster Very strong PR readiness with only minor maintainer review expected. and removed rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. labels Jul 11, 2026
@steipete
steipete merged commit 325679a into main Jul 11, 2026
144 of 149 checks passed
@steipete

Copy link
Copy Markdown
Contributor Author

Merged via squash.

@steipete
steipete deleted the fix/live-updater-reuse-control-ui branch July 11, 2026 13:36
github-actions Bot pushed a commit to Desicool/openclaw that referenced this pull request Jul 12, 2026
* fix: reuse built control UI for live Mac updates

* fix: pin live updater Mac build inputs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintainer Maintainer-authored PR P2 Normal backlog priority with limited blast radius. proof: sufficient ClawSweeper judged the real behavior proof convincing. rating: 🦞 diamond lobster Very strong PR readiness with only minor maintainer review expected. size: XS status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant