Skip to content

fix(ui): hide group submenu separator when New group is the only entry#104370

Merged
steipete merged 1 commit into
mainfrom
fix/session-menu-empty-group-separator
Jul 11, 2026
Merged

fix(ui): hide group submenu separator when New group is the only entry#104370
steipete merged 1 commit into
mainfrom
fix/session-menu-empty-group-separator

Conversation

@steipete

Copy link
Copy Markdown
Contributor

What Problem This Solves

When a session has no groups yet, the "Move to group" submenu renders a stray separator line above "New group…" — a divider with nothing above it (only entry in the submenu).

Why This Change Was Made

The separator before "New group…" in the session context menu's group submenu was rendered unconditionally. It only makes sense when there is content above it (existing groups or "Remove from group").

User Impact

The group submenu no longer shows a dangling separator when "New group…" is the only entry. No change when groups exist or the session is already grouped.

Evidence

  • ui/src/components/session-menu.ts: separator now renders only when groups.length > 0 || session.category.
  • Regression tests added in ui/src/components/session-menu.test.ts: separator absent with no groups/category, present when groups exist.
  • pnpm test ui/src/components/session-menu.test.ts: 17/17 passed.
  • oxfmt --check + scripts/run-oxlint.mjs clean on both files.

@openclaw-barnacle openclaw-barnacle Bot added app: web-ui App: web-ui size: XS maintainer Maintainer-authored PR labels Jul 11, 2026
@steipete
steipete merged commit aeab8e7 into main Jul 11, 2026
93 of 98 checks passed
@steipete
steipete deleted the fix/session-menu-empty-group-separator branch July 11, 2026 10:02
@steipete

Copy link
Copy Markdown
Contributor Author

Merged via squash.

vincentkoc added a commit that referenced this pull request Jul 11, 2026
* origin/main:
  fix(cron): abort superseded reconciliation hooks (#104368)
  ci(release): expose Telegram runtime preflight stage (#104387)
  fix(status): avoid false shell-wrapper audit warnings (#81778)
  fix: retry live Gateway readiness proof (#104374)
  fix(exec-approval): stop misattributing Allow Always unavailability to policy (#97740)
  fix: preserve Mac bundle during live builds (#104376)
  chore(docs): translate with GPT-5.6 xhigh
  test: wire Control UI suite into CI, fix its broken tests, drop dead harness surface (#104361)
  fix(ui): hide group submenu separator when New group is the only entry (#104370)
  fix(discord): reset progress drafts across queued turns (#102341)
  docs(cli): clarify that exec-policy show and approvals get exclude per-session /exec overrides (#94999)
  fix(discord): single-source thread-binding default placement and guard artifact parity (#104342)
  fix(agents): add tool-activity heartbeat to keep subagent alive during tool calls (#95536)
  fix(maint): reuse recent same-PR hosted gates (#104355)
github-actions Bot pushed a commit to Desicool/openclaw that referenced this pull request Jul 12, 2026
github-actions Bot pushed a commit to Desicool/openclaw that referenced this pull request Jul 12, 2026
* origin/main:
  fix(cron): abort superseded reconciliation hooks (openclaw#104368)
  ci(release): expose Telegram runtime preflight stage (openclaw#104387)
  fix(status): avoid false shell-wrapper audit warnings (openclaw#81778)
  fix: retry live Gateway readiness proof (openclaw#104374)
  fix(exec-approval): stop misattributing Allow Always unavailability to policy (openclaw#97740)
  fix: preserve Mac bundle during live builds (openclaw#104376)
  chore(docs): translate with GPT-5.6 xhigh
  test: wire Control UI suite into CI, fix its broken tests, drop dead harness surface (openclaw#104361)
  fix(ui): hide group submenu separator when New group is the only entry (openclaw#104370)
  fix(discord): reset progress drafts across queued turns (openclaw#102341)
  docs(cli): clarify that exec-policy show and approvals get exclude per-session /exec overrides (openclaw#94999)
  fix(discord): single-source thread-binding default placement and guard artifact parity (openclaw#104342)
  fix(agents): add tool-activity heartbeat to keep subagent alive during tool calls (openclaw#95536)
  fix(maint): reuse recent same-PR hosted gates (openclaw#104355)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app: web-ui App: web-ui maintainer Maintainer-authored PR size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant