Skip to content

chore(ui): remove dead .sidebar-new-session styles#104296

Merged
steipete merged 1 commit into
mainfrom
claude/remove-dead-sidebar-new-session-css
Jul 11, 2026
Merged

chore(ui): remove dead .sidebar-new-session styles#104296
steipete merged 1 commit into
mainfrom
claude/remove-dead-sidebar-new-session-css

Conversation

@steipete

Copy link
Copy Markdown
Contributor

What Problem This Solves

ui/src/styles/layout.css carried a 53-line .sidebar-new-session rule family (base, :hover:not(:disabled), :disabled, __icon, __icon svg) with no remaining users. Dead selectors in the shared layout stylesheet mislead future sidebar work and pad the bundle.

Why This Change Was Made

The last consumer was removed by the sessions-sidebar redesign (#103498), which switched the header button to the sidebar-session-new class; the old styles have been orphaned since. A repo-wide sweep (ui/, apps/, docs/, src/, all file types, plus a check for dynamically composed sidebar-${...} class names and e2e selectors) finds no references outside the CSS itself. Also drops one stray trailing blank line that made oxfmt --check fail on this file.

User Impact

None visible; slightly smaller stylesheet. Pure deletion (−54 lines), no selectors that render anywhere are affected.

Evidence

  • grep -rn "sidebar-new-session" ui apps docs src → 0 matches after the change (7 CSS-only matches before).
  • oxfmt --check ui/src/styles/layout.css passes after the change (failed before, due to the pre-existing trailing blank line).
  • git diff --check clean; diff is deletions-only.

@openclaw-barnacle openclaw-barnacle Bot added app: web-ui App: web-ui size: S maintainer Maintainer-authored PR labels Jul 11, 2026
@clawsweeper clawsweeper Bot added rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. P3 Low-priority cleanup, docs, polish, ergonomics, or speculative work. labels Jul 11, 2026
@clawsweeper

clawsweeper Bot commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Codex review: needs real behavior proof before merge. Reviewed July 11, 2026, 4:06 AM ET / 08:06 UTC.

Summary
The PR removes the unreferenced .sidebar-new-session selector family and an extra trailing blank line from ui/src/styles/layout.css.

PR surface: Source -54. Total -54 across 1 file.

Reproducibility: not applicable. This PR removes unreachable CSS rather than addressing a runtime defect with a failing reproduction path.

Review metrics: none identified.

Merge readiness
Overall: 🐚 platinum hermit
Proof: 🌊 off-meta tidepool
Patch quality: 🐚 platinum hermit
Result: ready for maintainer review.

Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch.

Rank-up moves:

  • none.

Next step before merge

  • [P1] The patch needs only ordinary protected-label maintainer review; there is no separate code defect for a repair worker.

Security
Cleared: The stylesheet-only deletion introduces no code execution, dependency, permission, secret-handling, or supply-chain concern.

Review details

Best possible solution:

Merge the deletion after ordinary protected-label review, retaining sidebar-session-new as the sole new-session styling path.

Do we have a high-confidence way to reproduce the issue?

Not applicable: this PR removes unreachable CSS rather than addressing a runtime defect with a failing reproduction path.

Is this the best way to solve the issue?

Yes. Repository-wide source inspection shows the selector family has no consumer, so direct deletion is the narrowest maintainable solution without adding another compatibility path.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning high; reviewed against f9ebefba29a0.

Label changes

Label changes:

  • add P3: This is a low-risk, deletion-only stylesheet cleanup with no intended user-visible behavior change.
  • add rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🌊 off-meta tidepool and patch quality is 🐚 platinum hermit.
  • add status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR. Not applicable: The protected maintainer cleanup changes no rendered behavior, so the external-contributor real-setup proof gate is not applicable.

Label justifications:

  • P3: This is a low-risk, deletion-only stylesheet cleanup with no intended user-visible behavior change.
  • rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🌊 off-meta tidepool and patch quality is 🐚 platinum hermit.
  • status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR. Not applicable: The protected maintainer cleanup changes no rendered behavior, so the external-contributor real-setup proof gate is not applicable.
Evidence reviewed

PR surface:

Source -54. Total -54 across 1 file.

View PR surface stats
Area Files Added Removed Net
Source 1 0 54 -54
Tests 0 0 0 0
Docs 0 0 0 0
Config 0 0 0 0
Generated 0 0 0 0
Other 0 0 0 0
Total 1 0 54 -54

What I checked:

  • Current-main usage: The old class appears only in its CSS definitions, while the live sidebar button uses the replacement sidebar-session-new class. (ui/src/styles/layout.css:944, f9ebefba29a0)
  • Active caller: The current sidebar renders the new-session button with sidebar-session-new, not any removed selector. (ui/src/components/app-sidebar.ts:1832, f9ebefba29a0)
  • Patch scope: The live PR diff deletes only the obsolete CSS rule family and the final extra blank line; it does not alter active markup or styles. (ui/src/styles/layout.css:944, cc73a8af9925)
  • Protected review state: The live PR carries the protected maintainer label, so ClawSweeper policy requires explicit maintainer handling and forbids automatic close cleanup. (cc73a8af9925)

Likely related people:

  • steipete: Peter Steinberger authored the merged sessions-sidebar redesign and recent work touching both the active sidebar component and shared layout stylesheet. (role: recent area contributor; confidence: high; commits: fd2a2411b96a, ae2c6117d3d3; files: ui/src/components/app-sidebar.ts, ui/src/styles/layout.css)
What the crustacean ranks mean
  • 🦀 challenger crab: rare, exceptional readiness with strong proof, clean implementation, and convincing validation.
  • 🦞 diamond lobster: very strong readiness with only minor maintainer review expected.
  • 🐚 platinum hermit: good normal PR, likely mergeable with ordinary maintainer review.
  • 🦐 gold shrimp: useful signal, but proof or patch confidence is still limited.
  • 🦪 silver shellfish: thin signal; proof, validation, or implementation needs work.
  • 🧂 unranked krab: not merge-ready because proof is missing/unusable or there are serious correctness or safety concerns.
  • 🌊 off-meta tidepool: rating does not apply to this item.

Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

How this review workflow works
  • ClawSweeper keeps one durable marker-backed review comment per issue or PR.
  • Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
  • A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
  • PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
  • Maintainers can also comment @clawsweeper review to request a fresh review only.
  • Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
  • Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
  • Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

@steipete
steipete merged commit e8cbc62 into main Jul 11, 2026
116 of 122 checks passed
@steipete
steipete deleted the claude/remove-dead-sidebar-new-session-css branch July 11, 2026 08:48
@steipete

Copy link
Copy Markdown
Contributor Author

Merged via squash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app: web-ui App: web-ui maintainer Maintainer-authored PR P3 Low-priority cleanup, docs, polish, ergonomics, or speculative work. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. size: S status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant