chore(ui): remove dead .sidebar-new-session styles#104296
Conversation
|
Codex review: needs real behavior proof before merge. Reviewed July 11, 2026, 4:06 AM ET / 08:06 UTC. Summary PR surface: Source -54. Total -54 across 1 file. Reproducibility: not applicable. This PR removes unreachable CSS rather than addressing a runtime defect with a failing reproduction path. Review metrics: none identified. Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Next step before merge
Security Review detailsBest possible solution: Merge the deletion after ordinary protected-label review, retaining Do we have a high-confidence way to reproduce the issue? Not applicable: this PR removes unreachable CSS rather than addressing a runtime defect with a failing reproduction path. Is this the best way to solve the issue? Yes. Repository-wide source inspection shows the selector family has no consumer, so direct deletion is the narrowest maintainable solution without adding another compatibility path. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against f9ebefba29a0. Label changesLabel changes:
Label justifications:
Evidence reviewedPR surface: Source -54. Total -54 across 1 file. View PR surface stats
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
|
Merged via squash.
|
What Problem This Solves
ui/src/styles/layout.csscarried a 53-line.sidebar-new-sessionrule family (base,:hover:not(:disabled),:disabled,__icon,__icon svg) with no remaining users. Dead selectors in the shared layout stylesheet mislead future sidebar work and pad the bundle.Why This Change Was Made
The last consumer was removed by the sessions-sidebar redesign (#103498), which switched the header button to the
sidebar-session-newclass; the old styles have been orphaned since. A repo-wide sweep (ui/,apps/,docs/,src/, all file types, plus a check for dynamically composedsidebar-${...}class names and e2e selectors) finds no references outside the CSS itself. Also drops one stray trailing blank line that madeoxfmt --checkfail on this file.User Impact
None visible; slightly smaller stylesheet. Pure deletion (−54 lines), no selectors that render anywhere are affected.
Evidence
grep -rn "sidebar-new-session" ui apps docs src→ 0 matches after the change (7 CSS-only matches before).oxfmt --check ui/src/styles/layout.csspasses after the change (failed before, due to the pre-existing trailing blank line).git diff --checkclean; diff is deletions-only.