fix(ui): preserve UTF-16 workshop previews#104047
Merged
Merged
Conversation
openclaw-barnacle
Bot
added
app: web-ui
Contributor
Author
|
Land-ready proof for exact head
The fix keeps the existing preview budget, word-boundary logic, and ellipsis presentation while replacing the sole unsafe raw cutoff with the established browser-safe primitive. |
Contributor
Author
|
Merged via squash.
|
github-actions Bot
pushed a commit
to Desicool/openclaw
that referenced
this pull request
Jul 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
Skill Workshop's Today preview truncates proposal list items at 120 UTF-16 code units. A raw
String.slicecan stop after an emoji's high surrogate, leaving malformed text in the rendered preview.Why This Change Was Made
Use the browser-compatible
truncateUtf16Safeprimitive already used across Control UI. Preserve the existing 120-unit budget, word-boundary behavior, and ellipsis presentation; only the unsafe cutoff changes.User Impact
Long Skill Workshop proposal previews no longer render a replacement character when their truncation boundary falls inside an emoji.
Evidence
tbx_01kx7a49qv2xqp9yt3dbrt1mmh: focused Skill Workshop UI tests passed 4/4.git diff --checkpassed.The path-scoped lane emitted only the unrelated warning-only temporary-directory migration report already present on current
main.