Update gog Calendar command date format to RFC3339#104
Merged
steipete merged 1 commit intoopenclaw:mainfrom Jan 3, 2026
Merged
Update gog Calendar command date format to RFC3339#104steipete merged 1 commit intoopenclaw:mainfrom
steipete merged 1 commit intoopenclaw:mainfrom
Conversation
I am seeing instances where Clawdis is not including timezone in the gog calendar range requests. This results in a 400 bad request from the Google API, e.g. ``` gog calendar events primary --from 2026-01-02T00:00:00 --to 2026-01-03T23:59:59 --account <email> Google API error (400 badRequest): Bad Request ``` While this is a valid ISO 8601 format, Google Calendar API requires a stricter RFC 3339 format like the following: ``` gog calendar events primary --from 2026-01-02T00:00:00Z --to 2026-01-03T23:59:59Z --account <email> <calendar events listed successfully> ```
Contributor
🦞 Codex ReviewFindings
Summary Review by Clawd 🦞 via Codex |
Contributor
|
thank you! |
slathrop
referenced
this pull request
in slathrop/openclaw-js
Feb 11, 2026
- Switch from process.on('warning') to process.emitWarning wrapping
- Add normalizeWarningArgs to handle all emitWarning call signatures
- Intercept warnings at source before they reach any listener
- Update tests to use real emitWarning calls
slathrop
referenced
this pull request
in slathrop/openclaw-js
Feb 11, 2026
Tasks completed: 2/2 - Task 1: Port commits #103 and #104 (warning filter centralization) - Task 2: Port commit #105 (project hygiene) SUMMARY: .planning/phases/13-paths-config-refactoring/13-05-SUMMARY.md
Milofax
added a commit
to Milofax/openclaw
that referenced
this pull request
Feb 12, 2026
…loses openclaw#104) Playwright's connectOverCDP() attaches to ALL open pages during initialization. If any page's renderer is stuck (e.g. TradingView with heavy JS), the entire connection hangs indefinitely. Add a pre-connection health check that probes each page via raw CDP Runtime.evaluate("1") and closes unresponsive pages before connectOverCDP() runs.
Milofax
added a commit
to Milofax/openclaw
that referenced
this pull request
Feb 12, 2026
…loses openclaw#104) (#1) Playwright's connectOverCDP() attaches to ALL open pages during initialization. If any page's renderer is stuck (e.g. TradingView with heavy JS), the entire connection hangs indefinitely. Add a pre-connection health check that probes each page via raw CDP Runtime.evaluate("1") and closes unresponsive pages before connectOverCDP() runs.
Milofax
added a commit
to Milofax/openclaw
that referenced
this pull request
Feb 12, 2026
* fix(browser): evict stuck browser pages before Playwright connection (Closes openclaw#104) Playwright's connectOverCDP() attaches to ALL open pages during initialization. If any page's renderer is stuck (e.g. TradingView with heavy JS), the entire connection hangs indefinitely. Add a pre-connection health check that probes each page via raw CDP Runtime.evaluate("1") and closes unresponsive pages before connectOverCDP() runs. * fix(browser): run stuck page eviction on cached connections too The eviction only ran during fresh connectOverCDP() calls. When a cached Playwright connection was reused, stuck pages (e.g. TradingView with blocked renderer) would cause page-level operations to hang instead. Now evictStuckPagesViaCdp() runs before returning the cached connection, closing any pages whose Runtime.evaluate("1") doesn't respond within 3s. Playwright auto-removes closed pages via Target.targetDestroyed events.
Milofax
added a commit
to Milofax/openclaw
that referenced
this pull request
Feb 18, 2026
…loses openclaw#104) (#1) Playwright's connectOverCDP() attaches to ALL open pages during initialization. If any page's renderer is stuck (e.g. TradingView with heavy JS), the entire connection hangs indefinitely. Add a pre-connection health check that probes each page via raw CDP Runtime.evaluate("1") and closes unresponsive pages before connectOverCDP() runs.
Milofax
added a commit
to Milofax/openclaw
that referenced
this pull request
Feb 18, 2026
* fix(browser): evict stuck browser pages before Playwright connection (Closes openclaw#104) Playwright's connectOverCDP() attaches to ALL open pages during initialization. If any page's renderer is stuck (e.g. TradingView with heavy JS), the entire connection hangs indefinitely. Add a pre-connection health check that probes each page via raw CDP Runtime.evaluate("1") and closes unresponsive pages before connectOverCDP() runs. * fix(browser): run stuck page eviction on cached connections too The eviction only ran during fresh connectOverCDP() calls. When a cached Playwright connection was reused, stuck pages (e.g. TradingView with blocked renderer) would cause page-level operations to hang instead. Now evictStuckPagesViaCdp() runs before returning the cached connection, closing any pages whose Runtime.evaluate("1") doesn't respond within 3s. Playwright auto-removes closed pages via Target.targetDestroyed events.
|
@claude please review this PR |
Contributor
|
This issue has been fixed in the upstream See: steipete/gogcli#409 The fix clarifies the help text for You can update |
heatherstew44-maker
pushed a commit
to heatherstew44-maker/openclaw
that referenced
this pull request
Mar 8, 2026
Piboonsak
added a commit
to Piboonsak/openclaw_github
that referenced
this pull request
Mar 9, 2026
- Add user-facing error messages with emoji indicators - Document that user is NOT notified when agent terminates (Issue openclaw#104) - Add hint to implement channel error forwarding for future enhancement This is a scoped-down fix focusing on logging clarity. Full channel notification requires async message send + context injection. Partially addresses: openclaw#104 Sprint: 1.6
CyberSpencer
added a commit
to CyberSpencer/openclaw
that referenced
this pull request
Mar 19, 2026
* fix(heartbeat): trim activeHours time values * ci(formal): warn instead of failing when extractor drift blocks regeneration
0x666c6f
added a commit
to 0x666c6f/openclaw
that referenced
this pull request
Mar 26, 2026
* fix(slack): default Slack queue to followup * fix: address PR review findings * fix: address CI failure from review fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am seeing instances where Clawdis is not including timezone in the gog calendar range requests. This results in a 400 bad request from the Google API, e.g.
While this is a valid ISO 8601 format, Google Calendar API requires a stricter RFC 3339 format with time zone information, like the following: