fix(docker): restore selected-plugin builds on Podman#103814
Merged
Conversation
Contributor
Author
|
Land-ready proof for
Before/after: current Known proof gaps: none. No user command or configuration changes; release-note metadata and @sallyom reporter credit are in the PR body, while repository policy leaves |
Contributor
Author
|
Merged via squash.
|
github-actions Bot
pushed a commit
to Desicool/openclaw
that referenced
this pull request
Jul 11, 2026
Fixes openclaw#103741. Reported and verified on amd64 Podman by @sallyom.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #103741
What Problem This Solves
Fixes an issue where operators building source images with selected plugins could hit
MODULE_NOT_FOUNDorEACCESin the earlyworkspace-depsstage on Podman/Buildah hosts.Reported and verified on the affected amd64 Podman host by @sallyom.
Why This Change Was Made
The stage now brings its selector, workspace packages, and bundled plugin sources in through portable
COPYinstructions. Builder-owned cache mounts elsewhere remain unchanged, and only extracted manifests plus the validated plugin selection cross into later stages, so the final runtime image contract stays the same.This keeps one Dockerfile path for Docker BuildKit and Podman instead of adding a Buildah-only bind relabel option.
User Impact
Podman users can build selected-plugin source images without build-context bind sources disappearing or becoming unreadable. Unknown, invalid, and ambiguous plugin selections still fail closed.
Evidence
COPYshape completedworkspace-depson the affected amd64 host.tbx_01kx6cj8s7qva0bbgkxnbm4ana(Actions run 29106270855):corepack pnpm test src/dockerfile.test.ts test/scripts/docker-plugin-selection.test.ts— 32 tests passed, including the new stage-scoped no-bind regression.--target workspace-deps --platform linux/amd64withOPENCLAW_EXTENSIONS=vault,codex; Podman rejectedmissing-pluginwith the expected fail-closed error.scripts/e2e/docker-selected-plugins.sh— unknown selection, dependency-only selections, full image build, and x64 runtime inspection passed.pnpm check:changedremote child — fail-safe all lanes passed, including project typechecks, core/extensions/scripts lint, guards, and import-cycle checks..agents/skills/autoreview/scripts/autoreview --mode local— clean; no accepted or actionable findings.AI-assisted: yes (Codex). The implementation and proof were reviewed before publication.