Skip to content

fix(google-meet): validate chrome node policy params#103752

Merged
steipete merged 4 commits into
openclaw:mainfrom
Leon-SK668:llagy007/google-meet-node-policy
Jul 11, 2026
Merged

fix(google-meet): validate chrome node policy params#103752
steipete merged 4 commits into
openclaw:mainfrom
Leon-SK668:llagy007/google-meet-node-policy

Conversation

@Leon-SK668

@Leon-SK668 Leon-SK668 commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

What Problem This Solves

Fixes an issue where caller-controlled googlemeet.chrome node requests could forward malformed bridge-control parameters to the node host, so invalid audio bridge or stop-by-url requests failed after dispatch instead of being rejected at the plugin policy boundary.

Why This Change Was Made

The dangerous Google Meet node command policy now validates the required fields for bridge-control actions before invoking the node host, and applies the same Meet URL normalization used by start/join flows to forwarded list and stopByUrl filters. Optional diagnostic actions such as status and stop keep their existing behavior.

User Impact

Google Meet chrome-node requests now get stable policy-denied errors for malformed bridge control and non-Meet URL filters before any node-side dispatch. Valid Meet URL filters keep query strings and still reach the node host in normalized form.

Evidence

  • OPENCLAW_HEAVY_CHECK_LOCK_SCOPE=worktree node scripts/run-vitest.mjs extensions/google-meet/src/node-invoke-policy.test.ts -- --reporter=verbose
  • pnpm format:check extensions/google-meet/src/node-invoke-policy.ts extensions/google-meet/src/node-invoke-policy.test.ts
  • OPENCLAW_HEAVY_CHECK_LOCK_SCOPE=worktree node scripts/run-oxlint.mjs --tsconfig config/tsconfig/oxlint.extensions.json extensions/google-meet/src/node-invoke-policy.ts extensions/google-meet/src/node-invoke-policy.test.ts
  • git diff --check upstream/main..HEAD
  • Controlled runtime proof, no live key: node --import tsx - <<'EOF' ... loaded the real Google Meet node invoke policy and dispatched approved calls into the real handleGoogleMeetNodeHostCommand handler.

Proof

  • Focused regression tests prove malformed pullAudio, pushAudio, clearAudio, and stopByUrl requests are denied before invokeNode is called.
  • Focused regression tests prove stopByUrl Meet URL filters are normalized and stripped of unrelated caller-controlled command fields before dispatch.
  • Controlled runtime proof loaded the actual policy plus actual node-host command handler. Malformed requests returned GOOGLE_MEET_NODE_POLICY_DENIED with dispatched: 0; valid stopByUrl and list Meet URL filters reached the real node-host handler and returned stable JSON.
  • Controlled proof output summary:
    • missing stopByUrl.url: dispatched=0, denied before node-host dispatch
    • non-Meet stopByUrl.url: dispatched=0, denied before node-host dispatch
    • missing pushAudio.base64: dispatched=0, denied before node-host dispatch
    • valid stopByUrl Meet URL filter: dispatched=1, node-host returned { ok: true, stopped: 0 }
    • valid list Meet URL filter: dispatched=1, node-host returned { bridges: [] }
    • total node-host dispatches: 2
  • The branch was refreshed onto latest upstream/main; final functional diff only touches extensions/google-meet/src/node-invoke-policy.ts and extensions/google-meet/src/node-invoke-policy.test.ts.
  • Closeout review: Codex autoreview was attempted but the local OpenAI key returned 401; Claude structured autoreview on the rebased branch reported no accepted/actionable findings.

@clawsweeper clawsweeper Bot added rating: 🦪 silver shellfish Thin PR readiness signal; proof, validation, or implementation needs work. status: 📣 needs proof The PR needs real behavior proof before ClawSweeper can clear the contributor ask. P2 Normal backlog priority with limited blast radius. labels Jul 10, 2026
@clawsweeper

clawsweeper Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Codex review: needs maintainer review before merge. Reviewed July 10, 2026, 9:26 PM ET / July 11, 2026, 01:26 UTC.

Summary
The PR validates required Google Meet Chrome-node bridge-control fields and normalizes forwarded Meet URL filters before invoking the node host.

PR surface: Source +33, Tests +42. Total +75 across 2 files.

Reproducibility: yes. Current main forwards incomplete bridge-control parameter objects to node-host handlers that require those fields, providing a high-confidence source reproduction without a live meeting.

Review metrics: none identified.

Merge readiness
Overall: 🦞 diamond lobster
Proof: 🦞 diamond lobster
Patch quality: 🦞 diamond lobster
Result: ready for maintainer review.

Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch.

Risk before merge

  • [P1] The live PR is behind current main and one exact-head OpenGrep check remains queued; the inspected Google Meet files show no intervening semantic changes, but normal merge gates should confirm the final head.

Maintainer options:

  1. Decide the mitigation before merge
    Land the plugin-owned validation and canonical URL normalization after the branch and exact-head required checks satisfy the repository’s normal merge gates.
  2. Pause or close
    Do not merge this PR until maintainers decide whether the risk is worth taking.

Next step before merge

  • No automated repair is needed; this PR is ready for ordinary maintainer merge handling once exact-head freshness and required checks are satisfied.

Security
Cleared: The patch reduces caller-controlled input reaching a dangerous node command and adds no dependency, workflow, permission, secret, or supply-chain surface.

Review details

Best possible solution:

Land the plugin-owned validation and canonical URL normalization after the branch and exact-head required checks satisfy the repository’s normal merge gates.

Do we have a high-confidence way to reproduce the issue?

Yes. Current main forwards incomplete bridge-control parameter objects to node-host handlers that require those fields, providing a high-confidence source reproduction without a live meeting.

Is this the best way to solve the issue?

Yes. Validating caller-controlled fields in the dangerous plugin invoke policy is the narrowest maintainable fix, and the proposed checks match both node-host requirements and established internal callers.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning high; reviewed against 790cd2aff2d4.

Label changes

Label justifications:

  • P2: This fixes a bounded late-validation defect in the Google Meet plugin without evidence of widespread outage, data loss, or message loss.
  • rating: 🦞 diamond lobster: Overall readiness is 🦞 diamond lobster; proof is 🦞 diamond lobster and patch quality is 🦞 diamond lobster.
  • status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR. Sufficient (live_output): Controlled after-fix output exercises the real policy and node-host handler, showing malformed calls denied before dispatch and valid URL-filter calls dispatched successfully.
  • proof: sufficient: Contributor real behavior proof is sufficient. Controlled after-fix output exercises the real policy and node-host handler, showing malformed calls denied before dispatch and valid URL-filter calls dispatched successfully.
Evidence reviewed

PR surface:

Source +33, Tests +42. Total +75 across 2 files.

View PR surface stats
Area Files Added Removed Net
Source 1 55 22 +33
Tests 1 42 0 +42
Docs 0 0 0 0
Config 0 0 0 0
Generated 0 0 0 0
Other 0 0 0 0
Total 2 97 22 +75

What I checked:

Likely related people:

  • steipete: The present Google Meet policy and node-host files enter the available checkout history in his commit; grafted snapshot history limits finer attribution. (role: recent area contributor; confidence: medium; commits: 920b29bdd5d8; files: extensions/google-meet/src/node-invoke-policy.ts, extensions/google-meet/src/node-host.ts)
  • Vincent Koc: The preceding available repository snapshot containing the Google Meet node-host surface is authored by Vincent Koc, though grafted history prevents precise feature-level attribution. (role: earlier area contributor; confidence: low; commits: e085fa1a3ffd; files: extensions/google-meet/src/node-host.ts, extensions/google-meet/src/realtime-node.ts)
What the crustacean ranks mean
  • 🦀 challenger crab: rare, exceptional readiness with strong proof, clean implementation, and convincing validation.
  • 🦞 diamond lobster: very strong readiness with only minor maintainer review expected.
  • 🐚 platinum hermit: good normal PR, likely mergeable with ordinary maintainer review.
  • 🦐 gold shrimp: useful signal, but proof or patch confidence is still limited.
  • 🦪 silver shellfish: thin signal; proof, validation, or implementation needs work.
  • 🧂 unranked krab: not merge-ready because proof is missing/unusable or there are serious correctness or safety concerns.
  • 🌊 off-meta tidepool: rating does not apply to this item.

Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

How this review workflow works
  • ClawSweeper keeps one durable marker-backed review comment per issue or PR.
  • Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
  • A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
  • PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
  • Maintainers can also comment @clawsweeper review to request a fresh review only.
  • Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
  • Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
  • Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.
Review history (3 earlier review cycles)
  • reviewed 2026-07-10T15:18:41.235Z sha 9673edb :: needs real behavior proof before merge. :: none
  • reviewed 2026-07-11T00:13:16.471Z sha 841b7eb :: needs maintainer review before merge. :: none
  • reviewed 2026-07-11T00:44:08.383Z sha d32a965 :: needs maintainer review before merge. :: none

@Leon-SK668

Copy link
Copy Markdown
Contributor Author

@clawsweeper re-review

Added controlled runtime proof to the PR body and refreshed the branch onto current main. The proof loads the real Google Meet node invoke policy and dispatches approved calls into the real handleGoogleMeetNodeHostCommand handler: malformed stopByUrl/pushAudio control payloads return GOOGLE_MEET_NODE_POLICY_DENIED with dispatched=0, while valid Meet stopByUrl and list filters reach the node-host handler and return stable JSON.

@clawsweeper

clawsweeper Bot commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

🦞🧹
ClawSweeper re-review requested.

I asked ClawSweeper to review this item again.
Action: item re-review queued (workflow sweep.yml, event repository_dispatch).
Result: the existing ClawSweeper review comment will be edited in place when the review finishes.

Re-review progress:

@clawsweeper clawsweeper Bot added proof: sufficient ClawSweeper judged the real behavior proof convincing. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. and removed rating: 🦪 silver shellfish Thin PR readiness signal; proof, validation, or implementation needs work. status: 📣 needs proof The PR needs real behavior proof before ClawSweeper can clear the contributor ask. labels Jul 11, 2026
@clawsweeper clawsweeper Bot added rating: 🦞 diamond lobster Very strong PR readiness with only minor maintainer review expected. and removed rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. labels Jul 11, 2026
@steipete steipete self-assigned this Jul 11, 2026
@steipete
steipete merged commit f8aa995 into openclaw:main Jul 11, 2026
97 checks passed
@steipete

Copy link
Copy Markdown
Contributor

Merged via squash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P2 Normal backlog priority with limited blast radius. plugin: google-meet proof: sufficient ClawSweeper judged the real behavior proof convincing. rating: 🦞 diamond lobster Very strong PR readiness with only minor maintainer review expected. size: S status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants