Skip to content

fix(qa): keep non-assistant fixtures out of token usage gate#103650

Merged
steipete merged 1 commit into
mainfrom
codex/fix-qa-parity-usage-applicability
Jul 10, 2026
Merged

fix(qa): keep non-assistant fixtures out of token usage gate#103650
steipete merged 1 commit into
mainfrom
codex/fix-qa-parity-usage-applicability

Conversation

@steipete

Copy link
Copy Markdown
Contributor

Closes #103641

What Problem This Solves

Resolves a release-validation problem where runtime token-efficiency proof treated deterministic startup and local fixture scenarios as missing assistant-message usage, even though those scenarios intentionally run no assistant turn.

Why This Change Was Made

Adds explicit, per-scenario usage applicability metadata and carries it in the runtime-parity artifact. Only seven cataloged non-assistant fixtures are marked not applicable. Missing or malformed metadata remains fail-closed as assistant-message-required; runtime failures, drift, required zero usage, and live reports containing only not-applicable captures still fail.

User Impact

Release operators get token aggregates based only on scenarios that can produce assistant usage, while parity failures and insufficient live evidence remain blocking.

Evidence

  • Exact live proof at 4bc300843d5ec9f071257c2900701f91df44e1c3 identified seven deterministic zero-usage fixture scenarios.
  • Blacksmith Testbox through Crabbox tbx_01kx5qan3y2kpr49rd9h4c5ajb: 111 focused QA Lab tests passed on rebased head 257c96b1e0c6a260f653855398d848a5ee6a59ae.
  • Blacksmith Testbox through Crabbox: changed typecheck, all lint shards, repository guards, and import-cycle analysis passed.
  • Fresh autoreview after rebase: no accepted or actionable findings.

@steipete

Copy link
Copy Markdown
Contributor Author

Land-ready proof for exact head 257c96b1e0c6a260f653855398d848a5ee6a59ae:

  • Focused QA Lab proof: 111 tests passed twice on Blacksmith Testbox through Crabbox tbx_01kx5qan3y2kpr49rd9h4c5ajb, including after rebase.
  • Broad proof: changed typecheck, all lint shards, repository guards, and import-cycle analysis passed on the same Testbox.
  • Fresh post-rebase autoreview: no accepted or actionable findings.
  • Exact-head hosted CI: 43 jobs passed, zero pending or failed: https://github.com/openclaw/openclaw/actions/runs/29088201702
  • Repo-native review artifacts validate as READY FOR /prepare-pr; OPENCLAW_TESTBOX=1 scripts/pr prepare-run 103650 passed.

Known proof gap: the full live runtime token/parity lane will be rerun on the landed main SHA. This PR intentionally does not relax the 15% token threshold or any runtime/parity failure gate.

@steipete
steipete merged commit 7b03a2a into main Jul 10, 2026
119 of 124 checks passed
@steipete
steipete deleted the codex/fix-qa-parity-usage-applicability branch July 10, 2026 11:12
@steipete

Copy link
Copy Markdown
Contributor Author

Merged via squash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

QA reports need explicit usage applicability for non-assistant parity flows

1 participant