fix(release): contain installer artifact restores#103608
Conversation
|
Pre-land proof for exact head
|
|
@vincentkoc @joshavant could one of you provide the human owner review for both the release-packaging and secops trust-boundary concerns here? You are members of both requested teams, so one approval from either of you covers both gates. Exact-head CI, immutable installer smoke, native prepare, and the focused security regressions are all green in the proof above. |
|
Codex review: needs maintainer review before merge. Reviewed July 10, 2026, 8:03 AM ET / 12:03 UTC. Summary PR surface: Tests +43, Other +26. Total +69 across 2 files. Reproducibility: yes. from source inspection: the pre-fix helper follows candidate-owned Review metrics: none identified. Root-cause cluster Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Risk before merge
Maintainer options:
Next step before merge
Maintainer decision needed
Security Review detailsBest possible solution: Keep the centralized physical-path validation and rollback design, obtain release/secops confirmation of its lifecycle invariant, then rerun focused and immutable installer smoke on the final integrated head. Do we have a high-confidence way to reproduce the issue? Yes from source inspection: the pre-fix helper follows candidate-owned Is this the best way to solve the issue? Yes, conditionally: validating once inside the existing shared restore helper and reusing those physical paths for swaps and rollback is the narrowest maintainable fix, provided workflow owners confirm the no-concurrency invariant. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 13819996adca. Label changesLabel changes:
Label justifications:
Evidence reviewedPR surface: Tests +43, Other +26. Total +69 across 2 files. View PR surface stats
Security concerns:
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
|
Merged via squash.
|
Related: #103552
Follow-up to #103556
What Problem This Solves
Fixes an issue where installer release smoke could restore prebuilt package artifacts through candidate-owned package path aliases.
Why This Change Was Made
The trusted harness now resolves the restore root once, requires the bundled AI package owner paths to remain inside that root, and rejects linked intermediate package directories before Docker or filesystem side effects. Artifact install and rollback reuse those validated physical paths.
User Impact
Release validation now fails closed before modifying build artifacts when a candidate checkout does not provide normal package directories. Normal installer and Bun package smoke behavior is unchanged.
Evidence
tbx_01kx5nyaw5vg1e15mx40cd8jv6/ Actions run29083395122:pnpm test test/scripts/test-install-sh-docker.test.ts(63/63 passed)oxfmt --checkpassedpnpm check:changedtooling lane passed8ebe7753772d600b4037b9a389e8ee7662077332plus frozen candidate811ddd96180583bae00001f71971419182ae0520: full installer smoke passed, including package integrity, fresh install/runtime load,2026.6.11to2026.7.1-beta.3update/doctor/runtime load, freshness policy, and non-root installers (4m0.5s, exit 0)8ebe7753772d: no accepted/actionable findingsAI-assisted; maintainer-reviewed proof and exact CI will remain attached to this PR.