fix(ui): preserve desktop lobster run outcomes#103501
Merged
Merged
Conversation
steipete
force-pushed
the
codex/fix-desktop-lobster-run-outcome
branch
from
July 10, 2026 07:09
60e0d29 to
c7aa2ee
Compare
Contributor
Author
|
Merged via squash.
|
This was referenced Jul 10, 2026
github-actions Bot
pushed a commit
to Desicool/openclaw
that referenced
this pull request
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #103489
Related: #103426
What Problem This Solves
Fixes an issue where desktop Control UI users could see the sidebar lobster celebrate a failed or aborted run because the new sessions-only panel dropped the terminal run outcome. The narrow drawer kept the correct behavior, so the same session produced different reactions across responsive layouts.
Why This Change Was Made
The desktop panel now passes the existing
resolveLobsterRunOutcomeresult through the same component property already used by the drawer and by the pre-#103426 shared render. The change adds symmetric panel/drawer regression coverage without changing the resolver, pet lifecycle, session contract, or visual layout.User Impact
The desktop lobster can once again react honestly to terminal run state: failed and timed-out runs receive the error reaction, killed runs receive the aborted reaction, and successful runs remain unchanged.
Evidence
tbx_01kx5c7d77sgck8mhyewtnpbrg):pnpm test ui/src/components/app-sidebar.test.tsfailed only the two new desktop-panel cases (failed: expectederror, gotok;killed: expectedaborted, gotok) while both drawer controls and four existing tests passed.sidebar-customization.e2e.test.tspassed 3/3, including the new desktop-to-drawer failed-outcome assertion (572 ms).pnpm check:changed -- ui/src/components/app-sidebar.ts ui/src/components/app-sidebar.test.ts ui/src/e2e/sidebar-customization.e2e.test.tspassed typecheck, lint, guards, and import-cycle checks (56.4 s).pnpm format:checkpassed all three files;git diff --checkpassed.b4c2a3c9c808was clean (a49cf7960a13341e8c16f0a68361048fa6c95093).maina97633a9ad89; exact head isc7aa2eeae8d2, and the stable patch-id remained4430301841e9da869d94495f59b3a4882d5152b4.Landing is intentionally held behind security PR #103502 while exact-head CI runs.
AI-assisted: implemented and independently reviewed with Codex; the maintainer understands the one-line runtime change and the test matrix.