fix(ui): use default cursor for mount fallback#103448
Merged
Merged
Conversation
openclaw-barnacle
Bot
added
app: web-ui
steipete
force-pushed
the
codex/fix-control-ui-cursor-contract
branch
from
July 10, 2026 07:11
b8fb6a0 to
d85f606
Compare
steipete
force-pushed
the
codex/fix-control-ui-cursor-contract
branch
from
July 10, 2026 10:32
d85f606 to
dd03e75
Compare
Contributor
Author
|
Land-ready proof for exact head
Known proof gap: no separate cross-OS cursor run. The change is one platform-independent CSS declaration and is covered in Chromium's computed style plus the production UI build; no OS-specific runtime path is touched. Best-fix verdict: yes. The static fallback owns the stale declaration, so deleting it there avoids a second override and preserves the fallback's independence from the main app bundle. |
Contributor
Author
|
Merged via squash.
|
github-actions Bot
pushed a commit
to Desicool/openclaw
that referenced
this pull request
Jul 11, 2026
* fix(ui): use default cursor for mount fallback * test(ui): focus mount fallback cursor coverage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #103444
Related: #103357, #103411
What Problem This Solves
Users who reach the Control UI mount-failure fallback still see the pointer hand over
Try againandKeep waiting, although these are internal controls and the Control UI reserves the pointer for real links.Why This Change Was Made
The stale inline
cursor: pointerdeclaration is removed at the fallback style owner. The browser regression loads the real productionui/index.htmlshell in Chromium and checks both fallback controls plus the genuine troubleshooting link, without duplicating unrelated application cursor selectors.User Impact
The fallback controls now use the default arrow like other Control UI controls. The troubleshooting hyperlink keeps the pointer hand.
Evidence
bcf27989206d31bf4780c7857fc30f579357fa92retains the stale declaration. On Blacksmith Testbox through Crabboxtbx_01kx5rr94tpbdvqt71cwdv7ewf, the focused Chromium test failed only because both fallback controls computed topointer; the real link still computed topointer(3 passed, 1 failed).corepack pnpm check:changedon the same Testbox lease passed in 9m03s, including typechecks, full core/UI/package lint fanout, database-first and import-cycle guards.corepack pnpm ui:buildon the same Testbox lease passed.dd03e75497d1beb69cc602ebe8dbf4fb5d1098d5(43 successful jobs, 12 intentionally skipped, zero failed).OPENCLAW_TESTBOX=1.Provenance: the stale declaration was introduced in #80644 (
42fc84f4b4c63a1075d98be91855bee7267c0e57) by @BunsDev and became inconsistent when the Control UI cursor convention changed in #103357 and #103411.AI-assisted change. I reviewed the production fallback actions, inline styles, current-main behavior, adjacent mount-fallback tests, sibling cursor contracts, history, and validation results.