test(terminal): cover C1 control filtering#103439
Conversation
311b5f1 to
66af534
Compare
|
Codex review: needs real behavior proof before merge. Reviewed July 10, 2026, 6:53 AM ET / 10:53 UTC. Summary PR surface: Tests +8. Total +8 across 1 file. Reproducibility: yes. Current main implements C1 filtering in Review metrics: none identified. Root-cause cluster Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Refresh the branch onto current main and land the focused assertions without production changes, preserving terminal-core as owner of complete ANSI parsing and the gateway renderer as owner of residual control filtering. Do we have a high-confidence way to reproduce the issue? Yes. Current main implements C1 filtering in Is this the best way to solve the issue? Yes. Extending the existing owning test with exhaustive boundary cases is the narrowest maintainable solution and avoids production churn or a duplicate harness. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 6eb9a5ada23b. Label changesLabel changes:
Label justifications:
Evidence reviewedPR surface: Tests +8. Total +8 across 1 file. View PR surface stats
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
66af534 to
ebb1cfc
Compare
ebb1cfc to
b1c3b89
Compare
|
Land-ready proof for exact head
Known broad-suite gaps are unrelated to this test-only gateway diff: aggregate-only custom-element registration in |
|
Merged via squash.
|
Closes #103435
What Problem This Solves
Fixes a release-proof gap where the C1-control filtering landed in #103274 had no focused regression coverage, so an off-by-one or removal regression could pass the existing terminal buffer tests.
Why This Change Was Made
The test now covers a valid C1 CSI sequence, every residual C1 character from U+0080 through U+009F, and both adjacent boundaries: DEL remains filtered while U+00A0 and tabs remain visible. Production code is unchanged.
User Impact
No runtime behavior changes. Release and future refactor validation now protect the intended
terminal.textplain-text contract.Evidence
b1c3b899910cf58aaa0d1b0bf29d6bc2b1cb4f6con currentmainbase7b03a2ae201ab9c27dc3bc39569e97c9f9582360; original patch-id preserved.tbx_01kx5tbg2gqvkkkgxrv15bjban: final-head focused gateway proof passed in all four routed projects (4 files, 24 tests).corepack pnpm check:changedpassed (coreTeststypecheck, lint, and guards).git diff --check: passed.The previous exact-head CI failure was unrelated:
test/scripts/tsdown-build.test.tsobserved an already-dead process-group child. Fresh exact-head hosted checks are rerunning after the rebase.