Skip to content

improve(qa): verify native Slack chart delivery#103337

Merged
steipete merged 4 commits into
mainfrom
codex/slack-chart-live-qa
Jul 10, 2026
Merged

improve(qa): verify native Slack chart delivery#103337
steipete merged 4 commits into
mainfrom
codex/slack-chart-live-qa

Conversation

@steipete

@steipete steipete commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Related: #12602
Follow-up to #102635

What Problem This Solves

Resolves two release-proof gaps: Slack portable chart delivery had no automated live assertion that the message tool reaches Slack as a native chart with accessible fallback text, and private QA builds incorrectly applied the published SDK declaration budget to a different unified-build chunk topology.

Why This Change Was Made

Adds an opt-in Slack QA scenario that sends a portable line chart through the normal message-tool path, then reads Slack history with the SUT identity and requires both the native data_visualization block and exact accessible top-level text. Deterministic provider coverage exercises the same tool call and rejects text-only delivery.

The SDK checker keeps the published public-entry graph capped at 5,000,000 bytes. Private QA builds retain all export, dependency, and forbidden-specifier checks, but use a separate 5,025,000-byte cap for the public roots compiled under private-only chunk topology; measured sizes and the selected cap are printed on every build.

User Impact

No runtime behavior changes. Release validation can catch native-chart and accessibility regressions, while secret-bearing QA workflows no longer fail against a publication-only size threshold. Published package growth remains protected by the unchanged 5 MB cap.

Evidence

@steipete

Copy link
Copy Markdown
Contributor Author

Land-ready verification completed at exact PR head 6c1e7832fe8c7b42a2c9f36aa920dca43472ec81.

  • Repo-native hosted gate: OPENCLAW_TESTBOX=1 scripts/pr prepare-run 103337 passed without rebasing or changing the prepared head.
  • Exact-head CI: run 29072107152 completed successfully (43 successful jobs, 12 expected skips, no failures).
  • Real Slack native-chart proof: run 29072104333, Slack job 86295779371 passed on Linux / Node 24.13.0. The evidence artifact targets the exact PR head and verifies the native data_visualization block plus deterministic accessible text in 20,055 ms.
  • Focused Blacksmith Testbox proof: Slack runtime 42 passed; deterministic mock provider 117 passed; declaration-budget boundaries 3 passed.
  • Node 24 builds: public SDK declarations 4,981,236 / 5,000,000 bytes; private-QA topology 5,004,947 / 5,025,000 bytes.
  • Fresh exact-head autoreview: clean, no actionable findings; git diff --check passed.

Separate release-infrastructure blocker, not masked by this landing: the WhatsApp job in the same multi-lane live run failed before scenario execution with WhatsApp session logged out. Run: openclaw channels login. Baseline run 29070313773 failed identically before this PR head, so the WhatsApp credential archive must be relogged or reseeded before that release lane can pass.

@steipete
steipete merged commit 54009c1 into main Jul 10, 2026
98 checks passed
@steipete
steipete deleted the codex/slack-chart-live-qa branch July 10, 2026 05:58
@steipete

Copy link
Copy Markdown
Contributor Author

Merged via squash.

github-actions Bot pushed a commit to Desicool/openclaw that referenced this pull request Jul 10, 2026
* test(qa): prove Slack native chart delivery

* test(qa): exercise Slack chart verifier through scenario

* fix(build): bound private QA SDK declarations separately

* fix(qa): normalize Slack chart history whitespace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

extensions: qa-lab maintainer Maintainer-authored PR scripts Repository scripts size: L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant