Skip to content

fix(ci): serialize real TUI PTY backends#103006

Merged
steipete merged 1 commit into
mainfrom
codex/tui-pty-serial-release
Jul 9, 2026
Merged

fix(ci): serialize real TUI PTY backends#103006
steipete merged 1 commit into
mainfrom
codex/tui-pty-serial-release

Conversation

@steipete

@steipete steipete commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

What Problem This Solves

Fixes an issue where release CI could time out a real-Gateway TUI PTY scenario under host contention even though the same user path was healthy.

In CI run 29033041664, the fresh-session scenario hit its 150-second test timeout while sibling real-backend tests took 18–67 seconds. The suite was launching several real Gateway/PTY stacks concurrently on the smaller manual-dispatch runner.

Why This Change Was Made

The real-backend PTY suite is intentionally serial again. Per-test onTestFinished and idempotent cleanup remain unchanged; only resource-contending execution is removed.

This restores the proven stabilization from 0d86f64 after concurrency was re-enabled by c20ce00. It does not increase timeouts, add retries, weaken assertions, or change TUI/Gateway runtime behavior.

User Impact

No product runtime change. Release CI keeps all eight real TUI backend scenarios while avoiding runner-load timeouts.

Evidence

  • Failed concurrent release run: fresh-session test timed out at 150 seconds; 26/27 shard tests passed.
  • Same-code current-main rerun passed, confirming runner sensitivity rather than a deterministic runtime regression.
  • Historical sequential CI passed all eight real-backend scenarios in 139.1 seconds; the fresh-session case took 14.6 seconds.
  • Blacksmith Testbox tbx_01kx3vqjpczaqa5qmv9cjdw92g: full TUI PTY config passed 27/27 tests in 72.90 seconds. The serialized real-backend suite passed 8/8 in 63.48 seconds; fresh-session passed in 6.27 seconds.
  • git diff --check passed.
  • Final autoreview --mode local reported no accepted/actionable findings (patch is correct, confidence 0.99).

@steipete steipete self-assigned this Jul 9, 2026
@openclaw-barnacle openclaw-barnacle Bot added size: XS maintainer Maintainer-authored PR labels Jul 9, 2026
@clawsweeper

clawsweeper Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

ClawSweeper status: review started.

I am starting a fresh review of this pull request: fix(ci): serialize real TUI PTY backends This is item 1/1 in the current shard. Shard 0/1.

This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking.

Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted.

@steipete

steipete commented Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

Land-ready proof for exact head 31c139272d38dc322786913c493e77d8f27510b4:

  • Blacksmith Testbox tbx_01kx3vqjpczaqa5qmv9cjdw92g: TUI PTY config passed 27/27; all 8 serialized real-Gateway cases passed in 63.48s; fresh-session case passed in 6.27s.
  • The broader changed-surface gate completed clean on the same Testbox in 9m46s.
  • Fresh structured autoreview: no findings, 0.99 confidence.
  • git diff --check origin/main...HEAD: pass.
  • Exact-head hosted CI run 29034692391: 43 passed, 12 expected skips, 0 failures.

The release failure was intra-worker resource contention from describe.concurrent; product behavior and assertions are unchanged. Serialization is intentional because every case owns a real Gateway and PTY stack.

@steipete
steipete merged commit cd50d49 into main Jul 9, 2026
113 of 115 checks passed
@steipete
steipete deleted the codex/tui-pty-serial-release branch July 9, 2026 16:55
@steipete

steipete commented Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

Merged via squash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintainer Maintainer-authored PR size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant