You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fixes an issue where every full CI run fails in the native-app i18n inventory after the Android orphan-screen cleanup removed the last $deviceModel · $appVersion source string.
Why This Change Was Made
The inventory test still contains many active Android and Apple source assertions, including Kotlin interpolation coverage. This removes only the assertion for the deleted settings-screen copy; it does not weaken inventory generation or production behavior.
This test-only main repair is required to validate the active Google Chat, Gemini, model-catalog, and CLI-audio fixes currently in the landing queue.
User Impact
No product behavior changes. Full CI can validate new changes again instead of failing on copy deleted by #102809.
Evidence
Before: node scripts/run-vitest.mjs test/scripts/native-app-i18n.test.ts failed exactly one assertion at line 53.
The test file, generated native-source inventory, and entire apps/android tree had identical Git object IDs on the failing PR head and current origin/main, proving baseline ownership.
After: the same focused command passes all 5 tests.
git diff --check passes; diff is one deleted stale assertion.
Superseded by the stronger repair now on main in 2786239.
That change replaces the deleted Android copy sentinel with the active Preview · $domain source, so the inventory test keeps direct coverage for bare Kotlin interpolation while removing the stale assertion introduced by #102809. The focused 5-test inventory suite and native inventory check pass. Closing this deletion-only branch in favor of the landed fix.
Superseded by 27862390809a750e2a6a210f6b166c5f2aa506a4 on main, which replaces the deleted Android string with the active Preview · $domain inventory sentinel. That is slightly stronger than this deletion-only patch because it preserves a live interpolation assertion.
The exact-head matrix here was green, and current main now contains the same baseline repair in its better form, so this PR is no longer needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #102809
What Problem This Solves
Fixes an issue where every full CI run fails in the native-app i18n inventory after the Android orphan-screen cleanup removed the last
$deviceModel · $appVersionsource string.Why This Change Was Made
The inventory test still contains many active Android and Apple source assertions, including Kotlin interpolation coverage. This removes only the assertion for the deleted settings-screen copy; it does not weaken inventory generation or production behavior.
This test-only
mainrepair is required to validate the active Google Chat, Gemini, model-catalog, and CLI-audio fixes currently in the landing queue.User Impact
No product behavior changes. Full CI can validate new changes again instead of failing on copy deleted by #102809.
Evidence
node scripts/run-vitest.mjs test/scripts/native-app-i18n.test.tsfailed exactly one assertion at line 53.apps/androidtree had identical Git object IDs on the failing PR head and currentorigin/main, proving baseline ownership.git diff --checkpasses; diff is one deleted stale assertion.