Skip to content

refactor(android): remove orphaned legacy screens#102809

Merged
vincentkoc merged 1 commit into
mainfrom
refactor/deadcode-all-surfaces-20260709-v92
Jul 9, 2026
Merged

refactor(android): remove orphaned legacy screens#102809
vincentkoc merged 1 commit into
mainfrom
refactor/deadcode-all-surfaces-20260709-v92

Conversation

@vincentkoc

Copy link
Copy Markdown
Member

What Problem This Solves

Two legacy Android Compose surfaces remained after their only entry points were removed:

  • SettingsSheet was orphaned when PostOnboardingTabs was deleted in 17777b3a9ff.
  • ChatSheetContent was orphaned when its ChatSheet wrapper was deleted in cd86107a10f.

The dead files retained about 1,600 lines of unreachable UI, stale source-inventory entries, and several unused Android helpers and design-token accessors.

Why This Change Was Made

  • Delete the two unreferenced legacy Composables.
  • Move the two still-live initial-chat helpers into ChatScreen.
  • Rename their tests to match the surviving owners.
  • Remove exact-zero-reference Android properties and token accessors.
  • Regenerate the native i18n source inventory.
  • Correct stale Android source-of-truth paths in apps/android/style.md.

Current ShellScreen continues to own the active ChatScreen path, and SettingsScreens remains the active settings implementation.

User Impact

No intended behavior change. This removes unreachable Android code and stale generated inventory while preserving the active chat and settings surfaces.

Evidence

  • Blacksmith Testbox-through-Crabbox tbx_01kx3df9b86as54x9y3q425gha
    • ./apps/android/gradlew -p apps/android --no-daemon app:lintPlayDebug app:ktlintCheck app:testPlayDebugUnitTest app:assemblePlayDebug
    • pnpm native:i18n:check
    • path-scoped pnpm check:changed
  • Strict iOS Periphery workflow passed on the same mobile-source snapshot: https://github.com/openclaw/openclaw/actions/runs/29017712719
  • Fresh local and branch autoreviews: no actionable findings.
  • Refreshed codebase-memory graph: 283,893 nodes / 1,140,887 edges; no SettingsSheet or ChatSheetContent symbol remains.

@vincentkoc vincentkoc self-assigned this Jul 9, 2026
@openclaw-barnacle openclaw-barnacle Bot added app: android App: android size: XL maintainer Maintainer-authored PR labels Jul 9, 2026
@vincentkoc

Copy link
Copy Markdown
Member Author

Land-ready proof:

Behavioral sweep:

  • Active chat remains ShellScreen -> ChatScreen; the two live initial-chat helpers moved with that owner.
  • Active settings remain routed through SettingsScreens.
  • SettingsSheet and ChatSheetContent had no callers after their sole wrappers were removed in earlier landed refactors.
  • Native i18n inventory was regenerated and contains no references to the deleted files.

Known proof gaps: none.

@vincentkoc
vincentkoc marked this pull request as ready for review July 9, 2026 13:02
@vincentkoc
vincentkoc merged commit cb7468f into main Jul 9, 2026
70 of 76 checks passed
@vincentkoc
vincentkoc deleted the refactor/deadcode-all-surfaces-20260709-v92 branch July 9, 2026 13:02
@vincentkoc

Copy link
Copy Markdown
Member Author

Merged via squash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app: android App: android maintainer Maintainer-authored PR size: XL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant