fix(ui-eventlog): use truncateUtf16Safe for event payload truncation#102735
fix(ui-eventlog): use truncateUtf16Safe for event payload truncation#102735lzyyzznl wants to merge 1 commit into
Conversation
|
Thanks for the context here. I swept through the related work, and this is now duplicate or superseded. This PR is superseded by an older, stronger open PR that owns the same Overview Event Log UTF-16 truncation bug with a presenter helper, regression test, and accepted real behavior proof. Root-cause cluster Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. Canonical path: Use #102625 as the canonical landing path for this bug because it includes the same production fix plus regression coverage and accepted real behavior proof. So I’m closing this here and keeping the remaining discussion on #102625. Review detailsBest possible solution: Use #102625 as the canonical landing path for this bug because it includes the same production fix plus regression coverage and accepted real behavior proof. Do we have a high-confidence way to reproduce the issue? Yes from source inspection: current main renders Overview Event Log payload previews with raw Is this the best way to solve the issue? No for this branch as the best landing path: the code change is plausible, but #102625 is the better solution because it centralizes the preview formatter and adds regression proof. Security review: Security review cleared: The diff only imports an existing internal text-normalization helper and changes UI display truncation; no security or supply-chain surface is added. AGENTS.md: found and applied where relevant. What I checked:
Likely related people:
Codex review notes: model internal, reasoning high; reviewed against 6621ead871a9. |
|
Thanks for the fix. I’m closing this as superseded by #102625. Its reviewed head covers the same Overview event-log surface, reuses the existing UI truncation helper directly, and adds a DOM-level boundary regression without creating another one-use production adapter. |
|
The canonical fix in #102625 has now landed as It covers the same Overview event-log payload boundary, uses the canonical Control UI truncation helper, and includes a DOM-level surrogate-boundary regression backed by exact-head CI and Chromium proof. Keeping this PR closed as superseded. Thank you again for the contribution. |
What Problem This Solves
One
.slice(0, 120)truncation site in the Event Log UI may cut UTF-16 surrogate pairs in half when the event payload text contains multi-byte characters such as emoji.Why This Change Was Made
ui/src/pages/overview/event-log.tsuses raw.slice(0, 120)for event payload display truncation. Replacing withtruncateUtf16Safeensures truncated output is always valid Unicode.User Impact
Truncated event payload text in the overview UI remains valid Unicode at existing size limits. No behavioral changes for ASCII-only content.
Evidence
.slice(0, 120)totruncateUtf16SafetruncateUtf16Safeis already used in other UI filesGenerated with Claude Code