fix(macos): keep Settings below native titlebar controls#102663
Merged
Conversation
openclaw-barnacle
Bot
added
app: macos
Contributor
|
Codex review: stale review; fresh review needed. Summary Next step |
Contributor
Author
|
Land-ready verification for
Known proof gap: no rebuilt signed-app screenshot was captured. The exact native injection contract is covered by the macOS test/CI, and the resulting layout geometry was verified separately against the live stylesheet. |
Contributor
Author
|
Merged via squash.
|
github-actions Bot
pushed a commit
to Desicool/openclaw
that referenced
this pull request
Jul 10, 2026
…2663) * fix(macos): clear settings titlebar controls * chore: leave release notes to release automation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
Fixes an issue where users opening Control UI Settings inside the macOS app would see the native window controls overlap the Back to app control.
Why This Change Was Made
The Settings takeover now gives its header the same native titlebar clearance as the normal sidebar. This keeps the first interactive row below both the traffic lights and the AppKit drag regions instead of moving the action into a non-clickable titlebar surface.
User Impact
Mac app users can see and use Back to app without interference from the native close, minimize, and zoom controls.
AI-assisted: implemented and reviewed with Codex.
Evidence
y=14…46; with the native presentation, it occupiedy=50…82, clearing the titlebar interaction band ending aty=46while retaining the ESC hint.swift test --package-path apps/macos --filter DashboardWindowSmokeTests— 9 tests passed, including the new native chrome selector regression.tbx_01kx36rqmphcsrp5104hmtx45w:corepack pnpm check:changedpassed on the exact branch content..agents/skills/autoreview/scripts/autoreview --mode branch --base origin/main --stream-engine-output— no accepted or actionable findings; patch correct at 0.98 confidence.